[GitHub] [flink] wuchong commented on a change in pull request #8234: [FLINK-12288] [table-planner-blink] Bump Calcite dependency to 1.19.0 in blink planner

[GitBox <gi...@apache.org>]

wuchong commented on a change in pull request #8234: [FLINK-12288] [table-planner-blink] Bump Calcite dependency to 1.19.0 in blink planner
URL: https://github.com/apache/flink/pull/8234#discussion_r277254753
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/test/resources/org/apache/flink/table/plan/stream/sql/join/JoinTest.xml
 ##########
 @@ -444,9 +444,8 @@ SELECT * FROM
 LogicalProject(i=[$0], j=[$1], t=[$2], i0=[$3], k=[$4])
 +- LogicalJoin(condition=[AND(=($0, $3), =($0, $4))], joinType=[full])
    :- LogicalTableScan(table=[[MyTable3, source: [TestTableSource(i, j, t)]]])
-   +- LogicalSort(sort0=[$0], sort1=[$1], dir0=[DESC-nulls-last], dir1=[ASC-nulls-first])
-      +- LogicalProject(i=[$0], k=[$1])
-         +- LogicalTableScan(table=[[MyTable4, source: [TestTableSource(i, k)]]])
+   +- LogicalProject(i=[$0], k=[$1])
+      +- LogicalTableScan(table=[[MyTable4, source: [TestTableSource(i, k)]]])
 
 Review comment:
   It seems that Calcite removes `LogicalSort` in the initial RelNode tree. And it makes sense.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services