Re: [PR] [HUDI-8920] Optimized SerDe costs of Flink write (excluding bulk insert and append mode) [hudi]

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #12796:
URL: https://github.com/apache/hudi/pull/12796#discussion_r1957014966


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bucket/BucketStreamWriteFunction.java:
##########
@@ -121,21 +126,34 @@ public void snapshotState() {
   }
 
   @Override
-  public void processElement(I i, ProcessFunction<I, Object>.Context context, Collector<Object> collector) throws Exception {
-    HoodieRecord<?> record = (HoodieRecord<?>) i;
-    final HoodieKey hoodieKey = record.getKey();
-    final String partition = hoodieKey.getPartitionPath();
-    final HoodieRecordLocation location;
+  public void processElement(HoodieFlinkInternalRow record,
+                             ProcessFunction<HoodieFlinkInternalRow, Object>.Context context,
+                             Collector<Object> collector) throws Exception {
+    RowData row = record.getRowData();
+    // [HUDI-8969] Analyze how to get rid of excessive conversions, should be a subtask of RFC-88

Review Comment:
   Maybe in this PR we change it to buffer RowData instead, and convert it to `HoodieRecord` before flushing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org