You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openmeetings.apache.org by Maxim Solodovnik <so...@gmail.com> on 2019/03/01 13:41:12 UTC
Re: [jira] [Commented] (OPENMEETINGS-1986) using backspace
Thanks Peter,
I'm afraid I need environment to reproduce it
Maybe some additional handler is required `keydown`, `keypress`
Will try to reproduce locally first
On Fri, 1 Mar 2019 at 19:50, Peter Dähn <da...@vcrp.de> wrote:
> Hi Maxim,
>
> I put a console.log(a) in that switch case where backspace should be
> prevented...
>
>
>
>
> Do you need something here?
>
> Am 01.03.19 um 09:34 schrieb Maxim Solodovnik (JIRA):
>
> [ https://issues.apache.org/jira/browse/OPENMEETINGS-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16781459#comment-16781459 ]
>
> Maxim Solodovnik commented on OPENMEETINGS-1986:
> ------------------------------------------------
>
> [~fetzer], [~p_daehn]
>
> The problem here: backspace is already prevented [1], so I need to reproduce it to understand what is wrong with current fix ...)
>
> Will try to also test on Windows machine
>
>
>
> [1] https://github.com/apache/openmeetings/blob/4.0.x/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/raw-wb-area.js#L96
>
> using backspace
> ---------------
>
> Key: OPENMEETINGS-1986
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-1986
> Project: Openmeetings
> Issue Type: Bug
> Components: UI
> Affects Versions: 4.0.7
> Reporter: Peter Dähn
> Assignee: Maxim Solodovnik
> Priority: Major
>
> Through backspace in Firefox you leave the room because this button lets you go back in the browser history.
> This could be prevented by displaying a dialog box.
>
> --
> This message was sent by Atlassian JIRA
> (v7.6.3#76005)
>
>
>
>
--
WBR
Maxim aka solomax
Re: [jira] [Commented] (OPENMEETINGS-1986) using backspace
Posted by Maxim Solodovnik <so...@gmail.com>.
Hello Peter,
it seems you are testing your own version and you are building it from
source
So I have created `OPENMEETINGS-1986-backspace` branch with `keydown`
handler
To test please do the following:
1) checkout this branch `OPENMEETINGS-1986-backspace`
2) Build and test as usual :)
On Sat, 2 Mar 2019 at 00:41, Maxim Solodovnik <so...@gmail.com> wrote:
> Hello Peter,
>
> Thanks for testing
> I'll try to create custom build on demo with fix like that and will ask
> you to test
>
> This will be done most probably the day after tomorrow
> My dog is sick (currently on surgery) so I will be off duty some time :(
>
> On Fri, Mar 1, 2019, 21:50 Peter Dähn <da...@vcrp.de> wrote:
>
>>
>> Hi Maxim,
>>
>> I added keydown handler here (in the min.js file)
>>
>>
>> this file...
>>
>> https://github.com/apache/openmeetings/blob/4.0.x/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/raw-wb-area.js#L96
>>
>>
>>
>>
>> and browser back is prevented (at least as moderator/presenter I think...)
>>
>>
>>
>> Greetings Peter
>>
>> Am 01.03.19 um 15:08 schrieb Peter Dähn:
>>
>> Hi Maxim,
>>
>> as I tested it now, browser back allready happen on keydown or
>> keypressed. But prevent code is triggert on keyup (as far as I could see
>> on the screenshot...)
>>
>> Greetings Peter
>>
>>
>> Am 01.03.19 um 14:41 schrieb Maxim Solodovnik:
>>
>> Thanks Peter,
>>
>> I'm afraid I need environment to reproduce it
>> Maybe some additional handler is required `keydown`, `keypress`
>> Will try to reproduce locally first
>>
>> On Fri, 1 Mar 2019 at 19:50, Peter Dähn <da...@vcrp.de> <da...@vcrp.de>> wrote:
>>
>> Hi Maxim,
>>
>> I put a console.log(a) in that switch case where backspace should
>> be prevented...
>>
>>
>>
>>
>> Do you need something here?
>>
>> Am 01.03.19 um 09:34 schrieb Maxim Solodovnik (JIRA):
>>
>> [ https://issues.apache.org/jira/browse/OPENMEETINGS-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16781459#comment-16781459 ]
>>
>> Maxim Solodovnik commented on OPENMEETINGS-1986:
>> ------------------------------------------------
>>
>> [~fetzer], [~p_daehn]
>>
>> The problem here: backspace is already prevented [1], so I need to reproduce it to understand what is wrong with current fix ...)
>>
>> Will try to also test on Windows machine
>>
>>
>>
>> [1] https://github.com/apache/openmeetings/blob/4.0.x/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/raw-wb-area.js#L96
>>
>> using backspace
>> ---------------
>>
>> Key: OPENMEETINGS-1986
>> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-1986
>> Project: Openmeetings
>> Issue Type: Bug
>> Components: UI
>> Affects Versions: 4.0.7
>> Reporter: Peter Dähn
>> Assignee: Maxim Solodovnik
>> Priority: Major
>>
>> Through backspace in Firefox you leave the room because this button lets you go back in the browser history.
>> This could be prevented by displaying a dialog box.
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v7.6.3#76005)
>>
>>
>> --
>> WBR
>> Maxim aka solomax
>>
>>
>>
>>
--
WBR
Maxim aka solomax
Re: [jira] [Commented] (OPENMEETINGS-1986) using backspace
Posted by Maxim Solodovnik <so...@gmail.com>.
Hello Peter,
Thanks for testing
I'll try to create custom build on demo with fix like that and will ask you
to test
This will be done most probably the day after tomorrow
My dog is sick (currently on surgery) so I will be off duty some time :(
On Fri, Mar 1, 2019, 21:50 Peter Dähn <da...@vcrp.de> wrote:
>
> Hi Maxim,
>
> I added keydown handler here (in the min.js file)
>
>
> this file...
>
> https://github.com/apache/openmeetings/blob/4.0.x/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/raw-wb-area.js#L96
>
>
>
>
> and browser back is prevented (at least as moderator/presenter I think...)
>
>
>
> Greetings Peter
>
> Am 01.03.19 um 15:08 schrieb Peter Dähn:
>
> Hi Maxim,
>
> as I tested it now, browser back allready happen on keydown or
> keypressed. But prevent code is triggert on keyup (as far as I could see
> on the screenshot...)
>
> Greetings Peter
>
>
> Am 01.03.19 um 14:41 schrieb Maxim Solodovnik:
>
> Thanks Peter,
>
> I'm afraid I need environment to reproduce it
> Maybe some additional handler is required `keydown`, `keypress`
> Will try to reproduce locally first
>
> On Fri, 1 Mar 2019 at 19:50, Peter Dähn <da...@vcrp.de> <da...@vcrp.de>> wrote:
>
> Hi Maxim,
>
> I put a console.log(a) in that switch case where backspace should
> be prevented...
>
>
>
>
> Do you need something here?
>
> Am 01.03.19 um 09:34 schrieb Maxim Solodovnik (JIRA):
>
> [ https://issues.apache.org/jira/browse/OPENMEETINGS-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16781459#comment-16781459 ]
>
> Maxim Solodovnik commented on OPENMEETINGS-1986:
> ------------------------------------------------
>
> [~fetzer], [~p_daehn]
>
> The problem here: backspace is already prevented [1], so I need to reproduce it to understand what is wrong with current fix ...)
>
> Will try to also test on Windows machine
>
>
>
> [1] https://github.com/apache/openmeetings/blob/4.0.x/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/raw-wb-area.js#L96
>
> using backspace
> ---------------
>
> Key: OPENMEETINGS-1986
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-1986
> Project: Openmeetings
> Issue Type: Bug
> Components: UI
> Affects Versions: 4.0.7
> Reporter: Peter Dähn
> Assignee: Maxim Solodovnik
> Priority: Major
>
> Through backspace in Firefox you leave the room because this button lets you go back in the browser history.
> This could be prevented by displaying a dialog box.
>
> --
> This message was sent by Atlassian JIRA
> (v7.6.3#76005)
>
>
>
> --
> WBR
> Maxim aka solomax
>
>
>
>
Re: [jira] [Commented] (OPENMEETINGS-1986) using backspace
Posted by Peter Dähn <da...@vcrp.de>.
> Hi Maxim,
>
> I added keydown handler here (in the min.js file)
this file...
https://github.com/apache/openmeetings/blob/4.0.x/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/raw-wb-area.js#L96
>
>
>
> and browser back is prevented (at least as moderator/presenter I think...)
>
>
>
> Greetings Peter
>
> Am 01.03.19 um 15:08 schrieb Peter Dähn:
>> Hi Maxim,
>>
>> as I tested it now, browser back allready happen on keydown or
>> keypressed. But prevent code is triggert on keyup (as far as I could see
>> on the screenshot...)
>>
>> Greetings Peter
>>
>>
>> Am 01.03.19 um 14:41 schrieb Maxim Solodovnik:
>>> Thanks Peter,
>>>
>>> I'm afraid I need environment to reproduce it
>>> Maybe some additional handler is required `keydown`, `keypress`
>>> Will try to reproduce locally first
>>>
>>> On Fri, 1 Mar 2019 at 19:50, Peter Dähn <daehn@vcrp.de
>>> <ma...@vcrp.de>> wrote:
>>>
>>> Hi Maxim,
>>>
>>> I put a console.log(a) in that switch case where backspace should
>>> be prevented...
>>>
>>>
>>>
>>>
>>> Do you need something here?
>>>
>>> Am 01.03.19 um 09:34 schrieb Maxim Solodovnik (JIRA):
>>>> [ https://issues.apache.org/jira/browse/OPENMEETINGS-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16781459#comment-16781459 ]
>>>>
>>>> Maxim Solodovnik commented on OPENMEETINGS-1986:
>>>> ------------------------------------------------
>>>>
>>>> [~fetzer], [~p_daehn]
>>>>
>>>> The problem here: backspace is already prevented [1], so I need to reproduce it to understand what is wrong with current fix ...)
>>>>
>>>> Will try to also test on Windows machine
>>>>
>>>>
>>>>
>>>> [1] https://github.com/apache/openmeetings/blob/4.0.x/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/raw-wb-area.js#L96
>>>>
>>>>> using backspace
>>>>> ---------------
>>>>>
>>>>> Key: OPENMEETINGS-1986
>>>>> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-1986
>>>>> Project: Openmeetings
>>>>> Issue Type: Bug
>>>>> Components: UI
>>>>> Affects Versions: 4.0.7
>>>>> Reporter: Peter Dähn
>>>>> Assignee: Maxim Solodovnik
>>>>> Priority: Major
>>>>>
>>>>> Through backspace in Firefox you leave the room because this button lets you go back in the browser history.
>>>>> This could be prevented by displaying a dialog box.
>>>> --
>>>> This message was sent by Atlassian JIRA
>>>> (v7.6.3#76005)
>>>>
>>> --
>>> WBR
>>> Maxim aka solomax
>
Re: [jira] [Commented] (OPENMEETINGS-1986) using backspace
Posted by Peter Dähn <da...@vcrp.de>.
Hi Maxim,
I added keydown handler here (in the min.js file)
and browser back is prevented (at least as moderator/presenter I think...)
Greetings Peter
Am 01.03.19 um 15:08 schrieb Peter Dähn:
> Hi Maxim,
>
> as I tested it now, browser back allready happen on keydown or
> keypressed. But prevent code is triggert on keyup (as far as I could see
> on the screenshot...)
>
> Greetings Peter
>
>
> Am 01.03.19 um 14:41 schrieb Maxim Solodovnik:
>> Thanks Peter,
>>
>> I'm afraid I need environment to reproduce it
>> Maybe some additional handler is required `keydown`, `keypress`
>> Will try to reproduce locally first
>>
>> On Fri, 1 Mar 2019 at 19:50, Peter Dähn <daehn@vcrp.de
>> <ma...@vcrp.de>> wrote:
>>
>> Hi Maxim,
>>
>> I put a console.log(a) in that switch case where backspace should
>> be prevented...
>>
>>
>>
>>
>> Do you need something here?
>>
>> Am 01.03.19 um 09:34 schrieb Maxim Solodovnik (JIRA):
>>> [ https://issues.apache.org/jira/browse/OPENMEETINGS-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16781459#comment-16781459 ]
>>>
>>> Maxim Solodovnik commented on OPENMEETINGS-1986:
>>> ------------------------------------------------
>>>
>>> [~fetzer], [~p_daehn]
>>>
>>> The problem here: backspace is already prevented [1], so I need to reproduce it to understand what is wrong with current fix ...)
>>>
>>> Will try to also test on Windows machine
>>>
>>>
>>>
>>> [1] https://github.com/apache/openmeetings/blob/4.0.x/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/raw-wb-area.js#L96
>>>
>>>> using backspace
>>>> ---------------
>>>>
>>>> Key: OPENMEETINGS-1986
>>>> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-1986
>>>> Project: Openmeetings
>>>> Issue Type: Bug
>>>> Components: UI
>>>> Affects Versions: 4.0.7
>>>> Reporter: Peter Dähn
>>>> Assignee: Maxim Solodovnik
>>>> Priority: Major
>>>>
>>>> Through backspace in Firefox you leave the room because this button lets you go back in the browser history.
>>>> This could be prevented by displaying a dialog box.
>>> --
>>> This message was sent by Atlassian JIRA
>>> (v7.6.3#76005)
>>>
>>
>>
>> --
>> WBR
>> Maxim aka solomax
>
Re: [jira] [Commented] (OPENMEETINGS-1986) using backspace
Posted by Peter Dähn <da...@vcrp.de>.
Hi Maxim,
as I tested it now, browser back allready happen on keydown or
keypressed. But prevent code is triggert on keyup (as far as I could see
on the screenshot...)
Greetings Peter
Am 01.03.19 um 14:41 schrieb Maxim Solodovnik:
> Thanks Peter,
>
> I'm afraid I need environment to reproduce it
> Maybe some additional handler is required `keydown`, `keypress`
> Will try to reproduce locally first
>
> On Fri, 1 Mar 2019 at 19:50, Peter Dähn <daehn@vcrp.de
> <ma...@vcrp.de>> wrote:
>
> Hi Maxim,
>
> I put a console.log(a) in that switch case where backspace should
> be prevented...
>
>
>
>
> Do you need something here?
>
> Am 01.03.19 um 09:34 schrieb Maxim Solodovnik (JIRA):
>> [ https://issues.apache.org/jira/browse/OPENMEETINGS-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16781459#comment-16781459 ]
>>
>> Maxim Solodovnik commented on OPENMEETINGS-1986:
>> ------------------------------------------------
>>
>> [~fetzer], [~p_daehn]
>>
>> The problem here: backspace is already prevented [1], so I need to reproduce it to understand what is wrong with current fix ...)
>>
>> Will try to also test on Windows machine
>>
>>
>>
>> [1] https://github.com/apache/openmeetings/blob/4.0.x/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/raw-wb-area.js#L96
>>
>>> using backspace
>>> ---------------
>>>
>>> Key: OPENMEETINGS-1986
>>> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-1986
>>> Project: Openmeetings
>>> Issue Type: Bug
>>> Components: UI
>>> Affects Versions: 4.0.7
>>> Reporter: Peter Dähn
>>> Assignee: Maxim Solodovnik
>>> Priority: Major
>>>
>>> Through backspace in Firefox you leave the room because this button lets you go back in the browser history.
>>> This could be prevented by displaying a dialog box.
>> --
>> This message was sent by Atlassian JIRA
>> (v7.6.3#76005)
>>
>
>
>
> --
> WBR
> Maxim aka solomax