[jira] [Comment Edited] (CLOUDSTACK-3753) Multiple VLAN range API need to accept a list rather than "add" or "remove" per command

["Sheng Yang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718145#comment-13718145 ] 

Sheng Yang edited comment on CLOUDSTACK-3753 at 7/24/13 9:05 AM:
-----------------------------------------------------------------

I know the API need a way to represent the non-continguous vlan range. But it should not be "add" and "remove" in the API. API should represent "status", rather than "action" in this case. 

So when user call the API, the vlan would be changed according to parameter "vlan", which is a list. And any vlan not in the list would consider "removed". And any vlan not in the list before but show in the list now should be considered "added".
                
      was (Author: yasker):
    I know the API need a way to represent the non-continguous vlan range. But it should not be "add" and "remove" in the API. API should represent "status", rather than "action" in this case. 

So when user call the API, the vlan would be changed according to parameter "vlan", which is a list. And any vlan not in the list would consider "removed". 
                  
> Multiple VLAN range API need to accept a list rather than "add" or "remove" per command
> ---------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-3753
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3753
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Network Controller
>    Affects Versions: 4.2.0
>            Reporter: Sheng Yang
>            Priority: Blocker
>             Fix For: 4.2.0
>
>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Non+contiguous+vlan+ranges
> "vlan parameter will add a new vlan range to the existing vlan range (new behavior). if the new vlan range overlaps the existing vlan range it will extend that vlan (This is the existing behavior.).
> removevlan parameter will remove the mentioned vlan. The removevlan and vlan parameters can be used together. If the vlan range we are trying to remove is in use, the operation will not succeed."
> I haven't seen such API in the CloudStack. It's much more clean to use a list here(even for ranges, can be extended from one element, like "1-2, 4-5, 6-7"), rather than newly defined "vlan"/"removevlan" behavior. It broke API compatibility(e.g. the previous API potentially able to change vlan directly, rather than add it), and is also user unfriendly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira