[GitHub] [hudi] yihua commented on pull request #4974: [HUDI-3494] Consider triggering condition of MOR compaction during archival

["yihua (via GitHub)" <gi...@apache.org>]

yihua commented on PR #4974:
URL: https://github.com/apache/hudi/pull/4974#issuecomment-1732668865

   > > The default triggering condition is the number of delta commits, with the config of hoodie.compact.inline.max.delta.commits. If this setting is larger than the archival config of hoodie.keep.max.commits, there is not enough delta commits in the active timeline and the compaction will never happen.
   > 
   > why not just throw exception when `hoodie.compact.inline.max.delta.commits` > `hoodie.keep.max.commits`
   
   I think auto adjustment in archival process is better than failing the job in this case.  Also, in Hudi 1.x we plan to deprecate archival as the new LSM timeline design can provide fast lookup on much larger number of commits, and the problem in this PR will not be relevant in Hudi 1.x.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org