You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by as...@apache.org on 2025/12/11 10:18:24 UTC

(superset) 01/01: fix(margin): fixing margin issues

This is an automated email from the ASF dual-hosted git repository.

asoare pushed a commit to branch alexandrusoare/fix/space-between-configs
in repository https://gitbox.apache.org/repos/asf/superset.git

commit db250b9e9d1296c1fb2065da583f695c7249e6ef
Author: alexandrusoare <al...@gmail.com>
AuthorDate: Tue Dec 9 12:44:00 2025 +0200

    fix(margin): fixing margin issues
---
 .../src/features/databases/DatabaseModal/ExtraOptions.tsx      | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/superset-frontend/src/features/databases/DatabaseModal/ExtraOptions.tsx b/superset-frontend/src/features/databases/DatabaseModal/ExtraOptions.tsx
index b2c6c9398e..e334c61e7b 100644
--- a/superset-frontend/src/features/databases/DatabaseModal/ExtraOptions.tsx
+++ b/superset-frontend/src/features/databases/DatabaseModal/ExtraOptions.tsx
@@ -469,9 +469,7 @@ const ExtraOptions = ({
           ),
           children: (
             <>
-              <StyledInputContainer
-                css={!isFileUploadSupportedByEngine ? no_margin_bottom : {}}
-              >
+              <StyledInputContainer css={no_margin_bottom}>
                 <div className="input-container">
                   <Checkbox
                     id="per_user_caching"
@@ -491,7 +489,7 @@ const ExtraOptions = ({
                 </div>
               </StyledInputContainer>
               <StyledInputContainer
-                css={!isFileUploadSupportedByEngine ? no_margin_bottom : {}}
+                css={isFileUploadSupportedByEngine ? no_margin_bottom : {}}
               >
                 <div className="input-container">
                   <Checkbox
@@ -518,7 +516,7 @@ const ExtraOptions = ({
               </StyledInputContainer>
               {isFileUploadSupportedByEngine && (
                 <StyledInputContainer
-                  css={!db?.allow_file_upload ? no_margin_bottom : {}}
+                  css={db?.allow_file_upload ? no_margin_bottom : {}}
                 >
                   <div className="input-container">
                     <Checkbox
@@ -534,7 +532,7 @@ const ExtraOptions = ({
                 </StyledInputContainer>
               )}
               {isFileUploadSupportedByEngine && !!db?.allow_file_upload && (
-                <StyledInputContainer css={no_margin_bottom}>
+                <StyledInputContainer className="extra-container">
                   <div className="control-label">
                     {t('Schemas allowed for File upload')}
                   </div>