You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2017/11/22 06:19:19 UTC

[GitHub] mistercrunch commented on issue #3920: [Bugfix] Single Druid dimension spec error (part 2)

mistercrunch commented on issue #3920: [Bugfix] Single Druid dimension spec error (part 2)
URL: https://github.com/apache/incubator-superset/pull/3920#issuecomment-346254528
 
 
   @fabianmenges touched this last, any comments? But there's a history of tweaks around edge cases here...
   
   The PR seems right as we should end the `if` block with a catchall `else:` that falls back on a groupby query.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services