You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2022/08/24 11:18:27 UTC
[GitHub] [thrift] m-g-r opened a new pull request, #2646: Thrift 5410
m-g-r opened a new pull request, #2646:
URL: https://github.com/apache/thrift/pull/2646
fixes [THRIFT-5410](https://issues.apache.org/jira/browse/THRIFT-5410): "CL build broken: Component :NET.DIDIERVERNA.CLON.TERMIO not found"
and makes `make check` work again with cl included.
tested with configure called as `./configure --with-ruby=no --with-php=no --with-nodejs=no --with-cpp=no --with-python=no --with-kotlin=no` to test only cl as the others would not work on my system or take really long.
had to revert:
1. Revert "THRIFT-5501 Remove Common Lisp support"
This reverts commit d88d4f93b3390989bd47a43f3941ca7d576750f6.
2. Revert "THRIFT-5567: remove cl namespace references (#2580)"
This reverts commit 45471decdf572156189e66db59c8a1e82085299f.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] m-g-r commented on pull request #2646: THRIFT-5410 CL build broken: Component :NET.DIDIERVERNA.CLON.TERMIO not found
Posted by GitBox <gi...@apache.org>.
m-g-r commented on PR #2646:
URL: https://github.com/apache/thrift/pull/2646#issuecomment-1227458342
> > Could you tell me where and when you get this error?
>
> On this page. Not sure if you can see it as well, since you may not have the necessary permissions.
>
> 
Indeed that looks different for me:
Well, why do you not use a different merge strategy? That pull down menu that shows "Rebase and merge" should also have the strategies "Create a merge commit" or "Squash and merge", right? Both should work.
The reason that rebase wouldn't work is that it tries to rebase each commit individually and that doesn't work as support for Kotlin was added meanwhile and thus I had to fix that when merging with current master. This fixing is in this commit: https://github.com/apache/thrift/pull/2646/commits/78e3582a65d326a9757dd9afdf9fdb3f0aa601f1
Hard to make rebase and revert commits work at the same time...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2646: THRIFT-5410 CL build broken: Component :NET.DIDIERVERNA.CLON.TERMIO not found
Posted by GitBox <gi...@apache.org>.
Jens-G commented on PR #2646:
URL: https://github.com/apache/thrift/pull/2646#issuecomment-1232100291
> From my perspective this is done.
Agree.
> If there is another problem with the lisp backend, you can write me to have a look.
Good to know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G closed pull request #2646: THRIFT-5410 CL build broken: Component :NET.DIDIERVERNA.CLON.TERMIO not found
Posted by GitBox <gi...@apache.org>.
Jens-G closed pull request #2646: THRIFT-5410 CL build broken: Component :NET.DIDIERVERNA.CLON.TERMIO not found
URL: https://github.com/apache/thrift/pull/2646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2646: Thrift 5410
Posted by GitBox <gi...@apache.org>.
Jens-G commented on PR #2646:
URL: https://github.com/apache/thrift/pull/2646#issuecomment-1226370282
> This branch cannot be rebased due to conflicts
Anything we can do about that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] m-g-r commented on pull request #2646: THRIFT-5410 CL build broken: Component :NET.DIDIERVERNA.CLON.TERMIO not found
Posted by GitBox <gi...@apache.org>.
m-g-r commented on PR #2646:
URL: https://github.com/apache/thrift/pull/2646#issuecomment-1231512509
Maybe you want to do the two reversions in a different pull request? Then this can be rebased... but I see no need for it and suggest to use "Create a merge commit" approach.
This PR contains the revert as well as asked for in https://issues.apache.org/jira/browse/THRIFT-5410?focusedCommentId=17584163&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17584163
From my perspective this is done. If there is another problem with the lisp backend, you can write me to have a look.
Cheers, Max
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2646: THRIFT-5410 CL build broken: Component :NET.DIDIERVERNA.CLON.TERMIO not found
Posted by GitBox <gi...@apache.org>.
Jens-G commented on PR #2646:
URL: https://github.com/apache/thrift/pull/2646#issuecomment-1227172383
> Could you tell me where and when you get this error?
On this page. Not sure if you can see it as well, since you may not have the necessary permissions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] m-g-r commented on pull request #2646: THRIFT-5410 CL build broken: Component :NET.DIDIERVERNA.CLON.TERMIO not found
Posted by GitBox <gi...@apache.org>.
m-g-r commented on PR #2646:
URL: https://github.com/apache/thrift/pull/2646#issuecomment-1226978342
> This branch cannot be rebased due to conflicts
Could you tell me where and when you get this error?
On this page I only see: "This branch has no conflicts with the base branch" and on the checks page it reads: " Mergeable / Mergeable succeeded 12 hours ago ".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org