You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2017/08/08 09:43:04 UTC
Re: Review Request 61463: Fixed a bug in the test
`NamespacesIsolatorTest`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61463/
-----------------------------------------------------------
(Updated Aug. 8, 2017, 5:43 p.m.)
Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues, and Vinod Kone.
Changes
-------
Addressed comments.
Summary (updated)
-----------------
Fixed a bug in the test `NamespacesIsolatorTest`.
Repository: mesos
Description (updated)
-------
In this test, we used the command `stat -c %i` to get the current
process's pid/ipc namespace inode, that is not correct since
`/proc/self/ns/pid` and `/proc/self/ns/ipc` are symbol links, we
should get the inode that the link references rather than the link
itself. So we need to add a `-L` option in the `stat` command.
Diffs (updated)
-----
src/tests/containerizer/isolator_tests.cpp f3c541c92f8ecc5c12356363bbbf3561d3b75230
Diff: https://reviews.apache.org/r/61463/diff/2/
Changes: https://reviews.apache.org/r/61463/diff/1-2/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 61463: Fixed a bug in the test
`NamespacesIsolatorTest`.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61463/#review182741
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Aug. 8, 2017, 2:43 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61463/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2017, 2:43 a.m.)
>
>
> Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In this test, we used the command `stat -c %i` to get the current
> process's pid/ipc namespace inode, that is not correct since
> `/proc/self/ns/pid` and `/proc/self/ns/ipc` are symbol links, we
> should get the inode that the link references rather than the link
> itself. So we need to add a `-L` option in the `stat` command.
>
>
> Diffs
> -----
>
> src/tests/containerizer/isolator_tests.cpp f3c541c92f8ecc5c12356363bbbf3561d3b75230
>
>
> Diff: https://reviews.apache.org/r/61463/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>