You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/01 00:49:40 UTC

[GitHub] [arrow] wesm commented on pull request #6631: ARROW-8111: [C++][CSV] Support MM/DD/YYYY date format

wesm commented on pull request #6631:
URL: https://github.com/apache/arrow/pull/6631#issuecomment-622195001


   Thank you. There are some code linting issues and other code style issues (we follow the Google C++ style guide), can you fix the CI builds? I'd like to kick the tires a bit on this before merging since we don't have automated benchmark feedback on PRs yet
   
   Can you add a comment to the `timestamp_converters` argument about what will happen if it's not set, and what happens when you set more than one? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org