[GitHub] [beam] iemejia commented on a change in pull request #13658: [BEAM-10961] Enabled strict dependency on flink runner

[GitBox <gi...@apache.org>]

iemejia commented on a change in pull request #13658:
URL: https://github.com/apache/beam/pull/13658#discussion_r565904435



##########
File path: runners/flink/flink_runner.gradle
##########
@@ -137,11 +138,9 @@ dependencies {
   compile project(":runners:java-job-service")
   compile project(":sdks:java:extensions:google-cloud-platform-core")
   compile library.java.vendored_grpc_1_26_0
-  compile library.java.jackson_annotations
   compile library.java.slf4j_api
   compile library.java.joda_time
   compile library.java.args4j
-  compile "org.apache.flink:flink-clients_2.11:$flink_version"

Review comment:
       @ibzib I noticed this while testing the 2.28.0 SNAPSHOTs. Now from the user side I am forced to pass this dependency. Is this a regression? if this is intended (I doubt) we should probably announce it in CHANGES.md




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org