You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rajani Karuturi <ra...@gmail.com> on 2013/10/28 13:19:05 UTC
Review Request 14990: added formatter setting xml file for eclipse
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14990/
-----------------------------------------------------------
Review request for cloudstack, daan Hoogland and Prasanna Santhanam.
Repository: cloudstack-git
Description
-------
added formatter setting xml file for eclipse
Diffs
-----
tools/eclipse/ApacheCloudStack.xml PRE-CREATION
Diff: https://reviews.apache.org/r/14990/diff/
Testing
-------
Yes. Manually on intellij and eclipse
Thanks,
Rajani Karuturi
Re: Review Request 14990: added formatter setting xml file for eclipse
Posted by daan Hoogland <da...@gmail.com>.
> On Oct. 29, 2013, 1:21 p.m., daan Hoogland wrote:
> > Ship It!
4c6add84d866babcbc312ae441f615870087ac3d
- daan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14990/#review27672
-----------------------------------------------------------
On Oct. 28, 2013, 2:25 p.m., Rajani Karuturi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14990/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2013, 2:25 p.m.)
>
>
> Review request for cloudstack, daan Hoogland and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> added formatter setting xml file for eclipse
>
>
> Diffs
> -----
>
> tools/eclipse/ApacheCloudStack.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14990/diff/
>
>
> Testing
> -------
>
> Yes. Manually on eclipse kepler and intellij 12 Community edition running on ubuntu 13.04
>
>
> Thanks,
>
> Rajani Karuturi
>
>
Re: Review Request 14990: added formatter setting xml file for eclipse
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14990/#review27672
-----------------------------------------------------------
Ship it!
Ship It!
- daan Hoogland
On Oct. 28, 2013, 2:25 p.m., Rajani Karuturi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14990/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2013, 2:25 p.m.)
>
>
> Review request for cloudstack, daan Hoogland and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> added formatter setting xml file for eclipse
>
>
> Diffs
> -----
>
> tools/eclipse/ApacheCloudStack.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14990/diff/
>
>
> Testing
> -------
>
> Yes. Manually on eclipse kepler and intellij 12 Community edition running on ubuntu 13.04
>
>
> Thanks,
>
> Rajani Karuturi
>
>
Re: Review Request 14990: added formatter setting xml file for eclipse
Posted by Rajani Karuturi <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14990/
-----------------------------------------------------------
(Updated Oct. 28, 2013, 2:25 p.m.)
Review request for cloudstack, daan Hoogland and Prasanna Santhanam.
Repository: cloudstack-git
Description
-------
added formatter setting xml file for eclipse
Diffs
-----
tools/eclipse/ApacheCloudStack.xml PRE-CREATION
Diff: https://reviews.apache.org/r/14990/diff/
Testing (updated)
-------
Yes. Manually on eclipse kepler and intellij 12 Community edition running on ubuntu 13.04
Thanks,
Rajani Karuturi
Re: Review Request 14990: added formatter setting xml file for eclipse
Posted by Rajani Karuturi <ra...@gmail.com>.
> On Oct. 28, 2013, 1:52 p.m., daan Hoogland wrote:
> > If this work the patch should include removing the epf file. It makes no sense having both around, unless...
> > Is this xml format compatible with all eclipse versions? Did you test it with any?
>
> daan Hoogland wrote:
> i mean which ones?
I tested it on eclipse kepler and intellij 12 Community edition running on ubuntu 13.04
I didnt remove epf file as it can have more than code formatting settings.
- Rajani
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14990/#review27610
-----------------------------------------------------------
On Oct. 28, 2013, 2:25 p.m., Rajani Karuturi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14990/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2013, 2:25 p.m.)
>
>
> Review request for cloudstack, daan Hoogland and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> added formatter setting xml file for eclipse
>
>
> Diffs
> -----
>
> tools/eclipse/ApacheCloudStack.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14990/diff/
>
>
> Testing
> -------
>
> Yes. Manually on eclipse kepler and intellij 12 Community edition running on ubuntu 13.04
>
>
> Thanks,
>
> Rajani Karuturi
>
>
Re: Review Request 14990: added formatter setting xml file for eclipse
Posted by daan Hoogland <da...@gmail.com>.
> On Oct. 28, 2013, 1:52 p.m., daan Hoogland wrote:
> > If this work the patch should include removing the epf file. It makes no sense having both around, unless...
> > Is this xml format compatible with all eclipse versions? Did you test it with any?
i mean which ones?
- daan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14990/#review27610
-----------------------------------------------------------
On Oct. 28, 2013, 12:19 p.m., Rajani Karuturi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14990/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2013, 12:19 p.m.)
>
>
> Review request for cloudstack, daan Hoogland and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> added formatter setting xml file for eclipse
>
>
> Diffs
> -----
>
> tools/eclipse/ApacheCloudStack.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14990/diff/
>
>
> Testing
> -------
>
> Yes. Manually on intellij and eclipse
>
>
> Thanks,
>
> Rajani Karuturi
>
>
Re: Review Request 14990: added formatter setting xml file for eclipse
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14990/#review27610
-----------------------------------------------------------
If this work the patch should include removing the epf file. It makes no sense having both around, unless...
Is this xml format compatible with all eclipse versions? Did you test it with any?
- daan Hoogland
On Oct. 28, 2013, 12:19 p.m., Rajani Karuturi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14990/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2013, 12:19 p.m.)
>
>
> Review request for cloudstack, daan Hoogland and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> added formatter setting xml file for eclipse
>
>
> Diffs
> -----
>
> tools/eclipse/ApacheCloudStack.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14990/diff/
>
>
> Testing
> -------
>
> Yes. Manually on intellij and eclipse
>
>
> Thanks,
>
> Rajani Karuturi
>
>