[GitHub] [beam] lostluck commented on a diff in pull request #17782: [BEAM-14536] Handle 0.0 splits in offsetrange restriction

[GitBox <gi...@apache.org>]

lostluck commented on code in PR #17782:
URL: https://github.com/apache/beam/pull/17782#discussion_r887134011


##########
sdks/go/pkg/beam/core/runtime/exec/sdf.go:
##########
@@ -678,10 +678,6 @@ func (n *ProcessSizedElementsAndRestrictions) Checkpoint() ([]*FullValue, error)
 		return nil, addContext(err)
 	}
 
-	if !n.rt.IsDone() {
-		return nil, addContext(errors.Errorf("Primary restriction %#v is not done. Check that the RTracker's TrySplit() at fraction 0.0 returns a completed primary restriction", n.rt))
-	}

Review Comment:
   Glad this was caught. This is basically the only place we can tell the user if they've implemented the SDF incorrectly in some fashion. While it's later than ideal (at execution, rather than construction time), a hard abort is preferable to other correctness or dataloss issues.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org