You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "comphead (via GitHub)" <gi...@apache.org> on 2026/03/25 20:58:36 UTC
[PR] chore: Optimize schema rewriter usages [datafusion]
comphead opened a new pull request, #21158:
URL: https://github.com/apache/datafusion/pull/21158
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
- Closes #.
## Rationale for this change
Do not use cycles if predicate is not set or logic schema equal to physical schema
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Optimize schema rewriter usages [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #21158:
URL: https://github.com/apache/datafusion/pull/21158#issuecomment-4137721777
๐ค Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/21158#issuecomment-4137709444)
`Linux bench-c4137709444-568-8rfl7 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux`
Comparing schema_adapter (0346cbc4031e66816ca61a1181a3c00bb48a8615) to 51f13d7 (merge-base) [diff](https://github.com/apache/datafusion/compare/51f13d7435ccfd5ca38aa2d2d23ef0a04382ab74..0346cbc4031e66816ca61a1181a3c00bb48a8615) using: clickbench_partitioned
Results will be posted here when complete
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Optimize schema rewriter usages [datafusion]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on PR #21158:
URL: https://github.com/apache/datafusion/pull/21158#issuecomment-4129823130
Hi @adriangb appreciate if you can check the PR as expert in schema adapter rewrites, if you think it makes sense we can also port it to https://github.com/apache/datafusion/issues/21078 and https://github.com/apache/datafusion/issues/21079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Optimize schema rewriter usages [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #21158:
URL: https://github.com/apache/datafusion/pull/21158#issuecomment-4137792389
๐ค Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/21158#issuecomment-4137709444)
<details><summary>Details</summary>
<p>
```
Comparing HEAD and schema_adapter
--------------------
Benchmark tpch_sf1.json
--------------------
โโโโโโโโโโโโโณโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโณโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโณโโโโโโโโโโโโ
โ Query โ HEAD โ schema_adapter โ Change โ
โกโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโฉ
โ QQuery 1 โ 46.00 / 46.54 ยฑ0.68 / 47.87 ms โ 45.63 / 46.42 ยฑ1.02 / 48.39 ms โ no change โ
โ QQuery 2 โ 21.34 / 21.48 ยฑ0.10 / 21.59 ms โ 21.15 / 21.58 ยฑ0.51 / 22.57 ms โ no change โ
โ QQuery 3 โ 32.13 / 32.27 ยฑ0.17 / 32.55 ms โ 32.17 / 32.40 ยฑ0.17 / 32.58 ms โ no change โ
โ QQuery 4 โ 20.83 / 21.64 ยฑ0.68 / 22.42 ms โ 20.78 / 21.65 ยฑ0.65 / 22.33 ms โ no change โ
โ QQuery 5 โ 48.79 / 50.49 ยฑ1.16 / 52.02 ms โ 48.34 / 49.47 ยฑ1.10 / 51.54 ms โ no change โ
โ QQuery 6 โ 17.48 / 17.59 ยฑ0.10 / 17.72 ms โ 17.43 / 17.82 ยฑ0.45 / 18.43 ms โ no change โ
โ QQuery 7 โ 55.78 / 57.02 ยฑ1.15 / 58.50 ms โ 55.23 / 56.18 ยฑ0.74 / 57.47 ms โ no change โ
โ QQuery 8 โ 48.41 / 48.91 ยฑ0.25 / 49.12 ms โ 48.56 / 48.72 ยฑ0.10 / 48.85 ms โ no change โ
โ QQuery 9 โ 55.04 / 55.85 ยฑ0.48 / 56.40 ms โ 54.37 / 56.75 ยฑ1.90 / 59.98 ms โ no change โ
โ QQuery 10 โ 71.83 / 72.68 ยฑ0.66 / 73.77 ms โ 71.86 / 73.70 ยฑ1.41 / 76.13 ms โ no change โ
โ QQuery 11 โ 14.30 / 14.43 ยฑ0.10 / 14.60 ms โ 14.26 / 15.13 ยฑ0.98 / 16.71 ms โ no change โ
โ QQuery 12 โ 28.58 / 28.73 ยฑ0.08 / 28.79 ms โ 28.35 / 29.31 ยฑ0.86 / 30.77 ms โ no change โ
โ QQuery 13 โ 39.33 / 39.86 ยฑ0.35 / 40.42 ms โ 40.13 / 40.99 ยฑ0.74 / 42.26 ms โ no change โ
โ QQuery 14 โ 28.84 / 29.12 ยฑ0.20 / 29.44 ms โ 28.83 / 29.17 ยฑ0.48 / 30.09 ms โ no change โ
โ QQuery 15 โ 34.07 / 34.93 ยฑ0.74 / 35.82 ms โ 34.14 / 34.89 ยฑ1.18 / 37.22 ms โ no change โ
โ QQuery 16 โ 16.25 / 16.62 ยฑ0.32 / 17.17 ms โ 16.23 / 16.76 ยฑ0.40 / 17.24 ms โ no change โ
โ QQuery 17 โ 74.45 / 76.21 ยฑ1.47 / 78.64 ms โ 73.52 / 74.83 ยฑ1.16 / 76.46 ms โ no change โ
โ QQuery 18 โ 78.28 / 79.81 ยฑ1.25 / 81.26 ms โ 78.13 / 80.01 ยฑ1.87 / 83.50 ms โ no change โ
โ QQuery 19 โ 38.08 / 38.51 ยฑ0.45 / 39.26 ms โ 37.91 / 38.36 ยฑ0.34 / 38.85 ms โ no change โ
โ QQuery 20 โ 40.79 / 41.65 ยฑ0.63 / 42.42 ms โ 40.17 / 41.64 ยฑ1.02 / 43.00 ms โ no change โ
โ QQuery 21 โ 64.64 / 66.28 ยฑ1.07 / 67.67 ms โ 65.14 / 66.77 ยฑ1.40 / 68.95 ms โ no change โ
โ QQuery 22 โ 17.88 / 18.11 ยฑ0.14 / 18.31 ms โ 17.76 / 18.04 ยฑ0.26 / 18.46 ms โ no change โ
โโโโโโโโโโโโโดโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโโ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโณโโโโโโโโโโโ
โ Benchmark Summary โ โ
โกโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโฉ
โ Total Time (HEAD) โ 908.74ms โ
โ Total Time (schema_adapter) โ 910.61ms โ
โ Average Time (HEAD) โ 41.31ms โ
โ Average Time (schema_adapter) โ 41.39ms โ
โ Queries Faster โ 0 โ
โ Queries Slower โ 0 โ
โ Queries with No Change โ 22 โ
โ Queries with Failure โ 0 โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโ
```
</p>
</details>
<details><summary>Resource Usage</summary>
**tpch โ base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 4.8s |
| Peak memory | 4.0 GiB |
| Avg memory | 3.6 GiB |
| CPU user | 33.8s |
| CPU sys | 2.9s |
| Disk read | 0 B |
| Disk write | 136.0 KiB |
**tpch โ branch**
| Metric | Value |
|--------|-------|
| Wall time | 4.8s |
| Peak memory | 4.0 GiB |
| Avg memory | 3.6 GiB |
| CPU user | 33.8s |
| CPU sys | 3.0s |
| Disk read | 0 B |
| Disk write | 72.0 KiB |
</details>
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Optimize schema rewriter usages [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #21158:
URL: https://github.com/apache/datafusion/pull/21158#issuecomment-4137834661
๐ค Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/21158#issuecomment-4137709444)
<details><summary>Details</summary>
<p>
```
Comparing HEAD and schema_adapter
--------------------
Benchmark clickbench_partitioned.json
--------------------
โโโโโโโโโโโโโณโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโณโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโณโโโโโโโโโโโโโโโโ
โ Query โ HEAD โ schema_adapter โ Change โ
โกโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโฉ
โ QQuery 0 โ 1.36 / 4.70 ยฑ6.51 / 17.71 ms โ 1.37 / 4.75 ยฑ6.53 / 17.80 ms โ no change โ
โ QQuery 1 โ 15.05 / 15.44 ยฑ0.23 / 15.76 ms โ 14.58 / 15.29 ยฑ0.38 / 15.66 ms โ no change โ
โ QQuery 2 โ 45.89 / 46.35 ยฑ0.31 / 46.83 ms โ 45.18 / 46.01 ยฑ0.77 / 47.38 ms โ no change โ
โ QQuery 3 โ 43.67 / 45.26 ยฑ1.15 / 46.79 ms โ 47.04 / 48.33 ยฑ0.95 / 49.34 ms โ 1.07x slower โ
โ QQuery 4 โ 291.10 / 296.76 ยฑ3.64 / 301.93 ms โ 333.04 / 341.89 ยฑ8.16 / 353.18 ms โ 1.15x slower โ
โ QQuery 5 โ 345.15 / 347.79 ยฑ2.55 / 352.09 ms โ 394.38 / 397.87 ยฑ2.37 / 400.88 ms โ 1.14x slower โ
โ QQuery 6 โ 5.65 / 6.53 ยฑ0.97 / 8.41 ms โ 6.63 / 8.97 ยฑ2.35 / 13.45 ms โ 1.37x slower โ
โ QQuery 7 โ 17.05 / 17.52 ยฑ0.50 / 18.44 ms โ 18.05 / 18.31 ยฑ0.18 / 18.53 ms โ no change โ
โ QQuery 8 โ 417.04 / 427.68 ยฑ6.55 / 436.64 ms โ 421.74 / 479.79 ยฑ42.43 / 533.88 ms โ 1.12x slower โ
โ QQuery 9 โ 638.48 / 716.63 ยฑ39.48 / 743.25 ms โ 632.03 / 650.84 ยฑ11.31 / 661.32 ms โ +1.10x faster โ
โ QQuery 10 โ 100.09 / 102.80 ยฑ2.08 / 105.86 ms โ 93.47 / 97.45 ยฑ5.41 / 107.97 ms โ +1.05x faster โ
โ QQuery 11 โ 112.66 / 114.91 ยฑ1.33 / 116.63 ms โ 104.48 / 106.66 ยฑ1.77 / 109.37 ms โ +1.08x faster โ
โ QQuery 12 โ 350.88 / 384.16 ยฑ16.73 / 394.58 ms โ 346.63 / 358.07 ยฑ9.19 / 373.22 ms โ +1.07x faster โ
โ QQuery 13 โ 459.03 / 472.60 ยฑ7.82 / 481.75 ms โ 457.24 / 473.72 ยฑ19.64 / 511.62 ms โ no change โ
โ QQuery 14 โ 350.55 / 357.26 ยฑ6.19 / 368.65 ms โ 350.11 / 356.64 ยฑ6.11 / 367.91 ms โ no change โ
โ QQuery 15 โ 376.35 / 399.59 ยฑ22.10 / 435.56 ms โ 359.58 / 382.74 ยฑ22.39 / 425.49 ms โ no change โ
โ QQuery 16 โ 809.18 / 853.01 ยฑ39.89 / 899.08 ms โ 812.18 / 853.06 ยฑ26.08 / 881.64 ms โ no change โ
โ QQuery 17 โ 710.05 / 773.15 ยฑ45.05 / 840.03 ms โ 730.25 / 780.43 ยฑ49.66 / 858.37 ms โ no change โ
โ QQuery 18 โ 1464.71 / 1506.04 ยฑ34.43 / 1562.58 ms โ 1387.09 / 1574.40 ยฑ108.09 / 1691.69 ms โ no change โ
โ QQuery 19 โ 37.02 / 46.98 ยฑ10.77 / 66.03 ms โ 36.71 / 38.65 ยฑ1.66 / 41.45 ms โ +1.22x faster โ
โ QQuery 20 โ 717.89 / 743.43 ยฑ29.62 / 792.44 ms โ 719.29 / 746.52 ยฑ25.54 / 794.61 ms โ no change โ
โ QQuery 21 โ 763.16 / 777.63 ยฑ8.76 / 788.10 ms โ 763.47 / 779.83 ยฑ16.56 / 809.65 ms โ no change โ
โ QQuery 22 โ 1130.21 / 1171.21 ยฑ23.48 / 1198.45 ms โ 1125.30 / 1146.18 ยฑ21.78 / 1178.15 ms โ no change โ
โ QQuery 23 โ 3107.64 / 3236.30 ยฑ130.09 / 3441.59 ms โ 3057.42 / 3180.93 ยฑ90.67 / 3260.95 ms โ no change โ
โ QQuery 24 โ 99.89 / 102.66 ยฑ1.47 / 104.25 ms โ 98.81 / 103.26 ยฑ2.74 / 107.38 ms โ no change โ
โ QQuery 25 โ 139.17 / 141.69 ยฑ1.56 / 143.34 ms โ 138.09 / 140.12 ยฑ1.99 / 143.52 ms โ no change โ
โ QQuery 26 โ 101.71 / 102.40 ยฑ0.86 / 104.04 ms โ 98.83 / 100.96 ยฑ1.17 / 101.92 ms โ no change โ
โ QQuery 27 โ 856.41 / 869.48 ยฑ6.66 / 874.05 ms โ 837.05 / 844.06 ยฑ4.41 / 850.34 ms โ no change โ
โ QQuery 28 โ 7748.02 / 7823.70 ยฑ49.10 / 7881.93 ms โ 7701.38 / 7844.37 ยฑ74.28 / 7916.38 ms โ no change โ
โ QQuery 29 โ 51.50 / 54.48 ยฑ4.45 / 63.32 ms โ 50.93 / 55.98 ยฑ5.39 / 64.21 ms โ no change โ
โ QQuery 30 โ 365.17 / 391.97 ยฑ17.46 / 415.27 ms โ 369.96 / 377.08 ยฑ6.26 / 384.52 ms โ no change โ
โ QQuery 31 โ 401.20 / 427.55 ยฑ17.59 / 455.17 ms โ 369.03 / 375.99 ยฑ6.62 / 388.30 ms โ +1.14x faster โ
โ QQuery 32 โ 1075.36 / 1157.08 ยฑ55.09 / 1231.03 ms โ 1137.72 / 1218.69 ยฑ90.45 / 1392.58 ms โ 1.05x slower โ
โ QQuery 33 โ 1450.68 / 1495.62 ยฑ40.71 / 1557.45 ms โ 1468.29 / 1599.09 ยฑ97.43 / 1681.47 ms โ 1.07x slower โ
โ QQuery 34 โ 1476.58 / 1609.04 ยฑ98.28 / 1705.62 ms โ 1472.71 / 1477.52 ยฑ5.29 / 1486.95 ms โ +1.09x faster โ
โ QQuery 35 โ 382.33 / 391.46 ยฑ5.33 / 398.71 ms โ 385.60 / 392.55 ยฑ4.15 / 396.54 ms โ no change โ
โ QQuery 36 โ 119.28 / 121.82 ยฑ2.55 / 126.43 ms โ 125.26 / 127.28 ยฑ1.69 / 130.00 ms โ no change โ
โ QQuery 37 โ 47.18 / 50.08 ยฑ2.63 / 53.72 ms โ 49.02 / 50.21 ยฑ0.68 / 50.94 ms โ no change โ
โ QQuery 38 โ 74.80 / 76.58 ยฑ1.44 / 78.23 ms โ 74.33 / 75.86 ยฑ1.16 / 77.55 ms โ no change โ
โ QQuery 39 โ 206.40 / 219.33 ยฑ9.67 / 228.63 ms โ 224.06 / 231.66 ยฑ8.27 / 245.27 ms โ 1.06x slower โ
โ QQuery 40 โ 24.20 / 26.35 ยฑ1.52 / 28.90 ms โ 26.74 / 28.18 ยฑ1.64 / 30.61 ms โ 1.07x slower โ
โ QQuery 41 โ 20.26 / 21.60 ยฑ0.87 / 22.92 ms โ 20.78 / 22.26 ยฑ1.15 / 24.30 ms โ no change โ
โ QQuery 42 โ 18.92 / 19.86 ยฑ0.60 / 20.52 ms โ 20.57 / 21.15 ยฑ0.44 / 21.69 ms โ 1.06x slower โ
โโโโโโโโโโโโโดโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโโโโโโ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโณโโโโโโโโโโโโโ
โ Benchmark Summary โ โ
โกโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโฉ
โ Total Time (HEAD) โ 27966.47ms โ
โ Total Time (schema_adapter) โ 27973.62ms โ
โ Average Time (HEAD) โ 650.38ms โ
โ Average Time (schema_adapter) โ 650.55ms โ
โ Queries Faster โ 7 โ
โ Queries Slower โ 10 โ
โ Queries with No Change โ 26 โ
โ Queries with Failure โ 0 โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโโโ
```
</p>
</details>
<details><summary>Resource Usage</summary>
**clickbench_partitioned โ base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 141.0s |
| Peak memory | 40.1 GiB |
| Avg memory | 32.5 GiB |
| CPU user | 1324.2s |
| CPU sys | 96.8s |
| Disk read | 0 B |
| Disk write | 2.8 GiB |
**clickbench_partitioned โ branch**
| Metric | Value |
|--------|-------|
| Wall time | 141.2s |
| Peak memory | 43.2 GiB |
| Avg memory | 29.8 GiB |
| CPU user | 1315.6s |
| CPU sys | 104.6s |
| Disk read | 0 B |
| Disk write | 764.0 KiB |
</details>
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Optimize schema rewriter usages [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #21158:
URL: https://github.com/apache/datafusion/pull/21158#issuecomment-4137725843
๐ค Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/21158#issuecomment-4137709444)
`Linux bench-c4137709444-569-v4ff8 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux`
Comparing schema_adapter (0346cbc4031e66816ca61a1181a3c00bb48a8615) to 51f13d7 (merge-base) [diff](https://github.com/apache/datafusion/compare/51f13d7435ccfd5ca38aa2d2d23ef0a04382ab74..0346cbc4031e66816ca61a1181a3c00bb48a8615) using: tpcds
Results will be posted here when complete
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Optimize schema rewriter usages [datafusion]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on PR #21158:
URL: https://github.com/apache/datafusion/pull/21158#issuecomment-4129949559
> Nice!
>
> Does this show up in any benchmarks? I think if we can show a perf improvement (i.e. a regression when this code was originally introduced) then that's a good justification to backport ๐
I'm running rn on distributed cluster through Comet and will attach a reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Optimize schema rewriter usages [datafusion]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead merged PR #21158:
URL: https://github.com/apache/datafusion/pull/21158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Optimize schema rewriter usages [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #21158:
URL: https://github.com/apache/datafusion/pull/21158#issuecomment-4137823594
๐ค Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/21158#issuecomment-4137709444)
<details><summary>Details</summary>
<p>
```
Comparing HEAD and schema_adapter
--------------------
Benchmark tpcds_sf1.json
--------------------
โโโโโโโโโโโโโณโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโณโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโณโโโโโโโโโโโโโโโโ
โ Query โ HEAD โ schema_adapter โ Change โ
โกโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโฉ
โ QQuery 1 โ 43.12 / 44.02 ยฑ0.77 / 45.12 ms โ 43.10 / 44.01 ยฑ0.86 / 45.61 ms โ no change โ
โ QQuery 2 โ 145.64 / 146.94 ยฑ1.15 / 148.46 ms โ 145.59 / 146.92 ยฑ1.22 / 148.91 ms โ no change โ
โ QQuery 3 โ 114.00 / 115.77 ยฑ1.02 / 116.73 ms โ 114.39 / 114.97 ยฑ0.53 / 115.88 ms โ no change โ
โ QQuery 4 โ 1345.44 / 1365.40 ยฑ13.05 / 1385.78 ms โ 1301.63 / 1343.02 ยฑ23.08 / 1372.65 ms โ no change โ
โ QQuery 5 โ 172.81 / 174.26 ยฑ1.33 / 175.89 ms โ 172.42 / 176.22 ยฑ2.34 / 179.07 ms โ no change โ
โ QQuery 6 โ 990.74 / 1038.40 ยฑ31.39 / 1075.54 ms โ 1030.46 / 1056.20 ยฑ21.14 / 1085.07 ms โ no change โ
โ QQuery 7 โ 353.55 / 356.65 ยฑ3.17 / 362.61 ms โ 352.86 / 357.02 ยฑ3.04 / 360.19 ms โ no change โ
โ QQuery 8 โ 115.00 / 116.70 ยฑ1.62 / 119.44 ms โ 114.72 / 116.50 ยฑ1.12 / 117.77 ms โ no change โ
โ QQuery 9 โ 101.47 / 105.02 ยฑ2.42 / 107.68 ms โ 100.62 / 103.32 ยฑ3.26 / 107.33 ms โ no change โ
โ QQuery 10 โ 108.27 / 109.53 ยฑ0.96 / 111.00 ms โ 108.21 / 109.00 ยฑ0.54 / 109.90 ms โ no change โ
โ QQuery 11 โ 968.49 / 978.81 ยฑ9.72 / 994.46 ms โ 917.60 / 925.15 ยฑ7.72 / 938.76 ms โ +1.06x faster โ
โ QQuery 12 โ 45.57 / 47.17 ยฑ0.87 / 48.06 ms โ 44.15 / 45.75 ยฑ1.47 / 48.32 ms โ no change โ
โ QQuery 13 โ 407.73 / 412.07 ยฑ5.20 / 421.84 ms โ 400.66 / 404.00 ยฑ1.82 / 405.77 ms โ no change โ
โ QQuery 14 โ 1018.17 / 1036.38 ยฑ11.35 / 1046.80 ms โ 1013.65 / 1026.98 ยฑ7.37 / 1036.18 ms โ no change โ
โ QQuery 15 โ 16.72 / 17.96 ยฑ0.83 / 18.85 ms โ 15.50 / 16.21 ยฑ1.05 / 18.31 ms โ +1.11x faster โ
โ QQuery 16 โ 41.65 / 42.60 ยฑ0.73 / 43.34 ms โ 40.66 / 42.26 ยฑ1.92 / 45.99 ms โ no change โ
โ QQuery 17 โ 242.63 / 243.93 ยฑ1.21 / 245.89 ms โ 237.67 / 240.61 ยฑ2.26 / 243.47 ms โ no change โ
โ QQuery 18 โ 128.73 / 129.82 ยฑ0.93 / 131.43 ms โ 127.77 / 129.58 ยฑ1.28 / 131.69 ms โ no change โ
โ QQuery 19 โ 156.27 / 158.92 ยฑ1.65 / 160.71 ms โ 154.82 / 156.07 ยฑ1.03 / 157.95 ms โ no change โ
โ QQuery 20 โ 13.99 / 14.67 ยฑ0.40 / 15.17 ms โ 13.24 / 14.11 ยฑ0.62 / 15.16 ms โ no change โ
โ QQuery 21 โ 19.33 / 19.80 ยฑ0.28 / 20.16 ms โ 19.66 / 20.04 ยฑ0.32 / 20.43 ms โ no change โ
โ QQuery 22 โ 482.90 / 487.66 ยฑ4.27 / 495.50 ms โ 480.04 / 482.87 ยฑ3.67 / 490.02 ms โ no change โ
โ QQuery 23 โ 872.62 / 882.34 ยฑ6.41 / 890.18 ms โ 874.41 / 891.21 ยฑ12.11 / 905.76 ms โ no change โ
โ QQuery 24 โ 410.70 / 414.81 ยฑ3.05 / 418.49 ms โ 415.46 / 420.02 ยฑ3.16 / 424.03 ms โ no change โ
โ QQuery 25 โ 349.14 / 352.83 ยฑ1.90 / 354.56 ms โ 351.98 / 354.23 ยฑ1.39 / 355.74 ms โ no change โ
โ QQuery 26 โ 82.81 / 83.91 ยฑ1.70 / 87.28 ms โ 82.73 / 83.60 ยฑ0.89 / 85.20 ms โ no change โ
โ QQuery 27 โ 349.06 / 349.82 ยฑ0.75 / 351.13 ms โ 347.13 / 351.40 ยฑ3.03 / 356.24 ms โ no change โ
โ QQuery 28 โ 150.21 / 151.36 ยฑ0.96 / 153.06 ms โ 149.57 / 151.65 ยฑ1.25 / 153.01 ms โ no change โ
โ QQuery 29 โ 298.65 / 300.77 ยฑ1.97 / 304.25 ms โ 297.25 / 300.48 ยฑ2.34 / 302.50 ms โ no change โ
โ QQuery 30 โ 43.95 / 45.25 ยฑ1.20 / 47.02 ms โ 45.77 / 46.72 ยฑ0.83 / 47.83 ms โ no change โ
โ QQuery 31 โ 170.11 / 171.65 ยฑ1.42 / 174.14 ms โ 169.97 / 171.47 ยฑ1.40 / 173.57 ms โ no change โ
โ QQuery 32 โ 57.37 / 58.95 ยฑ1.55 / 61.25 ms โ 57.31 / 58.52 ยฑ1.32 / 60.42 ms โ no change โ
โ QQuery 33 โ 141.53 / 143.07 ยฑ1.56 / 145.85 ms โ 139.19 / 142.22 ยฑ1.63 / 144.10 ms โ no change โ
โ QQuery 34 โ 106.84 / 107.88 ยฑ1.07 / 109.84 ms โ 106.87 / 108.21 ยฑ1.47 / 110.94 ms โ no change โ
โ QQuery 35 โ 107.11 / 108.88 ยฑ1.52 / 111.01 ms โ 107.28 / 108.46 ยฑ0.98 / 109.84 ms โ no change โ
โ QQuery 36 โ 213.25 / 218.86 ยฑ3.61 / 223.73 ms โ 211.58 / 219.50 ยฑ5.29 / 227.51 ms โ no change โ
โ QQuery 37 โ 178.30 / 183.10 ยฑ3.37 / 186.92 ms โ 178.44 / 179.81 ยฑ1.66 / 182.98 ms โ no change โ
โ QQuery 38 โ 82.47 / 86.28 ยฑ2.82 / 91.08 ms โ 87.69 / 89.89 ยฑ1.67 / 92.43 ms โ no change โ
โ QQuery 39 โ 127.11 / 128.17 ยฑ0.75 / 129.46 ms โ 123.22 / 128.71 ยฑ4.30 / 136.49 ms โ no change โ
โ QQuery 40 โ 112.18 / 116.93 ยฑ5.69 / 127.55 ms โ 110.73 / 116.46 ยฑ6.68 / 129.07 ms โ no change โ
โ QQuery 41 โ 14.36 / 15.84 ยฑ1.38 / 18.07 ms โ 14.64 / 15.53 ยฑ0.77 / 16.83 ms โ no change โ
โ QQuery 42 โ 107.12 / 108.19 ยฑ0.86 / 109.50 ms โ 106.12 / 108.91 ยฑ2.32 / 112.07 ms โ no change โ
โ QQuery 43 โ 83.60 / 84.88 ยฑ0.93 / 86.11 ms โ 83.38 / 84.97 ยฑ1.60 / 88.05 ms โ no change โ
โ QQuery 44 โ 11.23 / 12.07 ยฑ0.89 / 13.39 ms โ 11.38 / 12.30 ยฑ1.00 / 14.17 ms โ no change โ
โ QQuery 45 โ 52.69 / 53.61 ยฑ0.84 / 54.85 ms โ 52.84 / 54.11 ยฑ1.18 / 56.08 ms โ no change โ
โ QQuery 46 โ 227.50 / 230.98 ยฑ2.04 / 233.07 ms โ 230.00 / 231.59 ยฑ0.91 / 232.52 ms โ no change โ
โ QQuery 47 โ 699.44 / 706.87 ยฑ5.50 / 713.53 ms โ 689.48 / 699.74 ยฑ8.53 / 709.21 ms โ no change โ
โ QQuery 48 โ 290.34 / 295.62 ยฑ2.68 / 297.86 ms โ 287.36 / 292.08 ยฑ3.11 / 295.68 ms โ no change โ
โ QQuery 49 โ 253.50 / 254.87 ยฑ1.48 / 256.72 ms โ 254.67 / 257.07 ยฑ1.50 / 259.36 ms โ no change โ
โ QQuery 50 โ 228.98 / 233.16 ยฑ3.57 / 238.69 ms โ 231.32 / 236.95 ยฑ4.84 / 243.88 ms โ no change โ
โ QQuery 51 โ 179.31 / 183.87 ยฑ2.60 / 186.78 ms โ 184.32 / 187.08 ยฑ1.67 / 188.68 ms โ no change โ
โ QQuery 52 โ 107.71 / 109.17 ยฑ1.55 / 111.99 ms โ 107.11 / 108.38 ยฑ0.88 / 109.46 ms โ no change โ
โ QQuery 53 โ 103.52 / 104.83 ยฑ1.01 / 106.27 ms โ 101.83 / 103.32 ยฑ0.97 / 104.65 ms โ no change โ
โ QQuery 54 โ 148.72 / 149.40 ยฑ0.38 / 149.83 ms โ 146.46 / 148.17 ยฑ1.28 / 149.79 ms โ no change โ
โ QQuery 55 โ 107.57 / 108.73 ยฑ0.88 / 110.02 ms โ 107.63 / 108.62 ยฑ0.64 / 109.17 ms โ no change โ
โ QQuery 56 โ 142.56 / 143.60 ยฑ1.13 / 145.44 ms โ 140.75 / 142.29 ยฑ1.28 / 144.63 ms โ no change โ
โ QQuery 57 โ 175.11 / 178.66 ยฑ2.20 / 181.55 ms โ 174.64 / 175.57 ยฑ0.89 / 176.99 ms โ no change โ
โ QQuery 58 โ 295.12 / 299.81 ยฑ3.90 / 306.78 ms โ 301.52 / 311.65 ยฑ11.61 / 333.61 ms โ no change โ
โ QQuery 59 โ 199.05 / 200.71 ยฑ1.30 / 202.37 ms โ 196.95 / 199.01 ยฑ2.18 / 203.16 ms โ no change โ
โ QQuery 60 โ 144.21 / 145.57 ยฑ0.87 / 146.71 ms โ 142.92 / 144.44 ยฑ1.07 / 145.78 ms โ no change โ
โ QQuery 61 โ 170.68 / 172.11 ยฑ1.35 / 174.18 ms โ 171.85 / 173.53 ยฑ0.96 / 174.85 ms โ no change โ
โ QQuery 62 โ 873.88 / 890.36 ยฑ16.31 / 912.98 ms โ 913.18 / 943.44 ยฑ24.13 / 973.93 ms โ 1.06x slower โ
โ QQuery 63 โ 105.37 / 107.66 ยฑ2.42 / 112.32 ms โ 103.41 / 106.97 ยฑ1.84 / 108.47 ms โ no change โ
โ QQuery 64 โ 692.75 / 702.30 ยฑ4.95 / 706.00 ms โ 698.93 / 702.71 ยฑ4.32 / 710.87 ms โ no change โ
โ QQuery 65 โ 255.83 / 258.94 ยฑ3.37 / 264.98 ms โ 254.01 / 255.76 ยฑ1.36 / 257.49 ms โ no change โ
โ QQuery 66 โ 231.11 / 256.67 ยฑ18.05 / 276.60 ms โ 237.84 / 250.41 ยฑ8.68 / 260.71 ms โ no change โ
โ QQuery 67 โ 308.94 / 315.69 ยฑ4.18 / 320.60 ms โ 315.64 / 321.01 ยฑ4.46 / 329.14 ms โ no change โ
โ QQuery 68 โ 282.32 / 285.43 ยฑ1.84 / 287.87 ms โ 279.22 / 283.64 ยฑ2.62 / 286.94 ms โ no change โ
โ QQuery 69 โ 103.11 / 106.29 ยฑ1.71 / 108.27 ms โ 102.40 / 104.33 ยฑ1.86 / 107.52 ms โ no change โ
โ QQuery 70 โ 342.85 / 346.23 ยฑ3.67 / 351.90 ms โ 339.23 / 347.60 ยฑ9.36 / 364.96 ms โ no change โ
โ QQuery 71 โ 135.81 / 137.44 ยฑ1.93 / 141.03 ms โ 133.39 / 135.74 ยฑ2.42 / 139.92 ms โ no change โ
โ QQuery 72 โ 713.92 / 723.19 ยฑ8.99 / 738.71 ms โ 713.18 / 728.10 ยฑ13.04 / 751.36 ms โ no change โ
โ QQuery 73 โ 103.57 / 107.50 ยฑ3.75 / 113.23 ms โ 102.28 / 104.77 ยฑ2.71 / 109.62 ms โ no change โ
โ QQuery 74 โ 563.68 / 584.51 ยฑ17.71 / 610.61 ms โ 563.66 / 577.71 ยฑ17.03 / 609.57 ms โ no change โ
โ QQuery 75 โ 276.02 / 279.09 ยฑ1.62 / 280.63 ms โ 276.38 / 278.95 ยฑ1.70 / 281.69 ms โ no change โ
โ QQuery 76 โ 133.03 / 134.35 ยฑ0.92 / 135.64 ms โ 131.30 / 134.64 ยฑ2.33 / 138.01 ms โ no change โ
โ QQuery 77 โ 188.68 / 190.93 ยฑ1.85 / 193.70 ms โ 187.33 / 189.37 ยฑ1.61 / 191.83 ms โ no change โ
โ QQuery 78 โ 348.90 / 354.65 ยฑ4.17 / 359.14 ms โ 349.32 / 356.39 ยฑ3.84 / 360.94 ms โ no change โ
โ QQuery 79 โ 235.58 / 238.04 ยฑ1.89 / 240.72 ms โ 233.99 / 234.45 ยฑ0.48 / 235.18 ms โ no change โ
โ QQuery 80 โ 327.90 / 331.34 ยฑ2.46 / 334.97 ms โ 326.57 / 330.30 ยฑ3.72 / 337.33 ms โ no change โ
โ QQuery 81 โ 27.02 / 28.60 ยฑ2.30 / 33.16 ms โ 25.82 / 26.99 ยฑ0.98 / 28.59 ms โ +1.06x faster โ
โ QQuery 82 โ 202.25 / 206.59 ยฑ2.66 / 210.66 ms โ 199.77 / 202.01 ยฑ1.90 / 205.23 ms โ no change โ
โ QQuery 83 โ 39.47 / 40.53 ยฑ1.12 / 42.39 ms โ 38.73 / 39.59 ยฑ0.61 / 40.49 ms โ no change โ
โ QQuery 84 โ 47.88 / 49.90 ยฑ1.58 / 51.85 ms โ 48.36 / 48.93 ยฑ0.40 / 49.41 ms โ no change โ
โ QQuery 85 โ 151.03 / 151.95 ยฑ0.76 / 153.01 ms โ 148.69 / 150.34 ยฑ0.92 / 151.33 ms โ no change โ
โ QQuery 86 โ 38.41 / 39.08 ยฑ0.47 / 39.78 ms โ 38.45 / 39.72 ยฑ0.99 / 41.09 ms โ no change โ
โ QQuery 87 โ 86.15 / 89.13 ยฑ3.43 / 95.84 ms โ 84.79 / 89.42 ยฑ2.82 / 93.06 ms โ no change โ
โ QQuery 88 โ 98.96 / 99.89 ยฑ0.87 / 101.23 ms โ 98.94 / 99.72 ยฑ0.64 / 100.70 ms โ no change โ
โ QQuery 89 โ 118.57 / 120.32 ยฑ1.35 / 122.59 ms โ 116.93 / 119.36 ยฑ1.94 / 122.55 ms โ no change โ
โ QQuery 90 โ 23.85 / 24.52 ยฑ0.61 / 25.39 ms โ 23.24 / 24.21 ยฑ1.12 / 26.39 ms โ no change โ
โ QQuery 91 โ 66.13 / 66.59 ยฑ0.29 / 66.99 ms โ 61.63 / 64.29 ยฑ1.38 / 65.53 ms โ no change โ
โ QQuery 92 โ 57.55 / 58.50 ยฑ0.67 / 59.56 ms โ 56.66 / 57.74 ยฑ0.74 / 58.80 ms โ no change โ
โ QQuery 93 โ 188.67 / 191.69 ยฑ2.01 / 194.04 ms โ 190.56 / 192.38 ยฑ1.52 / 194.38 ms โ no change โ
โ QQuery 94 โ 61.35 / 62.74 ยฑ0.86 / 63.89 ms โ 60.20 / 61.34 ยฑ0.70 / 62.40 ms โ no change โ
โ QQuery 95 โ 133.22 / 134.80 ยฑ1.34 / 137.13 ms โ 133.58 / 135.32 ยฑ1.78 / 138.76 ms โ no change โ
โ QQuery 96 โ 72.55 / 74.60 ยฑ1.30 / 76.31 ms โ 72.92 / 74.00 ยฑ0.89 / 75.07 ms โ no change โ
โ QQuery 97 โ 128.98 / 132.73 ยฑ2.05 / 135.20 ms โ 126.49 / 129.90 ยฑ2.26 / 132.96 ms โ no change โ
โ QQuery 98 โ 152.89 / 154.32 ยฑ0.93 / 155.15 ms โ 154.47 / 155.91 ยฑ1.23 / 157.94 ms โ no change โ
โ QQuery 99 โ 10740.08 / 10787.05 ยฑ39.73 / 10858.52 ms โ 10722.14 / 10753.67 ยฑ25.06 / 10797.21 ms โ no change โ
โโโโโโโโโโโโโดโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโโโโโโ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโณโโโโโโโโโโโโโ
โ Benchmark Summary โ โ
โกโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโฉ
โ Total Time (HEAD) โ 33724.05ms โ
โ Total Time (schema_adapter) โ 33639.84ms โ
โ Average Time (HEAD) โ 340.65ms โ
โ Average Time (schema_adapter) โ 339.80ms โ
โ Queries Faster โ 3 โ
โ Queries Slower โ 1 โ
โ Queries with No Change โ 95 โ
โ Queries with Failure โ 0 โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโโโ
```
</p>
</details>
<details><summary>Resource Usage</summary>
**tpcds โ base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 169.0s |
| Peak memory | 5.6 GiB |
| Avg memory | 4.7 GiB |
| CPU user | 271.2s |
| CPU sys | 17.8s |
| Disk read | 0 B |
| Disk write | 702.8 MiB |
**tpcds โ branch**
| Metric | Value |
|--------|-------|
| Wall time | 168.5s |
| Peak memory | 5.5 GiB |
| Avg memory | 4.6 GiB |
| CPU user | 269.7s |
| CPU sys | 19.0s |
| Disk read | 0 B |
| Disk write | 148.0 KiB |
</details>
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Optimize schema rewriter usages [datafusion]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on PR #21158:
URL: https://github.com/apache/datafusion/pull/21158#issuecomment-4131402629
I was able to see 10% gain, not very impressive in terms of entire heavyweight test.
Tbh I was expecting more and it is difficult to get accurate numbers as there multiple processes involved, but the smoke test (with vs without) shows up to 10% overall gain. It would still prob nice to go to `53.1.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Optimize schema rewriter usages [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #21158:
URL: https://github.com/apache/datafusion/pull/21158#issuecomment-4137721266
๐ค Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/21158#issuecomment-4137709444)
`Linux bench-c4137709444-570-52q9g 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux`
Comparing schema_adapter (0346cbc4031e66816ca61a1181a3c00bb48a8615) to 51f13d7 (merge-base) [diff](https://github.com/apache/datafusion/compare/51f13d7435ccfd5ca38aa2d2d23ef0a04382ab74..0346cbc4031e66816ca61a1181a3c00bb48a8615) using: tpch
Results will be posted here when complete
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Optimize schema rewriter usages [datafusion]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on PR #21158:
URL: https://github.com/apache/datafusion/pull/21158#issuecomment-4137709444
run benchmarks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org