[GitHub] [ignite] zstan commented on a change in pull request #9527: IGNITE-15733 Eventually failure of baseline registration

[GitBox <gi...@apache.org>]

zstan commented on a change in pull request #9527:
URL: https://github.com/apache/ignite/pull/9527#discussion_r761908970



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cluster/ClusterProcessor.java
##########
@@ -328,11 +340,67 @@ public void updateTag(String newTag) throws IgniteCheckedException {
      *     when it becomes ready for read.</li>
      * </ul>
      */
+    public void onChangeState() {
+        Collection<ClusterNode> rmtNodes = cluster.forServers().nodes();
+        List<ClusterNode> rmtNodes0 = new ArrayList<>(rmtNodes);
+
+        rmtNodes0.sort(Comparator.comparing(ClusterNode::id));
+
+        @Nullable Collection<BaselineNode> bltNodes = cluster.currentBaselineTopology();
+
+        if (F.isEmpty(bltNodes)) {
+            log.info("Baseline node collection is empty.");
+
+            return;
+        }
+
+        @Nullable UUID first = null;
+
+        Collection<Object> srvIds = F.nodeConsistentIds(bltNodes);
+
+        for (ClusterNode node : rmtNodes0) {
+            if (F.contains(srvIds, node.consistentId())) {
+                first = node.id();

Review comment:
       hmm, we have two independent sets here, 1. nodes in topology 2. nodes in baseline i suppose the can be different at all, thus no min mechanics are suitable here, isn`t it ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org