[GitHub] [druid] gianm commented on a diff in pull request #13890: use Calcites.getColumnTypeForRelDataType for SQL CAST operator conversion

["gianm (via GitHub)" <gi...@apache.org>]

gianm commented on code in PR #13890:
URL: https://github.com/apache/druid/pull/13890#discussion_r1127865062


##########
sql/src/test/java/org/apache/druid/sql/calcite/expression/ExpressionsTest.java:
##########
@@ -1779,8 +1778,7 @@ public void testTimeMinusYearMonthInterval()
             DruidExpression.functionCall("timestamp_shift"),
             ImmutableList.of(
                 DruidExpression.ofColumn(ColumnType.LONG, "t"),
-                // RexNode type "interval year to month" is not reported as ColumnType.STRING
-                DruidExpression.ofLiteral(null, DruidExpression.stringLiteral("P13M")),
+                DruidExpression.ofLiteral(ColumnType.LONG, DruidExpression.stringLiteral("P13M")),

Review Comment:
   Long type for string literal? Seems not right.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org