You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/01/12 10:53:28 UTC
Re: Review Request 65096: Fixed master's `updateOperation` for
operations without framework ID.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65096/
-----------------------------------------------------------
(Updated Jan. 12, 2018, 11:53 a.m.)
Review request for mesos and Jan Schlicht.
Changes
-------
Addressed issue identified by Greg.
Summary (updated)
-----------------
Fixed master's `updateOperation` for operations without framework ID.
Bugs: MESOS-8422
https://issues.apache.org/jira/browse/MESOS-8422
Repository: mesos
Description (updated)
-------
This patch fixes logging of master's `updateOperation` for operations
without framework ID. We also add a `CHECK` before the part updating
resources or the allocator for non-speculated operations; currently
non-speculated operations can only be initiated from a framework, but
not from e.g., the operation API, and additional work is needed to
support this.
Diffs (updated)
-----
src/master/master.cpp 8921964a3ed74538b8c831a2f827d07875c1a5ab
Diff: https://reviews.apache.org/r/65096/diff/2/
Changes: https://reviews.apache.org/r/65096/diff/1-2/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 65096: Fixed master's `updateOperation` for
operations without framework ID.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65096/#review195304
-----------------------------------------------------------
Fix it, then Ship it!
src/master/master.cpp
Lines 10306 (patched)
<https://reviews.apache.org/r/65096/#comment274482>
Let's not use an empty string but " of a operator API call" here, as it's done in `Master::updateOperationStatus`.
- Jan Schlicht
On Jan. 12, 2018, 11:53 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65096/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2018, 11:53 a.m.)
>
>
> Review request for mesos and Jan Schlicht.
>
>
> Bugs: MESOS-8422
> https://issues.apache.org/jira/browse/MESOS-8422
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch fixes logging of master's `updateOperation` for operations
> without framework ID. We also add a `CHECK` before the part updating
> resources or the allocator for non-speculated operations; currently
> non-speculated operations can only be initiated from a framework, but
> not from e.g., the operation API, and additional work is needed to
> support this.
>
>
> Diffs
> -----
>
> src/master/master.cpp 8921964a3ed74538b8c831a2f827d07875c1a5ab
>
>
> Diff: https://reviews.apache.org/r/65096/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 65096: Fixed master's `updateOperation` for
operations without framework ID.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65096/#review195338
-----------------------------------------------------------
Fix it, then Ship it!
src/master/master.cpp
Lines 10339 (patched)
<https://reviews.apache.org/r/65096/#comment274508>
Nit: s/operation/operator/
I can fix this while committing.
- Greg Mann
On Jan. 12, 2018, 12:49 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65096/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2018, 12:49 p.m.)
>
>
> Review request for mesos and Jan Schlicht.
>
>
> Bugs: MESOS-8422
> https://issues.apache.org/jira/browse/MESOS-8422
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch fixes logging of master's `updateOperation` for operations
> without framework ID. We also add a `CHECK` before the part updating
> resources or the allocator for non-speculated operations; currently
> non-speculated operations can only be initiated from a framework, but
> not from e.g., the operation API, and additional work is needed to
> support this.
>
>
> Diffs
> -----
>
> src/master/master.cpp 8921964a3ed74538b8c831a2f827d07875c1a5ab
>
>
> Diff: https://reviews.apache.org/r/65096/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 65096: Fixed master's `updateOperation` for
operations without framework ID.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65096/
-----------------------------------------------------------
(Updated Jan. 12, 2018, 1:49 p.m.)
Review request for mesos and Jan Schlicht.
Changes
-------
Addressed comment from Jan.
Bugs: MESOS-8422
https://issues.apache.org/jira/browse/MESOS-8422
Repository: mesos
Description
-------
This patch fixes logging of master's `updateOperation` for operations
without framework ID. We also add a `CHECK` before the part updating
resources or the allocator for non-speculated operations; currently
non-speculated operations can only be initiated from a framework, but
not from e.g., the operation API, and additional work is needed to
support this.
Diffs (updated)
-----
src/master/master.cpp 8921964a3ed74538b8c831a2f827d07875c1a5ab
Diff: https://reviews.apache.org/r/65096/diff/3/
Changes: https://reviews.apache.org/r/65096/diff/2-3/
Testing
-------
`make check`
Thanks,
Benjamin Bannier