[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1918: feat: added route path search

[GitBox <gi...@apache.org>]

liuxiran commented on a change in pull request #1918:
URL: https://github.com/apache/apisix-dashboard/pull/1918#discussion_r642172470



##########
File path: web/cypress/integration/route/search-route.spec.js
##########
@@ -126,9 +135,35 @@ context('Create and Search Route', () => {
     cy.contains(data.test2).should('not.exist');
   });
 
+  it('should search the route with path', function () {
+    cy.visit('/');
+    cy.contains('Route').click();
+    // full match
+    cy.get(selector.pathSearch).type(data.uris1);
+    cy.contains('Search').click();
+    cy.contains(data.uris1).should('contain', data.uris1);
+    cy.contains(data.uris0).should('not.exist');
+    cy.contains(data.uris2).should('not.exist');
+    // partial match
+    cy.reload();

Review comment:
       Hi @iamayushdas , may I ask why we need `cy.reload` here? It seems that we don't need to reload the page, If we only want to change the path for search param, shall we use e.g. `selector.clear().type('new path')`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org