[jira] [Commented] (QPID-7876) qpid-route does not properly consider src-local when matching bridges

["Chris Richardson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/QPID-7876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109647#comment-16109647 ] 

Chris Richardson commented on QPID-7876:
----------------------------------------

Having modified qpid-route to include src-local in bridge matching, I found that the broker itself (silently) does not accept the new bridge for the same reason. On examining src/qpid/broker/Link.cpp I found the following comment (line 721): 

        /* TBD: deprecate this interface in favor(sic) of the Broker::create() method.  The
         * Broker::create() method allows the user to assign a name to the bridge.
         */

I am therefore creating a PR in which qpid-route uses the Broker::create() method. This seemed like a better option than modifying the broker code, which is to be deprecated anyway.

> qpid-route does not properly consider src-local when matching bridges
> ---------------------------------------------------------------------
>
>                 Key: QPID-7876
>                 URL: https://issues.apache.org/jira/browse/QPID-7876
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: qpid-cpp-1.36.0
>            Reporter: Chris Richardson
>   Original Estimate: 4m
>  Remaining Estimate: 4m
>
> qpid-route does not properly consider src-local when matching bridges. The practical upshot of this is that it may consider routes to be duplicates when they are in fact not.
> Take the following (slightly contrived) scenario:
> Brokers A and B both have queues named "test.queue" and default exchanges named "amq.direct".
> We would like a queue route to pull messages from B:test.queue to A:amq.direct and a src_local route to push messages from A:test.queue to B:amq.direct. Since qpid-route does not consider the src-local flag, it will regard the second route to be a duplicate and will not allow it to be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org