You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/03/20 14:49:48 UTC

[kudu-CR] [rpc-test] macOS-specific fix for TestRpcSidecarLimits

Hello Will Berkeley, Kudu Jenkins, Grant Henke, Joe McDonnell, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9719

to look at the new patch set (#3).

Change subject: [rpc-test] macOS-specific fix for TestRpcSidecarLimits
......................................................................

[rpc-test] macOS-specific fix for TestRpcSidecarLimits

As Will noticed, after TestRpcSidecarLimits was updated with 2b0c1c0,
on macOS the following new error surfaced while running the test
(which is completely legit in accordance with 'man sendmsg'):

  Network error: sendmsg error: Invalid argument (error 22)

This patch updates the pattern of the expected error message for the
case if sendmsg() returns EINVAL when the sum of the iov_len values
overflows an ssize_t.

This is a follow-up for 2b0c1c019921e485f06c4be280fedba3d5279672.

Change-Id: I17681546fd942724025dfde81eaa412ee7e0acbf
---
M src/kudu/rpc/rpc-test.cc
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/9719/3
-- 
To view, visit http://gerrit.cloudera.org:8080/9719
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I17681546fd942724025dfde81eaa412ee7e0acbf
Gerrit-Change-Number: 9719
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>