You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Jeremy Daggett <no...@github.com> on 2014/06/21 01:34:06 UTC
[jclouds] Unasync OpenStack Nova and Extension APIs (#417)
This PR un-asyncs the OpenStack Nova API, related extension APIs and updates dependent code.
Nova is now deasynced *before* Keystone, which was the approach taken in PR #380
https://issues.apache.org/jira/browse/JCLOUDS-40
You can merge this Pull Request by running:
git pull https://github.com/rackspace/jclouds unasync-nova
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/417
-- Commit Summary --
* JCLOUDS-40: unasync OpenStack Nova API core features
* JCLOUDS-40: unasync OpenStack Nova API extension features
* Update Nova providers and affected live test
-- File Changes --
M apis/openstack-keystone/src/main/java/org/jclouds/openstack/v2_0/features/ExtensionApi.java (40)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/NovaApi.java (7)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/NovaApiMetadata.java (34)
D apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/NovaAsyncApi.java (205)
R apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/config/NovaHttpApiModule.java (79)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/AvailabilityZoneApi.java (32)
D apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/AvailabilityZoneAsyncApi.java (52)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/FlavorExtraSpecsApi.java (92)
D apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/FlavorExtraSpecsAsyncApi.java (117)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/FloatingIPApi.java (97)
D apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/FloatingIPAsyncApi.java (144)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/HostAdministrationApi.java (96)
D apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/HostAdministrationAsyncApi.java (156)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/HostAggregateApi.java (101)
D apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/HostAggregateAsyncApi.java (160)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/KeyPairApi.java (68)
D apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/KeyPairAsyncApi.java (105)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/QuotaApi.java (50)
D apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/QuotaAsyncApi.java (88)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/SecurityGroupApi.java (89)
D apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/SecurityGroupAsyncApi.java (151)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/ServerAdminApi.java (108)
D apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/ServerAdminAsyncApi.java (174)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/ServerWithSecurityGroupsApi.java (38)
D apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/ServerWithSecurityGroupsAsyncApi.java (61)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/SimpleTenantUsageApi.java (37)
D apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/SimpleTenantUsageAsyncApi.java (76)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/VirtualInterfaceApi.java (31)
D apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/VirtualInterfaceAsyncApi.java (58)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/VolumeApi.java (139)
D apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/VolumeAsyncApi.java (253)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/VolumeAttachmentApi.java (56)
D apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/VolumeAttachmentAsyncApi.java (106)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/VolumeTypeApi.java (105)
D apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/VolumeTypeAsyncApi.java (160)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/features/FlavorApi.java (98)
D apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/features/FlavorAsyncApi.java (142)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/features/ImageApi.java (128)
D apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/features/ImageAsyncApi.java (205)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/features/ServerApi.java (227)
D apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/features/ServerAsyncApi.java (355)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/compute/functions/AllocateAndAddFloatingIpToNodeExpectTest.java (2)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/AdminActionsApiExpectTest.java (1)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/FloatingIPApiExpectTest.java (2)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/KeyPairApiExpectTest.java (4)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/QuotaApiExpectTest.java (2)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/SecurityGroupApiExpectTest.java (4)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/features/ExtensionApiExpectTest.java (29)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/features/FlavorApiExpectTest.java (48)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/features/ImageApiExpectTest.java (113)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/features/ServerApiExpectTest.java (238)
M apis/rackspace-clouddns/src/test/java/org/jclouds/rackspace/clouddns/v1/features/ReverseDNSApiLiveTest.java (8)
M providers/hpcloud-compute/src/main/java/org/jclouds/hpcloud/compute/HPCloudComputeProviderMetadata.java (8)
M providers/rackspace-cloudservers-uk/src/main/java/org/jclouds/rackspace/cloudservers/uk/CloudServersUKProviderMetadata.java (8)
M providers/rackspace-cloudservers-us/src/main/java/org/jclouds/rackspace/cloudservers/us/CloudServersUSProviderMetadata.java (8)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/417.patch
https://github.com/jclouds/jclouds/pull/417.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/417
Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #920](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/920/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/417#issuecomment-46739121
Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #977](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/977/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/417#issuecomment-48560518
Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1391](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1391/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/417#issuecomment-46739116
Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1347](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1347/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/417#issuecomment-48565426
Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1344](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1344/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/417#issuecomment-48502911
Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1265](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1265/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/417#issuecomment-46739027
Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #936](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/936/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/417#issuecomment-47289488
Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1458](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1458/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/417#issuecomment-48924571
Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1407](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1407/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/417#issuecomment-47285804
Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)
Posted by Zack Shoylev <no...@github.com>.
Seems like it needs a rebase?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/417#issuecomment-48506498
Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1288](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1288/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/417#issuecomment-47290095
Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)
Posted by Zack Shoylev <no...@github.com>.
>
> /**
> * Pause a server.
> *
> * @param id id of the server
> */
> - Boolean pause(String id);
> + @Named("serverAdmin:pause")
> + @POST
> + @Produces(MediaType.APPLICATION_JSON)
> + @Payload("{\"pause\":null}")
> + @Fallback(FalseOnNotFoundOr404.class)
> + Boolean pause(@PathParam("id") String id);
Do you want to make this a primitive as well?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/417/files#r14154607
Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)
Posted by Everett Toews <no...@github.com>.
>
> /**
> * Pause a server.
> *
> * @param id id of the server
> */
> - Boolean pause(String id);
> + @Named("serverAdmin:pause")
> + @POST
> + @Produces(MediaType.APPLICATION_JSON)
> + @Payload("{\"pause\":null}")
> + @Fallback(FalseOnNotFoundOr404.class)
> + Boolean pause(@PathParam("id") String id);
Please save anything involving adding/removing/changing methods for another PR.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/417/files#r14262279
Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1361](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1361/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/417#issuecomment-48922804
Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #974](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/974/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/417#issuecomment-48503105
Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)
Posted by Zack Shoylev <no...@github.com>.
+1
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/417#issuecomment-48939334
Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)
Posted by Jeremy Daggett <no...@github.com>.
Pushed to master 801aeca
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/417#issuecomment-49096651
Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1448](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1448/) ABORTED
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/417#issuecomment-48687027
Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1469](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1469/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/417#issuecomment-49102385
Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #998](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/998/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/417#issuecomment-49101874
Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1375](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1375/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/417#issuecomment-49113319
Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1445](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1445/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/417#issuecomment-48503050
Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)
Posted by Zack Shoylev <no...@github.com>.
> */
> - Boolean deleteMetadataKey(String flavorId, String key);
Just making sure there aren't any issues with the signature change. Right?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/417/files#r14150498
Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #987](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/987/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/417#issuecomment-48923967
Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)
Posted by Jeremy Daggett <no...@github.com>.
> */
> - Boolean deleteMetadataKey(String flavorId, String key);
We could deprecate this method for the one with the *correct* signature. This is one of those APIs with mixed return types. Gah!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/417/files#r14258615
Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)
Posted by Jeremy Daggett <no...@github.com>.
Closed #417.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/417#event-141917778
Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)
Posted by Jeremy Daggett <no...@github.com>.
>
> /**
> * Pause a server.
> *
> * @param id id of the server
> */
> - Boolean pause(String id);
> + @Named("serverAdmin:pause")
> + @POST
> + @Produces(MediaType.APPLICATION_JSON)
> + @Payload("{\"pause\":null}")
> + @Fallback(FalseOnNotFoundOr404.class)
> + Boolean pause(@PathParam("id") String id);
@zack-shoylev My preference would be to have all of the API methods return primitive types across the board. That's me though... ;) Deprecate/add this method as well? WDYT?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/417/files#r14258803
Re: [jclouds] Unasync OpenStack Nova and Extension APIs (#417)
Posted by Ignasi Barrera <no...@github.com>.
Changes lgtm too. Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/417#issuecomment-49007053