You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2017/12/20 03:15:32 UTC
[kudu-CR] KUDU-2236 fix flake in TestKuduClient
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8892
Change subject: KUDU-2236 fix flake in TestKuduClient
......................................................................
KUDU-2236 fix flake in TestKuduClient
TestKuduClient.testCloseShortlyAfterOpen would expect 0 log spew, and
ensure that no unexpected exceptions were caught. It noted that
"connection disconnected" errors were possible, but added a wait to make
them less likely. This turned out to be extremely flaky.
This patch replaces the wait with logic to catch the appropriate error
message.
Without this patch, the test only passed 57/100 runs. With the patch, it
passes 100/100.
Change-Id: Ice5b404107dd425eab5ea3f382090b2304ef8a5e
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/8892/1
--
To view, visit http://gerrit.cloudera.org:8080/8892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice5b404107dd425eab5ea3f382090b2304ef8a5e
Gerrit-Change-Number: 8892
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] KUDU-2236: fix flake in TestKuduClient
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8892 )
Change subject: KUDU-2236: fix flake in TestKuduClient
......................................................................
KUDU-2236: fix flake in TestKuduClient
TestKuduClient.testCloseShortlyAfterOpen would expect 0 log spew, and
ensure that no unexpected exceptions were caught. It noted that
"connection disconnected" errors were possible, but added a wait to make
them less likely. This turned out to be extremely flaky.
This patch replaces the wait with logic to catch the appropriate error
message.
Without this patch, the test only passed 57/100 runs. With the patch, it
passes 100/100.
Change-Id: Ice5b404107dd425eab5ea3f382090b2304ef8a5e
Reviewed-on: http://gerrit.cloudera.org:8080/8892
Reviewed-by: Hao Hao <ha...@cloudera.com>
Tested-by: Kudu Jenkins
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
1 file changed, 6 insertions(+), 4 deletions(-)
Approvals:
Hao Hao: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice5b404107dd425eab5ea3f382090b2304ef8a5e
Gerrit-Change-Number: 8892
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2236: fix flake in TestKuduClient
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8892 )
Change subject: KUDU-2236: fix flake in TestKuduClient
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8892/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java:
http://gerrit.cloudera.org:8080/#/c/8892/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@843
PS2, Line 843: disconnected
> Check "connection disconnected" instead to be more clear?
Done
--
To view, visit http://gerrit.cloudera.org:8080/8892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice5b404107dd425eab5ea3f382090b2304ef8a5e
Gerrit-Change-Number: 8892
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 20 Dec 2017 20:36:29 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2236 fix flake in TestKuduClient
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8892
to look at the new patch set (#2).
Change subject: KUDU-2236 fix flake in TestKuduClient
......................................................................
KUDU-2236 fix flake in TestKuduClient
TestKuduClient.testCloseShortlyAfterOpen would expect 0 log spew, and
ensure that no unexpected exceptions were caught. It noted that
"connection disconnected" errors were possible, but added a wait to make
them less likely. This turned out to be extremely flaky.
This patch replaces the wait with logic to catch the appropriate error
message.
Without this patch, the test only passed 57/100 runs. With the patch, it
passes 100/100.
Change-Id: Ice5b404107dd425eab5ea3f382090b2304ef8a5e
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/8892/2
--
To view, visit http://gerrit.cloudera.org:8080/8892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ice5b404107dd425eab5ea3f382090b2304ef8a5e
Gerrit-Change-Number: 8892
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2236: fix flake in TestKuduClient
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8892 )
Change subject: KUDU-2236: fix flake in TestKuduClient
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8892/4/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java:
http://gerrit.cloudera.org:8080/#/c/8892/4/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@842
PS4, Line 842: assertTrue("Unexpected exception:\n" + exception_text,
: !exception_text.contains("Exception") ||
: exception_text.contains("connection disconnected"));
I'm a late here, but just to clarify.
Might it happen that some other exception along with 'connection disconnected' happens there? If so, would this check hide that?
--
To view, visit http://gerrit.cloudera.org:8080/8892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice5b404107dd425eab5ea3f382090b2304ef8a5e
Gerrit-Change-Number: 8892
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 21 Dec 2017 21:33:00 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2236 fix flake in TestKuduClient
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8892 )
Change subject: KUDU-2236 fix flake in TestKuduClient
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Just a minor nit.
http://gerrit.cloudera.org:8080/#/c/8892/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java:
http://gerrit.cloudera.org:8080/#/c/8892/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@843
PS2, Line 843: disconnected
Check "connection disconnected" instead to be more clear?
--
To view, visit http://gerrit.cloudera.org:8080/8892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice5b404107dd425eab5ea3f382090b2304ef8a5e
Gerrit-Change-Number: 8892
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 20 Dec 2017 19:49:43 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2236: fix flake in TestKuduClient
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8892 )
Change subject: KUDU-2236: fix flake in TestKuduClient
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice5b404107dd425eab5ea3f382090b2304ef8a5e
Gerrit-Change-Number: 8892
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 20 Dec 2017 20:41:44 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2236: fix flake in TestKuduClient
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8892
to look at the new patch set (#3).
Change subject: KUDU-2236: fix flake in TestKuduClient
......................................................................
KUDU-2236: fix flake in TestKuduClient
TestKuduClient.testCloseShortlyAfterOpen would expect 0 log spew, and
ensure that no unexpected exceptions were caught. It noted that
"connection disconnected" errors were possible, but added a wait to make
them less likely. This turned out to be extremely flaky.
This patch replaces the wait with logic to catch the appropriate error
message.
Without this patch, the test only passed 57/100 runs. With the patch, it
passes 100/100.
Change-Id: Ice5b404107dd425eab5ea3f382090b2304ef8a5e
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
1 file changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/8892/3
--
To view, visit http://gerrit.cloudera.org:8080/8892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ice5b404107dd425eab5ea3f382090b2304ef8a5e
Gerrit-Change-Number: 8892
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins