You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "sandynz (via GitHub)" <gi...@apache.org> on 2023/02/16 08:26:37 UTC

[GitHub] [shardingsphere] sandynz commented on a diff in pull request #24194: Rename subscription to streaming at pipeline CDC and simplification CDC protocol

sandynz commented on code in PR #24194:
URL: https://github.com/apache/shardingsphere/pull/24194#discussion_r1108140517


##########
kernel/data-pipeline/cdc/client/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/client/handler/CDCRequestHandler.java:
##########
@@ -71,33 +73,24 @@ public void channelRead(final ChannelHandlerContext ctx, final Object msg) {
             log.error("received error response {}", msg);
         }
         ClientConnectionContext connectionContext = ctx.channel().attr(ClientConnectionContext.CONTEXT_KEY).get();
-        if (connectionContext.getStatus() == ClientConnectionStatus.LOGGING_IN) {
-            if (!response.hasCreateSubscriptionResult()) {
-                log.error("not find the create subscription result");
-                return;
-            }
-            sendCreateSubscriptionRequest(ctx, response, connectionContext);
-        } else if (connectionContext.getStatus() == ClientConnectionStatus.CREATING_SUBSCRIPTION) {
-            startSubscription(response, connectionContext);
-        } else {
-            subscribeDataRecords(ctx, response.getDataRecordResult());
+        if (response.hasStreamDataResult()) {
+            StreamDataResult streamDataResult = response.getStreamDataResult();
+            connectionContext.setStreamingId(streamDataResult.getStreamingId());
+            connectionContext.setStatus(ClientConnectionStatus.STREAMING);
+        } else if (response.hasDataRecordResult()) {
+            processDataRecords(ctx, response.getDataRecordResult());
         }
     }
     
-    private void sendCreateSubscriptionRequest(final ChannelHandlerContext ctx, final CDCResponse response, final ClientConnectionContext connectionContext) {
-        log.info("create subscription succeed, subscription name {}, exist {}", response.getCreateSubscriptionResult().getSubscriptionName(), response.getCreateSubscriptionResult().getExisting());
-        StartSubscriptionRequest startSubscriptionRequest = StartSubscriptionRequest.newBuilder().setDatabase(parameter.getDatabase()).setSubscriptionName(parameter.getSubscriptionName()).build();
-        Builder builder = CDCRequest.newBuilder().setRequestId(RequestIdUtil.generateRequestId()).setStartSubscription(startSubscriptionRequest);
+    // TODO not remove the method, may be used again in the future
+    private void sendStartStreamingDataRequest(final ChannelHandlerContext ctx, final String streamId, final ClientConnectionContext connectionContext) {
+        StartStreamingRequestBody startStreamingRequest = StartStreamingRequestBody.newBuilder().setStreamingId(streamId).build();

Review Comment:
   `streamId` could be `streamingId`, to keep consistent



##########
kernel/data-pipeline/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/api/pojo/CreateStreamDataParameter.java:
##########
@@ -25,19 +25,17 @@
 import java.util.Map;
 
 /**
- * Create subscription job parameter.
+ * Create stream data parameter.
  */
 @RequiredArgsConstructor
 @Getter
-public final class CreateSubscriptionJobParameter {
+public final class CreateStreamDataParameter {

Review Comment:
   Could we rename `CreateStreamDataParameter` to `StreamDataParameter`?



##########
proxy/frontend/core/src/main/java/org/apache/shardingsphere/proxy/frontend/netty/CDCChannelInboundHandler.java:
##########
@@ -164,69 +163,79 @@ private String getHostAddress(final ChannelHandlerContext context) {
         return socketAddress instanceof InetSocketAddress ? ((InetSocketAddress) socketAddress).getAddress().getHostAddress() : socketAddress.toString();
     }
     
-    private void processCreateSubscription(final ChannelHandlerContext ctx, final CDCRequest request, final CDCConnectionContext connectionContext) {
-        if (!request.hasCreateSubscription()) {
-            ctx.writeAndFlush(CDCResponseGenerator.failed(request.getRequestId(), CDCResponseErrorCode.ILLEGAL_REQUEST_ERROR, "Miss create subscription request body"))
-                    .addListener(ChannelFutureListener.CLOSE);
+    private void processStreamDataRequest(final ChannelHandlerContext ctx, final CDCRequest request, final CDCConnectionContext connectionContext) {
+        if (!request.hasStreamDataRequestBody()) {
+            ctx.writeAndFlush(CDCResponseGenerator.failed(request.getRequestId(), CDCResponseErrorCode.ILLEGAL_REQUEST_ERROR, "Miss stream data request body"));
+            return;
+        }
+        StreamDataRequestBody streamDataRequestBody = request.getStreamDataRequestBody();
+        if (streamDataRequestBody.getDatabase().isEmpty()) {
+            ctx.writeAndFlush(CDCResponseGenerator.failed(request.getRequestId(), CDCResponseErrorCode.ILLEGAL_REQUEST_ERROR, "database not allowed to be empty"));
             return;
         }
-        CreateSubscriptionRequest createSubscriptionRequest = request.getCreateSubscription();
-        if (createSubscriptionRequest.getTableNamesList().isEmpty() || createSubscriptionRequest.getDatabase().isEmpty() || createSubscriptionRequest.getSubscriptionName().isEmpty()
-                || createSubscriptionRequest.getSubscriptionMode() == SubscriptionMode.UNKNOWN) {
-            ctx.writeAndFlush(CDCResponseGenerator.failed(request.getRequestId(), CDCResponseErrorCode.ILLEGAL_REQUEST_ERROR, "Illegal create subscription request parameter"));
+        // TODO need support the all tables at database or schema
+        if (streamDataRequestBody.getSourceSchemaTablesList().isEmpty()) {
+            ctx.writeAndFlush(CDCResponseGenerator.failed(request.getRequestId(), CDCResponseErrorCode.ILLEGAL_REQUEST_ERROR, "Illegal stream data request parameter"));
             return;
         }
-        checkPrivileges(connectionContext.getCurrentUser().getGrantee(), createSubscriptionRequest.getDatabase());
-        CDCResponse response = backendHandler.createSubscription(request);
+        checkPrivileges(connectionContext.getCurrentUser().getGrantee(), streamDataRequestBody.getDatabase());
+        CDCResponse response = backendHandler.streamData(request.getRequestId(), streamDataRequestBody, connectionContext, ctx.channel());
         ctx.writeAndFlush(response);
     }
     
-    private void processStartSubscription(final ChannelHandlerContext ctx, final CDCRequest request, final CDCConnectionContext connectionContext) {
-        if (!request.hasStartSubscription()) {
-            ctx.writeAndFlush(CDCResponseGenerator.failed(request.getRequestId(), CDCResponseErrorCode.ILLEGAL_REQUEST_ERROR, "Miss start subscription request body"))
+    private void processStartStreamingRequest(final ChannelHandlerContext ctx, final CDCRequest request, final CDCConnectionContext connectionContext) {
+        if (!request.hasStartStreamingRequestBody()) {
+            ctx.writeAndFlush(CDCResponseGenerator.failed(request.getRequestId(), CDCResponseErrorCode.ILLEGAL_REQUEST_ERROR, "Miss start streaming request body"))
                     .addListener(ChannelFutureListener.CLOSE);
             return;
         }
-        StartSubscriptionRequest startSubscriptionRequest = request.getStartSubscription();
-        if (startSubscriptionRequest.getDatabase().isEmpty() || startSubscriptionRequest.getSubscriptionName().isEmpty()) {
-            ctx.writeAndFlush(CDCResponseGenerator.failed(request.getRequestId(), CDCResponseErrorCode.ILLEGAL_REQUEST_ERROR, "Illegal start subscription request parameter"))
+        StartStreamingRequestBody startStreamingRequestBody = request.getStartStreamingRequestBody();
+        // TODO improve after cdc exception refactor
+        if (startStreamingRequestBody.getStreamingId().isEmpty()) {
+            ctx.writeAndFlush(CDCResponseGenerator.failed(request.getRequestId(), CDCResponseErrorCode.ILLEGAL_REQUEST_ERROR, "Illegal start streaming request parameter"))
                     .addListener(ChannelFutureListener.CLOSE);
             return;
         }
-        checkPrivileges(connectionContext.getCurrentUser().getGrantee(), startSubscriptionRequest.getDatabase());
-        CDCResponse response = backendHandler.startSubscription(request, ctx.channel(), connectionContext);
+        String database = backendHandler.getDatabaseByJobId(startStreamingRequestBody.getStreamingId());
+        checkPrivileges(connectionContext.getCurrentUser().getGrantee(), database);
+        CDCResponse response = backendHandler.startStreaming(request.getRequestId(), startStreamingRequestBody.getStreamingId(), connectionContext, ctx.channel());
         ctx.writeAndFlush(response);
     }
     
-    private void processStopSubscription(final ChannelHandlerContext ctx, final CDCRequest request, final CDCConnectionContext connectionContext) {
-        StopSubscriptionRequest stopSubscriptionRequest = request.getStopSubscription();
-        checkPrivileges(connectionContext.getCurrentUser().getGrantee(), stopSubscriptionRequest.getDatabase());
-        backendHandler.stopSubscription(connectionContext.getJobId());
+    private void processStopStreamingRequest(final ChannelHandlerContext ctx, final CDCRequest request, final CDCConnectionContext connectionContext) {
+        StopStreamingRequestBody stopStreamingRequestBody = request.getStopStreamingRequestBody();
+        String database = backendHandler.getDatabaseByJobId(stopStreamingRequestBody.getStreamingId());
+        checkPrivileges(connectionContext.getCurrentUser().getGrantee(), database);
+        backendHandler.stopStreaming(connectionContext.getJobId());
         connectionContext.setStatus(CDCConnectionStatus.LOGGED_IN);
+        connectionContext.setJobId(null);
         ctx.writeAndFlush(CDCResponseGenerator.succeedBuilder(request.getRequestId()).build());
     }
     
-    private void processDropSubscription(final ChannelHandlerContext ctx, final CDCRequest request, final CDCConnectionContext connectionContext) {
-        DropSubscriptionRequest dropSubscriptionRequest = request.getDropSubscription();
-        checkPrivileges(connectionContext.getCurrentUser().getGrantee(), dropSubscriptionRequest.getDatabase());
+    private void processDropStreamingRequest(final ChannelHandlerContext ctx, final CDCRequest request, final CDCConnectionContext connectionContext) {
+        DropStreamingRequestBody dropStreamingRequestBody = request.getDropStreamingRequestBody();
+        String database = backendHandler.getDatabaseByJobId(dropStreamingRequestBody.getStreamingId());
+        checkPrivileges(connectionContext.getCurrentUser().getGrantee(), database);
         try {
-            backendHandler.dropSubscription(connectionContext.getJobId());
+            backendHandler.dropStreaming(connectionContext.getJobId());
+            connectionContext.setStatus(CDCConnectionStatus.LOGGED_IN);
+            connectionContext.setJobId(null);
             ctx.writeAndFlush(CDCResponseGenerator.succeedBuilder(request.getRequestId()).build());
         } catch (final SQLException ex) {
             ctx.writeAndFlush(CDCResponseGenerator.failed(request.getRequestId(), CDCResponseErrorCode.SERVER_ERROR, ex.getMessage()));
         }
     }
     
-    private void processAckRequest(final ChannelHandlerContext ctx, final CDCRequest request) {
-        if (!request.hasAckRequest()) {
+    private void processAckStreamingRequest(final ChannelHandlerContext ctx, final CDCRequest request) {
+        if (!request.hasAckStreamingRequestBody()) {
             ctx.writeAndFlush(CDCResponseGenerator.failed(request.getRequestId(), CDCResponseErrorCode.ILLEGAL_REQUEST_ERROR, "Miss ack request body")).addListener(ChannelFutureListener.CLOSE);
             return;
         }
-        AckRequest ackRequest = request.getAckRequest();
-        if (ackRequest.getAckId().isEmpty()) {
+        AckStreamingRequestBody ackStreamingRequestBody = request.getAckStreamingRequestBody();

Review Comment:
   Could we simplify `ackStreamingRequestBody` to `requestBody` in method context?
   And also in other places



##########
kernel/data-pipeline/cdc/protocol/src/main/proto/CDCRequestProtocol.proto:
##########
@@ -27,24 +27,24 @@ message CDCRequest {
   enum Type {
     UNKNOWN = 0;
     LOGIN = 1;
-    CREATE_SUBSCRIPTION = 2;
-    START_SUBSCRIPTION = 3;
-    ACK = 4;
-    STOP_SUBSCRIPTION = 5;
-    DROP_SUBSCRIPTION = 6;
+    STREAM_DATA = 2;
+    START_STREAMING = 3;
+    ACK_STREAMING = 4;
+    STOP_STREAMING = 5;
+    DROP_STREAMING = 6;
   }
   Type type = 3;
-  oneof request {
-    LoginRequest login = 4;
-    CreateSubscriptionRequest create_subscription = 5;
-    StartSubscriptionRequest start_subscription = 6;
-    AckRequest ack_request = 7;
-    StopSubscriptionRequest stop_subscription = 8;
-    DropSubscriptionRequest drop_subscription = 9;
+  oneof request_body {
+    LoginRequestBody login_request_body = 4;
+    StreamDataRequestBody stream_data_request_body = 5;
+    StartStreamingRequestBody start_streaming_request_body =6;

Review Comment:
   1, Move `StartStreamingRequestBody` after `StopStreamingRequestBody`, since it just be used after stopping.
   
   2, ` =6;` could be ` = 6;`
   



##########
kernel/data-pipeline/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/core/job/CDCJobId.java:
##########
@@ -33,11 +35,14 @@ public final class CDCJobId extends AbstractPipelineJobId {
     
     private final String databaseName;
     
-    private final String subscriptionName;
+    private final List<String> tableNames;

Review Comment:
   It's better to rename `tableNames` as `schemaTableNames`



##########
proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/cdc/CDCBackendHandler.java:
##########
@@ -109,20 +106,30 @@ private List<DataNode> getActualDataNodes(final ShardingRule shardingRule, final
     }
     
     /**
-     * Start subscription.
+     * Get database by job id.
      *
-     * @param request request
+     * @param jobId job id
+     * @return database
+     */
+    public String getDatabaseByJobId(final String jobId) {
+        CDCJobConfiguration jobConfig = (CDCJobConfiguration) jobAPI.getJobConfiguration(jobId);
+        return jobConfig.getDatabase();

Review Comment:
   It could be simplified to one line



##########
kernel/data-pipeline/cdc/protocol/src/main/proto/CDCRequestProtocol.proto:
##########
@@ -27,24 +27,24 @@ message CDCRequest {
   enum Type {
     UNKNOWN = 0;
     LOGIN = 1;
-    CREATE_SUBSCRIPTION = 2;
-    START_SUBSCRIPTION = 3;
-    ACK = 4;
-    STOP_SUBSCRIPTION = 5;
-    DROP_SUBSCRIPTION = 6;
+    STREAM_DATA = 2;
+    START_STREAMING = 3;
+    ACK_STREAMING = 4;
+    STOP_STREAMING = 5;
+    DROP_STREAMING = 6;
   }
   Type type = 3;
-  oneof request {
-    LoginRequest login = 4;
-    CreateSubscriptionRequest create_subscription = 5;
-    StartSubscriptionRequest start_subscription = 6;
-    AckRequest ack_request = 7;
-    StopSubscriptionRequest stop_subscription = 8;
-    DropSubscriptionRequest drop_subscription = 9;
+  oneof request_body {
+    LoginRequestBody login_request_body = 4;
+    StreamDataRequestBody stream_data_request_body = 5;
+    StartStreamingRequestBody start_streaming_request_body =6;

Review Comment:
   And also `START_STREAMING = 3;` after `STOP_STREAMING = 5;`



##########
proxy/frontend/core/src/main/java/org/apache/shardingsphere/proxy/frontend/netty/CDCChannelInboundHandler.java:
##########
@@ -112,33 +111,33 @@ public void channelRead(final ChannelHandlerContext ctx, final Object msg) {
             processLogin(ctx, request, connectionContext);
             return;
         }
-        switch (request.getRequestCase()) {
-            case CREATE_SUBSCRIPTION:
-                processCreateSubscription(ctx, request, connectionContext);
+        switch (request.getType()) {
+            case STREAM_DATA:
+                processStreamDataRequest(ctx, request, connectionContext);
                 break;
-            case START_SUBSCRIPTION:
-                processStartSubscription(ctx, request, connectionContext);
+            case START_STREAMING:
+                processStartStreamingRequest(ctx, request, connectionContext);

Review Comment:
   `case START_STREAMING` could be put after `case STOP_STREAMING`



##########
kernel/data-pipeline/cdc/protocol/src/main/proto/CDCRequestProtocol.proto:
##########
@@ -27,24 +27,24 @@ message CDCRequest {
   enum Type {
     UNKNOWN = 0;
     LOGIN = 1;
-    CREATE_SUBSCRIPTION = 2;
-    START_SUBSCRIPTION = 3;
-    ACK = 4;
-    STOP_SUBSCRIPTION = 5;
-    DROP_SUBSCRIPTION = 6;
+    STREAM_DATA = 2;
+    START_STREAMING = 3;
+    ACK_STREAMING = 4;
+    STOP_STREAMING = 5;
+    DROP_STREAMING = 6;
   }
   Type type = 3;
-  oneof request {
-    LoginRequest login = 4;
-    CreateSubscriptionRequest create_subscription = 5;
-    StartSubscriptionRequest start_subscription = 6;
-    AckRequest ack_request = 7;
-    StopSubscriptionRequest stop_subscription = 8;
-    DropSubscriptionRequest drop_subscription = 9;
+  oneof request_body {
+    LoginRequestBody login_request_body = 4;
+    StreamDataRequestBody stream_data_request_body = 5;
+    StartStreamingRequestBody start_streaming_request_body =6;

Review Comment:
   And also `message StartStreamingRequestBody`



##########
proxy/frontend/core/src/main/java/org/apache/shardingsphere/proxy/frontend/netty/CDCChannelInboundHandler.java:
##########
@@ -164,69 +163,79 @@ private String getHostAddress(final ChannelHandlerContext context) {
         return socketAddress instanceof InetSocketAddress ? ((InetSocketAddress) socketAddress).getAddress().getHostAddress() : socketAddress.toString();
     }
     
-    private void processCreateSubscription(final ChannelHandlerContext ctx, final CDCRequest request, final CDCConnectionContext connectionContext) {
-        if (!request.hasCreateSubscription()) {
-            ctx.writeAndFlush(CDCResponseGenerator.failed(request.getRequestId(), CDCResponseErrorCode.ILLEGAL_REQUEST_ERROR, "Miss create subscription request body"))
-                    .addListener(ChannelFutureListener.CLOSE);
+    private void processStreamDataRequest(final ChannelHandlerContext ctx, final CDCRequest request, final CDCConnectionContext connectionContext) {
+        if (!request.hasStreamDataRequestBody()) {
+            ctx.writeAndFlush(CDCResponseGenerator.failed(request.getRequestId(), CDCResponseErrorCode.ILLEGAL_REQUEST_ERROR, "Miss stream data request body"));
+            return;
+        }
+        StreamDataRequestBody streamDataRequestBody = request.getStreamDataRequestBody();
+        if (streamDataRequestBody.getDatabase().isEmpty()) {
+            ctx.writeAndFlush(CDCResponseGenerator.failed(request.getRequestId(), CDCResponseErrorCode.ILLEGAL_REQUEST_ERROR, "database not allowed to be empty"));
             return;
         }
-        CreateSubscriptionRequest createSubscriptionRequest = request.getCreateSubscription();
-        if (createSubscriptionRequest.getTableNamesList().isEmpty() || createSubscriptionRequest.getDatabase().isEmpty() || createSubscriptionRequest.getSubscriptionName().isEmpty()
-                || createSubscriptionRequest.getSubscriptionMode() == SubscriptionMode.UNKNOWN) {
-            ctx.writeAndFlush(CDCResponseGenerator.failed(request.getRequestId(), CDCResponseErrorCode.ILLEGAL_REQUEST_ERROR, "Illegal create subscription request parameter"));
+        // TODO need support the all tables at database or schema
+        if (streamDataRequestBody.getSourceSchemaTablesList().isEmpty()) {
+            ctx.writeAndFlush(CDCResponseGenerator.failed(request.getRequestId(), CDCResponseErrorCode.ILLEGAL_REQUEST_ERROR, "Illegal stream data request parameter"));
             return;
         }
-        checkPrivileges(connectionContext.getCurrentUser().getGrantee(), createSubscriptionRequest.getDatabase());
-        CDCResponse response = backendHandler.createSubscription(request);
+        checkPrivileges(connectionContext.getCurrentUser().getGrantee(), streamDataRequestBody.getDatabase());
+        CDCResponse response = backendHandler.streamData(request.getRequestId(), streamDataRequestBody, connectionContext, ctx.channel());
         ctx.writeAndFlush(response);
     }
     
-    private void processStartSubscription(final ChannelHandlerContext ctx, final CDCRequest request, final CDCConnectionContext connectionContext) {
-        if (!request.hasStartSubscription()) {
-            ctx.writeAndFlush(CDCResponseGenerator.failed(request.getRequestId(), CDCResponseErrorCode.ILLEGAL_REQUEST_ERROR, "Miss start subscription request body"))
+    private void processStartStreamingRequest(final ChannelHandlerContext ctx, final CDCRequest request, final CDCConnectionContext connectionContext) {
+        if (!request.hasStartStreamingRequestBody()) {
+            ctx.writeAndFlush(CDCResponseGenerator.failed(request.getRequestId(), CDCResponseErrorCode.ILLEGAL_REQUEST_ERROR, "Miss start streaming request body"))
                     .addListener(ChannelFutureListener.CLOSE);
             return;
         }
-        StartSubscriptionRequest startSubscriptionRequest = request.getStartSubscription();
-        if (startSubscriptionRequest.getDatabase().isEmpty() || startSubscriptionRequest.getSubscriptionName().isEmpty()) {
-            ctx.writeAndFlush(CDCResponseGenerator.failed(request.getRequestId(), CDCResponseErrorCode.ILLEGAL_REQUEST_ERROR, "Illegal start subscription request parameter"))
+        StartStreamingRequestBody startStreamingRequestBody = request.getStartStreamingRequestBody();
+        // TODO improve after cdc exception refactor
+        if (startStreamingRequestBody.getStreamingId().isEmpty()) {
+            ctx.writeAndFlush(CDCResponseGenerator.failed(request.getRequestId(), CDCResponseErrorCode.ILLEGAL_REQUEST_ERROR, "Illegal start streaming request parameter"))
                     .addListener(ChannelFutureListener.CLOSE);
             return;
         }
-        checkPrivileges(connectionContext.getCurrentUser().getGrantee(), startSubscriptionRequest.getDatabase());
-        CDCResponse response = backendHandler.startSubscription(request, ctx.channel(), connectionContext);
+        String database = backendHandler.getDatabaseByJobId(startStreamingRequestBody.getStreamingId());
+        checkPrivileges(connectionContext.getCurrentUser().getGrantee(), database);
+        CDCResponse response = backendHandler.startStreaming(request.getRequestId(), startStreamingRequestBody.getStreamingId(), connectionContext, ctx.channel());
         ctx.writeAndFlush(response);
     }
     
-    private void processStopSubscription(final ChannelHandlerContext ctx, final CDCRequest request, final CDCConnectionContext connectionContext) {
-        StopSubscriptionRequest stopSubscriptionRequest = request.getStopSubscription();
-        checkPrivileges(connectionContext.getCurrentUser().getGrantee(), stopSubscriptionRequest.getDatabase());
-        backendHandler.stopSubscription(connectionContext.getJobId());
+    private void processStopStreamingRequest(final ChannelHandlerContext ctx, final CDCRequest request, final CDCConnectionContext connectionContext) {
+        StopStreamingRequestBody stopStreamingRequestBody = request.getStopStreamingRequestBody();
+        String database = backendHandler.getDatabaseByJobId(stopStreamingRequestBody.getStreamingId());
+        checkPrivileges(connectionContext.getCurrentUser().getGrantee(), database);
+        backendHandler.stopStreaming(connectionContext.getJobId());
         connectionContext.setStatus(CDCConnectionStatus.LOGGED_IN);
+        connectionContext.setJobId(null);
         ctx.writeAndFlush(CDCResponseGenerator.succeedBuilder(request.getRequestId()).build());
     }
     
-    private void processDropSubscription(final ChannelHandlerContext ctx, final CDCRequest request, final CDCConnectionContext connectionContext) {
-        DropSubscriptionRequest dropSubscriptionRequest = request.getDropSubscription();
-        checkPrivileges(connectionContext.getCurrentUser().getGrantee(), dropSubscriptionRequest.getDatabase());
+    private void processDropStreamingRequest(final ChannelHandlerContext ctx, final CDCRequest request, final CDCConnectionContext connectionContext) {
+        DropStreamingRequestBody dropStreamingRequestBody = request.getDropStreamingRequestBody();
+        String database = backendHandler.getDatabaseByJobId(dropStreamingRequestBody.getStreamingId());
+        checkPrivileges(connectionContext.getCurrentUser().getGrantee(), database);
         try {
-            backendHandler.dropSubscription(connectionContext.getJobId());
+            backendHandler.dropStreaming(connectionContext.getJobId());
+            connectionContext.setStatus(CDCConnectionStatus.LOGGED_IN);

Review Comment:
   Is it necessary to set status as `LOGGED_IN` when dropStreaming? And also when stopStreaming



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org