[GitHub] [incubator-gobblin] ZihanLi58 commented on a change in pull request #2815: GOBBLIN-970: Pass metric context from the KafkaSource to the KafkaWor…

[GitBox <gi...@apache.org>]

ZihanLi58 commented on a change in pull request #2815: GOBBLIN-970: Pass metric context from the KafkaSource to the KafkaWor…
URL: https://github.com/apache/incubator-gobblin/pull/2815#discussion_r347671916
 
 

 ##########
 File path: gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/workunit/packer/KafkaWorkUnitPacker.java
 ##########
 @@ -367,19 +368,19 @@ private static void logMultiWorkUnitInfo(Iterable<MultiWorkUnit> mwus) {
     return partitions;
   }
 
-  public static KafkaWorkUnitPacker getInstance(AbstractSource<?, ?> source, SourceState state) {
 
 Review comment:
   Should we keep the original function to make the change backward compatible?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services