[GitHub] [airflow] mik-laj commented on a change in pull request #13984: Fixed reading from zip package to default to text.

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #13984:
URL: https://github.com/apache/airflow/pull/13984#discussion_r567301520



##########
File path: tests/utils/test_dag_processing.py
##########
@@ -586,13 +586,16 @@ def test_open_maybe_zipped_normal_file_with_zip_in_name(self):
 
     @mock.patch("zipfile.is_zipfile")
     @mock.patch("zipfile.ZipFile")
-    def test_open_maybe_zipped_archive(self, mocked_zip_file, mocked_is_zipfile):
+    @mock.patch("io.TextIOWrapper")
+    def test_open_maybe_zipped_archive(self, mocked_text_io_wrapper, mocked_zip_file, mocked_is_zipfile):

Review comment:
       Can you move this test case to `test/utils/test_file.py`?  During the review, I checked that the file was missing and hence I merged the change that didn't work.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org