Re: [PR] feat(bindings/nodejs): write stream [incubator-opendal]

["Xuanwo (via GitHub)" <gi...@apache.org>]

Xuanwo commented on code in PR #3619:
URL: https://github.com/apache/incubator-opendal/pull/3619#discussion_r1404120272


##########
bindings/nodejs/tests/fixtures/random:
##########
@@ -0,0 +1,19 @@
+Enjoyed minutes related as at on on. Is fanny dried as often me. Goodness as reserved raptures to mistaken steepest oh screened he. Gravity he mr sixteen esteems. Mile home its new way with high told said. Finished no horrible blessing landlord dwelling dissuade if. Rent fond am he in on read. Anxious cordial demands settled entered in do to colonel.

Review Comment:
   Do we have license issues for those content?
   
   It's better to generate random files by scripts instead.



##########
bindings/nodejs/tests/suites/async.suite.mjs:
##########
@@ -19,15 +19,31 @@
 
 import { randomUUID } from 'node:crypto'
 import { test } from 'vitest'
+import { generateBytes } from '../utils.mjs'
 
-export function run(operator) {
+export function run(op) {
   test('async stat not exist files', async () => {
     const filename = `random_file_${randomUUID()}`
 
     try {
-      await operator.stat(filename)
+      await op.stat(filename)
     } catch (error) {
       assert.include(error.message, 'NotFound')
     }
   })
+
+  test('async writer', async () => {

Review Comment:
   This test will fail on most storage even when they support `writeCanMulti` since services may have it's own `write_min_size`. Rust core implement those tests by adding a `buffer`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org