You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/10/09 16:43:51 UTC
[GitHub] [skywalking-java] xu1009 opened a new pull request #45: Add kylin jdbc plugin
xu1009 opened a new pull request #45:
URL: https://github.com/apache/skywalking-java/pull/45
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
### Add an agent plugin to support <framework name>
- [x] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking-java/blob/main/docs/en/setup/service-agent/java-agent/Plugin-test.md)
- [x] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/component-libraries.yml)
- [x] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking-java/blob/main/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<7869>.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #45: Add kylin jdbc plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #45:
URL: https://github.com/apache/skywalking-java/pull/45#issuecomment-940931352
You forgot to change GitHub Action control file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #45: Add kylin jdbc plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #45:
URL: https://github.com/apache/skywalking-java/pull/45#discussion_r726074225
##########
File path: test/plugin/scenarios/kylin-jdbc-2.6.x-scenario/support-version.list
##########
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+2.6.3
+2.6.4
+2.6.5
+2.6.6
Review comment:
Usually we don't test patch edition. Please choose one.
Does this plugin support more than just 2.6.x? It is better to cover those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xu1009 commented on a change in pull request #45: Add kylin jdbc plugin
Posted by GitBox <gi...@apache.org>.
xu1009 commented on a change in pull request #45:
URL: https://github.com/apache/skywalking-java/pull/45#discussion_r725986385
##########
File path: docs/en/setup/service-agent/java-agent/Plugin-list.md
##########
@@ -125,3 +125,4 @@
- spring-cloud-gateway-3.x
- neo4j-4.x
- clickhouse-0.3.x
+- Apache-Kylin-2.6.x
Review comment:
ok, it is ok now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xu1009 commented on a change in pull request #45: Add kylin jdbc plugin
Posted by GitBox <gi...@apache.org>.
xu1009 commented on a change in pull request #45:
URL: https://github.com/apache/skywalking-java/pull/45#discussion_r726734459
##########
File path: test/plugin/scenarios/kylin-jdbc-2.6.x-scenario/support-version.list
##########
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+2.6.6
+3.0.2
+3.1.2
+4.0.0
Review comment:
yes, all pass, i do not know how to rename it, it supoort 2.6.3 -> 4.0.0， the name is releated to the version, any suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xu1009 commented on a change in pull request #45: Add kylin jdbc plugin
Posted by GitBox <gi...@apache.org>.
xu1009 commented on a change in pull request #45:
URL: https://github.com/apache/skywalking-java/pull/45#discussion_r726907083
##########
File path: apm-sniffer/apm-sdk-plugin/kylin-jdbc-2.6.x-3.x-4.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/kylin/v2/CreateCallableStatementInterceptor.java
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.jdbc.kylin.v2;
Review comment:
ok, i get it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng merged pull request #45: Add kylin jdbc plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #45:
URL: https://github.com/apache/skywalking-java/pull/45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xu1009 commented on a change in pull request #45: Add kylin jdbc plugin
Posted by GitBox <gi...@apache.org>.
xu1009 commented on a change in pull request #45:
URL: https://github.com/apache/skywalking-java/pull/45#discussion_r726830492
##########
File path: apm-sniffer/apm-sdk-plugin/kylin-jdbc-2.6.x-3.x-4.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/kylin/v2/CreateCallableStatementInterceptor.java
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.jdbc.kylin.v2;
Review comment:
in my advice, i think it is not necessary, it can be the version of code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xu1009 commented on pull request #45: Add kylin jdbc plugin
Posted by GitBox <gi...@apache.org>.
xu1009 commented on pull request #45:
URL: https://github.com/apache/skywalking-java/pull/45#issuecomment-940947675
> GitHub
== fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #45: Add kylin jdbc plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #45:
URL: https://github.com/apache/skywalking-java/pull/45#discussion_r726720238
##########
File path: test/plugin/scenarios/kylin-jdbc-2.6.x-scenario/support-version.list
##########
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+2.6.3
+2.6.4
+2.6.5
+2.6.6
Review comment:
Higher and lower should be considered both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xu1009 commented on pull request #45: Add kylin jdbc plugin
Posted by GitBox <gi...@apache.org>.
xu1009 commented on pull request #45:
URL: https://github.com/apache/skywalking-java/pull/45#issuecomment-939757963
@wu-sheng there has code style xml for idea? i can format code in idea with the code style config xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xu1009 commented on pull request #45: Add kylin jdbc plugin
Posted by GitBox <gi...@apache.org>.
xu1009 commented on pull request #45:
URL: https://github.com/apache/skywalking-java/pull/45#issuecomment-939644332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xu1009 commented on a change in pull request #45: Add kylin jdbc plugin
Posted by GitBox <gi...@apache.org>.
xu1009 commented on a change in pull request #45:
URL: https://github.com/apache/skywalking-java/pull/45#discussion_r726726561
##########
File path: test/plugin/scenarios/kylin-jdbc-2.6.x-scenario/support-version.list
##########
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+2.6.3
+2.6.4
+2.6.5
+2.6.6
Review comment:
lower not support, i have tried
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xu1009 commented on a change in pull request #45: Add kylin jdbc plugin
Posted by GitBox <gi...@apache.org>.
xu1009 commented on a change in pull request #45:
URL: https://github.com/apache/skywalking-java/pull/45#discussion_r726793181
##########
File path: test/plugin/scenarios/kylin-jdbc-2.6.x-scenario/support-version.list
##########
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+2.6.6
+3.0.2
+3.1.2
+4.0.0
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #45: Add kylin jdbc plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #45:
URL: https://github.com/apache/skywalking-java/pull/45#discussion_r726775280
##########
File path: test/plugin/scenarios/kylin-jdbc-2.6.x-scenario/support-version.list
##########
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+2.6.6
+3.0.2
+3.1.2
+4.0.0
Review comment:
Use 2.6.x-3.x-4.x in the name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #45: Add kylin jdbc plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #45:
URL: https://github.com/apache/skywalking-java/pull/45#discussion_r726730897
##########
File path: test/plugin/scenarios/kylin-jdbc-2.6.x-scenario/support-version.list
##########
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+2.6.6
+3.0.2
+3.1.2
+4.0.0
Review comment:
Are these passed locally? If so, you should update supported-list doc and consider renaming the plugin name. 2.6.x seems only working for one version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xu1009 commented on pull request #45: Add kylin jdbc plugin
Posted by GitBox <gi...@apache.org>.
xu1009 commented on pull request #45:
URL: https://github.com/apache/skywalking-java/pull/45#issuecomment-939759117
local compile looks no checkstyle problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #45: Add kylin jdbc plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #45:
URL: https://github.com/apache/skywalking-java/pull/45#discussion_r725905949
##########
File path: docs/en/setup/service-agent/java-agent/Plugin-list.md
##########
@@ -125,3 +125,4 @@
- spring-cloud-gateway-3.x
- neo4j-4.x
- clickhouse-0.3.x
+- Apache-Kylin-2.6.x
Review comment:
This is what you got wrong, https://github.com/apache/skywalking-java/blob/813fc31bd2c6a243db781f4d1a8f7959510b7536/.github/workflows/ci.yaml#L73.
Please check locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #45: Add kylin jdbc plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #45:
URL: https://github.com/apache/skywalking-java/pull/45#discussion_r726074881
##########
File path: test/plugin/scenarios/kylin-jdbc-2.6.x-scenario/config/expectedData.yaml
##########
@@ -0,0 +1,82 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+segmentItems:
+- serviceName: kylin-jdbc-2.6.x-scenario
+ segmentSize: ge 1
+ segments:
+ - segmentId: not null
+ spans:
+ - operationName: Apache-kylin/JDBI/Statement/execute
Review comment:
```suggestion
- operationName: kylin/JDBI/Statement/execute
```
It is better to like this. The string costs network and storage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #45: Add kylin jdbc plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #45:
URL: https://github.com/apache/skywalking-java/pull/45#discussion_r725875344
##########
File path: docs/en/setup/service-agent/java-agent/Plugin-list.md
##########
@@ -125,3 +125,4 @@
- spring-cloud-gateway-3.x
- neo4j-4.x
- clickhouse-0.3.x
+- Apache-Kylin-2.6.x
Review comment:
I think this is not correct name(no upper case maybe?). Please check CI logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xu1009 commented on a change in pull request #45: Add kylin jdbc plugin
Posted by GitBox <gi...@apache.org>.
xu1009 commented on a change in pull request #45:
URL: https://github.com/apache/skywalking-java/pull/45#discussion_r726708961
##########
File path: test/plugin/scenarios/kylin-jdbc-2.6.x-scenario/support-version.list
##########
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+2.6.3
+2.6.4
+2.6.5
+2.6.6
Review comment:
ok, i will try some higher version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #45: Add kylin jdbc plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #45:
URL: https://github.com/apache/skywalking-java/pull/45#discussion_r726826456
##########
File path: apm-sniffer/apm-sdk-plugin/kylin-jdbc-2.6.x-3.x-4.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/kylin/v2/CreateCallableStatementInterceptor.java
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.jdbc.kylin.v2;
Review comment:
Should we remove `v2`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #45: Add kylin jdbc plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #45:
URL: https://github.com/apache/skywalking-java/pull/45#discussion_r726862560
##########
File path: apm-sniffer/apm-sdk-plugin/kylin-jdbc-2.6.x-3.x-4.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/kylin/v2/CreateCallableStatementInterceptor.java
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.jdbc.kylin.v2;
Review comment:
As we have widely compatibility of this plugin(2.6 -> 4.x), and we never had this plugin, it is better to remove it. If some API breaks in the future, we could have `kylin.v5`(for example) in the next time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xu1009 commented on pull request #45: Add kylin jdbc plugin
Posted by GitBox <gi...@apache.org>.
xu1009 commented on pull request #45:
URL: https://github.com/apache/skywalking-java/pull/45#issuecomment-940920156
local pass, this name is diff with the code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xu1009 commented on a change in pull request #45: Add kylin jdbc plugin
Posted by GitBox <gi...@apache.org>.
xu1009 commented on a change in pull request #45:
URL: https://github.com/apache/skywalking-java/pull/45#discussion_r726709138
##########
File path: test/plugin/scenarios/kylin-jdbc-2.6.x-scenario/config/expectedData.yaml
##########
@@ -0,0 +1,82 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+segmentItems:
+- serviceName: kylin-jdbc-2.6.x-scenario
+ segmentSize: ge 1
+ segments:
+ - segmentId: not null
+ spans:
+ - operationName: Apache-kylin/JDBI/Statement/execute
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #45: Add kylin jdbc plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #45:
URL: https://github.com/apache/skywalking-java/pull/45#discussion_r725776466
##########
File path: apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java
##########
@@ -215,4 +215,5 @@
public static final OfficialComponent JACKSON = new OfficialComponent(118, "Jackson");
+ public static final OfficialComponent APACHE_KYLIN_JDBC_DRIVER = new OfficialComponent(121, "apache-kylin-jdbc-driver");
Review comment:
Ignore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #45: Add kylin jdbc plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #45:
URL: https://github.com/apache/skywalking-java/pull/45#issuecomment-939769111
Yes, we have, https://github.com/apache/skywalking-java/blob/main/codeStyle.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xu1009 commented on a change in pull request #45: Add kylin jdbc plugin
Posted by GitBox <gi...@apache.org>.
xu1009 commented on a change in pull request #45:
URL: https://github.com/apache/skywalking-java/pull/45#discussion_r725900571
##########
File path: docs/en/setup/service-agent/java-agent/Plugin-list.md
##########
@@ -125,3 +125,4 @@
- spring-cloud-gateway-3.x
- neo4j-4.x
- clickhouse-0.3.x
+- Apache-Kylin-2.6.x
Review comment:
the ci log can not show what is the error, i try to fix it to lower case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #45: Add kylin jdbc plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #45:
URL: https://github.com/apache/skywalking-java/pull/45#discussion_r725765268
##########
File path: apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java
##########
@@ -215,4 +215,5 @@
public static final OfficialComponent JACKSON = new OfficialComponent(118, "Jackson");
+ public static final OfficialComponent APACHE_KYLIN_JDBC_DRIVER = new OfficialComponent(121, "apache-kylin-jdbc-driver");
Review comment:
This has been removed, please sync with the upstream master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xu1009 commented on a change in pull request #45: Add kylin jdbc plugin
Posted by GitBox <gi...@apache.org>.
xu1009 commented on a change in pull request #45:
URL: https://github.com/apache/skywalking-java/pull/45#discussion_r725774133
##########
File path: apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java
##########
@@ -215,4 +215,5 @@
public static final OfficialComponent JACKSON = new OfficialComponent(118, "Jackson");
+ public static final OfficialComponent APACHE_KYLIN_JDBC_DRIVER = new OfficialComponent(121, "apache-kylin-jdbc-driver");
Review comment:
i don not get, you mean this file has changed ? i merge master just now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org