[jira] [Commented] (AIRFLOW-578) BaseJob does not check return code of a process

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17001093#comment-17001093 ] 

ASF GitHub Bot commented on AIRFLOW-578:
----------------------------------------

lucafuji commented on pull request #6870: [AIRFLOW-578] Fix check return code
URL: https://github.com/apache/airflow/pull/6870
 
 
   
   ### Jira
   
   - [x] My PR addresses the following [AIRFLOW-578](https://issues.apache.org/jira/browse/AIRFLOW-578) issues and references them in the PR title.
     - https://issues.apache.org/jira/browse/AIRFLOW-578
   
   ### Description
   Check the return code of the spawned process of LocalTaskJob. 
   
   ### Tests
   
   - [x] My PR adds the following unit tests  
    tests.test_jobs:LocalTaskJobTest.test_localtaskjob_invalid_return_code
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> BaseJob does not check return code of a process
> -----------------------------------------------
>
>                 Key: AIRFLOW-578
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-578
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: scheduler
>            Reporter: Ze Wang
>            Priority: Major
>
> BaseJob ignores the return code of the spawned process. which makes even that process is killed or returned abnormally, it will think it finishes with success



--
This message was sent by Atlassian Jira
(v8.3.4#803005)