You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/05/24 10:37:07 UTC

[GitHub] [maven] Bananeweizen opened a new pull request #350: [MNG-6907] fix endless loop in StringSearchModelInterpolator

Bananeweizen opened a new pull request #350:
URL: https://github.com/apache/maven/pull/350


   Avoid endless recursion by checking for equality between current parameter and recursion parameter. Although it seems unreasonable to have Java classes, where the superclass is identical to the current class, I've experienced this in practice.
   
   I've verified there are no other code locations using a similar recursion pattern in StringSearchModelInterpolator or its successor StringVisitorModelInterpolator.
   
    - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/MNG/issues/MNG-6907) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [X] Each commit in the pull request should have a meaningful subject line and body.
    - [X] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the 
          commit message.
    - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will 
          be performed on your pull request automatically.
    - [ ] You have run the [Core IT][core-its] successfully.
   
   Core IT has not been run. Documentation says to use profile "run-tis", but there is no such profile.
   
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] slachiewicz closed pull request #350: [MNG-6907] fix endless loop in StringSearchModelInterpolator

Posted by GitBox <gi...@apache.org>.
slachiewicz closed pull request #350:
URL: https://github.com/apache/maven/pull/350


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] khmarbaise commented on pull request #350: [MNG-6907] fix endless loop in StringSearchModelInterpolator

Posted by GitBox <gi...@apache.org>.
khmarbaise commented on pull request #350:
URL: https://github.com/apache/maven/pull/350#issuecomment-633211761


   First let us check what CI says...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] rfscholte commented on pull request #350: [MNG-6907] fix endless loop in StringSearchModelInterpolator

Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #350:
URL: https://github.com/apache/maven/pull/350#issuecomment-647010047


   So this means that a plugin that needs it, will require at least Maven 3.6.2 at compile time (or use reflection) and at runtime it must verify if `StringVisitorModelInterpolator` is avaible. If not, keep using the `StringSearchModelInterpolator`.
   If that is the idea, one should close this PR and MNG-6907


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] slachiewicz commented on pull request #350: [MNG-6907] fix endless loop in StringSearchModelInterpolator

Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #350:
URL: https://github.com/apache/maven/pull/350#issuecomment-647004068


   SearchStringInterpreter is no longer in use in Maven Core and in 3.6.3 shouldn't be injected


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] khmarbaise edited a comment on pull request #350: [MNG-6907] fix endless loop in StringSearchModelInterpolator

Posted by GitBox <gi...@apache.org>.
khmarbaise edited a comment on pull request #350:
URL: https://github.com/apache/maven/pull/350#issuecomment-633211761


   First let us check what CI says...
   
   https://builds.apache.org/job/maven-box/job/maven/job/Bananeweizen-MNG-6907/


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org