You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/04 12:10:16 UTC
[GitHub] [flink-statefun] tzulitai opened a new pull request #50:
[FLINK-16415] [core] Add format versioning to YAML-ized modules
tzulitai opened a new pull request #50: [FLINK-16415] [core] Add format versioning to YAML-ized modules
URL: https://github.com/apache/flink-statefun/pull/50
This PR adds a required `version` field to YAML-ized modules.
The starting format version will be `1.0`, following the conventions of systems like docker-compose.
The changelog commits should be self-explanatory on how this is implemented.
Note: From the looks of the code, the `Pointers` and `JsonModule` classes could use some refactoring, but we can revisit that once we introduce more format versions in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] tzulitai commented on issue #50: [FLINK-16415]
[core] Add format versioning to YAML-ized modules
Posted by GitBox <gi...@apache.org>.
tzulitai commented on issue #50: [FLINK-16415] [core] Add format versioning to YAML-ized modules
URL: https://github.com/apache/flink-statefun/pull/50#issuecomment-595552940
Thanks, merging ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] igalshilman removed a comment on issue #50:
[FLINK-16415] [core] Add format versioning to YAML-ized modules
Posted by GitBox <gi...@apache.org>.
igalshilman removed a comment on issue #50: [FLINK-16415] [core] Add format versioning to YAML-ized modules
URL: https://github.com/apache/flink-statefun/pull/50#issuecomment-595440578
Looks good to me!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] tzulitai commented on issue #50: [FLINK-16415]
[core] Add format versioning to YAML-ized modules
Posted by GitBox <gi...@apache.org>.
tzulitai commented on issue #50: [FLINK-16415] [core] Add format versioning to YAML-ized modules
URL: https://github.com/apache/flink-statefun/pull/50#issuecomment-594484776
cc @igalshilman
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] igalshilman commented on issue #50: [FLINK-16415]
[core] Add format versioning to YAML-ized modules
Posted by GitBox <gi...@apache.org>.
igalshilman commented on issue #50: [FLINK-16415] [core] Add format versioning to YAML-ized modules
URL: https://github.com/apache/flink-statefun/pull/50#issuecomment-595440578
Looks good to me!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] tzulitai closed pull request #50: [FLINK-16415]
[core] Add format versioning to YAML-ized modules
Posted by GitBox <gi...@apache.org>.
tzulitai closed pull request #50: [FLINK-16415] [core] Add format versioning to YAML-ized modules
URL: https://github.com/apache/flink-statefun/pull/50
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services