You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Peter M. Goldstein" <pe...@yahoo.com> on 2002/07/27 03:46:50 UTC

[PATCH] Bug #6340


All,

Sorry.  Previous message did not have an appropriate subject line.

--Peter

-----Original Message-----
From: Peter M. Goldstein [mailto:peter_m_goldstein@yahoo.com] 
Sent: Friday, July 26, 2002 6:45 PM
To: 'James Developers List'
Subject: FW: Question about SMTP AUTH and mozilla and apple mail


Noel,

There was already a thread on james-dev as a result of the bugzilla
modification (see emails of 7/2/02), but point taken.  Attached is the
diff.

This patch is designed to resolve bug #6340 in the least intrusive way -
by keeping the scope of the AUTH PLAIN specific argument parsing to
within the doAuth method.

--Peter 

-----Original Message-----
From: Noel J. Bergman [mailto:noel@devtech.com] 
Sent: Friday, July 26, 2002 6:34 PM
To: James Users List
Subject: RE: Question about SMTP AUTH and mozilla and apple mail

Excellent news!  :-)  Perhaps Peter can submit it a message to the JAMES
developer mailing list according to
http://jakarta.apache.org/site/bugs.html.  Then a few of us can look it
over, vet it, and encourage the maintainers to commit it.

[Yes, I know that the patch is in the bugs database, but the messsage
gives
us a place to hang the thread.]

	--- Noel

-----Original Message-----
From: David Rodal [mailto:iridiump@bellatlantic.net]
Sent: Friday, July 26, 2002 21:16
To: James Users List
Subject: Re: Question about SMTP AUTH and mozilla and apple mail


Yes Peter's fix works now for my OS X mail AND mozilla under OS X!!!!!

Check out the Peter's attachment for bug 6340 and put it in and you will
be very happy to!!!!

I'm the happiest man alive right now! :-)

David Rodal

Thanks again everyone.


On Friday, July 26, 2002, at 08:36 PM, eric aboudaram wrote:

> i have the same problem and i didn't find a solution
>
> mozilla send login@domain
> strange !!!!
>
> i create a user with logn@domain but whitout success
> :'(


--
To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
For additional commands, e-mail:
<ma...@jakarta.apache.org>

[PATCH] Bug #6812 (take 2)

Posted by "Peter M. Goldstein" <pe...@yahoo.com>.
All,

Sorry.  I inadvertently introduced a bug in the absolute URL handling in
the previous revision of this fix by stripping off the leading '/'.
That'll cause a problem on non-Windows systems.  Here's a corrected fix.

--Peter

-----Original Message-----
From: Peter M. Goldstein [mailto:peter_m_goldstein@yahoo.com] 
Sent: Saturday, July 27, 2002 3:07 PM
To: 'James Developers List'
Subject: [PATCH] Bug #6812



All,

The attached files are a patch for bug #6812, improper handling of
absolute file URLs.  Basically they consist of a check to see whether
the URL starts with '/' after the initial file:// protocol prefix.  If
so, the initial '/' is stripped off and the resulting string is taken as
the file path.  If not, the base directory obtained from the block
context is prepended to the string to obtain the file path.

--Peter 

RE: [PATCH] Bug #6812

Posted by Danny Angus <da...@apache.org>.
What so a *nix path has to be file:////usr/?
I think file:///usr is what we want.


> -----Original Message-----
> From: Peter M. Goldstein [mailto:peter_m_goldstein@yahoo.com]
> Sent: 27 July 2002 23:07
> To: 'James Developers List'
> Subject: [PATCH] Bug #6812
> 
> 
> 
> 
> All,
> 
> The attached files are a patch for bug #6812, improper handling of
> absolute file URLs.  Basically they consist of a check to see whether
> the URL starts with '/' after the initial file:// protocol prefix.  If
> so, the initial '/' is stripped off and the resulting string is taken as
> the file path.  If not, the base directory obtained from the block
> context is prepended to the string to obtain the file path.
> 
> --Peter 
> 

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


[PATCH] Bug #6812

Posted by "Peter M. Goldstein" <pe...@yahoo.com>.

All,

The attached files are a patch for bug #6812, improper handling of
absolute file URLs.  Basically they consist of a check to see whether
the URL starts with '/' after the initial file:// protocol prefix.  If
so, the initial '/' is stripped off and the resulting string is taken as
the file path.  If not, the base directory obtained from the block
context is prepended to the string to obtain the file path.

--Peter 

RE: [PATCH] Bug #11233

Posted by Danny Angus <da...@apache.org>.
Thanks Peter, I'll get these commited asap.

> -----Original Message-----
> From: Peter M. Goldstein [mailto:peter_m_goldstein@yahoo.com]
> Sent: 27 July 2002 20:07
> To: 'James Developers List'
> Subject: [PATCH] Bug #11233
> 
> 
> 
> All,
> 
> The attached files constitute a patch to James to restore thread safety
> to its date formatting, addressing the issues discussed in bug #11233.
> 
> This is the second revision of these changes, spurred mostly by
> Harmeet's response to the first, simpler revision.  Please see my email
> of 7/2/2002 to this list with the subject "RE: Possible Synchronization
> Issue" for further details of that discussion.
> 
> Please note that bug #8774 may be related to this issue.
> 
> --Peter
> 

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


[PATCH] Bug #11233

Posted by "Peter M. Goldstein" <pe...@yahoo.com>.
All,

The attached files constitute a patch to James to restore thread safety
to its date formatting, addressing the issues discussed in bug #11233.

This is the second revision of these changes, spurred mostly by
Harmeet's response to the first, simpler revision.  Please see my email
of 7/2/2002 to this list with the subject "RE: Possible Synchronization
Issue" for further details of that discussion.

Please note that bug #8774 may be related to this issue.

--Peter

RE: [PATCH] Bug #6340

Posted by "Peter M. Goldstein" <pe...@yahoo.com>.
Danny,

Is this necessary now that you've committed the change?

--Peter

-----Original Message-----
From: Danny Angus [mailto:danny@apache.org] 
Sent: Saturday, July 27, 2002 3:03 AM
To: James Developers List; danny@apache.org
Subject: RE: [PATCH] Bug #6340

Please can we have this patch as a "diff -u"

> -----Original Message-----
> From: Danny Angus [mailto:danny@apache.org]
> Sent: 27 July 2002 08:51
> To: James Developers List; farsight@alum.mit.edu
> Subject: RE: [PATCH] Bug #6340
>
>
> I think that if this diff was *only* attached to bugzilla it would
explain
> why it had been ignored.
>
> > -----Original Message-----
> > From: Peter M. Goldstein [mailto:peter_m_goldstein@yahoo.com]
> > Sent: 27 July 2002 02:47
> > To: 'James Developers List'
> > Subject: [PATCH] Bug #6340
> >
> >
> >
> >
> > All,
> >
> > Sorry.  Previous message did not have an appropriate subject line.
> >
> > --Peter
> >
> > -----Original Message-----
> > From: Peter M. Goldstein [mailto:peter_m_goldstein@yahoo.com]
> > Sent: Friday, July 26, 2002 6:45 PM
> > To: 'James Developers List'
> > Subject: FW: Question about SMTP AUTH and mozilla and apple mail
> >
> >
> > Noel,
> >
> > There was already a thread on james-dev as a result of the bugzilla
> > modification (see emails of 7/2/02), but point taken.  Attached is
the
> > diff.
> >
> > This patch is designed to resolve bug #6340 in the least intrusive
way -
> > by keeping the scope of the AUTH PLAIN specific argument parsing to
> > within the doAuth method.
> >
> > --Peter
> >
> > -----Original Message-----
> > From: Noel J. Bergman [mailto:noel@devtech.com]
> > Sent: Friday, July 26, 2002 6:34 PM
> > To: James Users List
> > Subject: RE: Question about SMTP AUTH and mozilla and apple mail
> >
> > Excellent news!  :-)  Perhaps Peter can submit it a message to the
JAMES
> > developer mailing list according to
> > http://jakarta.apache.org/site/bugs.html.  Then a few of us can look
it
> > over, vet it, and encourage the maintainers to commit it.
> >
> > [Yes, I know that the patch is in the bugs database, but the
messsage
> > gives
> > us a place to hang the thread.]
> >
> > 	--- Noel
> >
> > -----Original Message-----
> > From: David Rodal [mailto:iridiump@bellatlantic.net]
> > Sent: Friday, July 26, 2002 21:16
> > To: James Users List
> > Subject: Re: Question about SMTP AUTH and mozilla and apple mail
> >
> >
> > Yes Peter's fix works now for my OS X mail AND mozilla under OS
X!!!!!
> >
> > Check out the Peter's attachment for bug 6340 and put it in and you
will
> > be very happy to!!!!
> >
> > I'm the happiest man alive right now! :-)
> >
> > David Rodal
> >
> > Thanks again everyone.
> >
> >
> > On Friday, July 26, 2002, at 08:36 PM, eric aboudaram wrote:
> >
> > > i have the same problem and i didn't find a solution
> > >
> > > mozilla send login@domain
> > > strange !!!!
> > >
> > > i create a user with logn@domain but whitout success
> > > :'(
> >
> >
> > --
> > To unsubscribe, e-mail:
> > <ma...@jakarta.apache.org>
> > For additional commands, e-mail:
> > <ma...@jakarta.apache.org>
> >
>
>
> --
> To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
For additional commands, e-mail:
<ma...@jakarta.apache.org>


--
To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
For additional commands, e-mail:
<ma...@jakarta.apache.org>



--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


RE: [PATCH] Bug #6340

Posted by Danny Angus <da...@apache.org>.
Please can we have this patch as a "diff -u"

> -----Original Message-----
> From: Danny Angus [mailto:danny@apache.org]
> Sent: 27 July 2002 08:51
> To: James Developers List; farsight@alum.mit.edu
> Subject: RE: [PATCH] Bug #6340
>
>
> I think that if this diff was *only* attached to bugzilla it would explain
> why it had been ignored.
>
> > -----Original Message-----
> > From: Peter M. Goldstein [mailto:peter_m_goldstein@yahoo.com]
> > Sent: 27 July 2002 02:47
> > To: 'James Developers List'
> > Subject: [PATCH] Bug #6340
> >
> >
> >
> >
> > All,
> >
> > Sorry.  Previous message did not have an appropriate subject line.
> >
> > --Peter
> >
> > -----Original Message-----
> > From: Peter M. Goldstein [mailto:peter_m_goldstein@yahoo.com]
> > Sent: Friday, July 26, 2002 6:45 PM
> > To: 'James Developers List'
> > Subject: FW: Question about SMTP AUTH and mozilla and apple mail
> >
> >
> > Noel,
> >
> > There was already a thread on james-dev as a result of the bugzilla
> > modification (see emails of 7/2/02), but point taken.  Attached is the
> > diff.
> >
> > This patch is designed to resolve bug #6340 in the least intrusive way -
> > by keeping the scope of the AUTH PLAIN specific argument parsing to
> > within the doAuth method.
> >
> > --Peter
> >
> > -----Original Message-----
> > From: Noel J. Bergman [mailto:noel@devtech.com]
> > Sent: Friday, July 26, 2002 6:34 PM
> > To: James Users List
> > Subject: RE: Question about SMTP AUTH and mozilla and apple mail
> >
> > Excellent news!  :-)  Perhaps Peter can submit it a message to the JAMES
> > developer mailing list according to
> > http://jakarta.apache.org/site/bugs.html.  Then a few of us can look it
> > over, vet it, and encourage the maintainers to commit it.
> >
> > [Yes, I know that the patch is in the bugs database, but the messsage
> > gives
> > us a place to hang the thread.]
> >
> > 	--- Noel
> >
> > -----Original Message-----
> > From: David Rodal [mailto:iridiump@bellatlantic.net]
> > Sent: Friday, July 26, 2002 21:16
> > To: James Users List
> > Subject: Re: Question about SMTP AUTH and mozilla and apple mail
> >
> >
> > Yes Peter's fix works now for my OS X mail AND mozilla under OS X!!!!!
> >
> > Check out the Peter's attachment for bug 6340 and put it in and you will
> > be very happy to!!!!
> >
> > I'm the happiest man alive right now! :-)
> >
> > David Rodal
> >
> > Thanks again everyone.
> >
> >
> > On Friday, July 26, 2002, at 08:36 PM, eric aboudaram wrote:
> >
> > > i have the same problem and i didn't find a solution
> > >
> > > mozilla send login@domain
> > > strange !!!!
> > >
> > > i create a user with logn@domain but whitout success
> > > :'(
> >
> >
> > --
> > To unsubscribe, e-mail:
> > <ma...@jakarta.apache.org>
> > For additional commands, e-mail:
> > <ma...@jakarta.apache.org>
> >
>
>
> --
> To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


RE: [PATCH] Bug #6340

Posted by Danny Angus <da...@apache.org>.
I think that if this diff was *only* attached to bugzilla it would explain
why it had been ignored.

> -----Original Message-----
> From: Peter M. Goldstein [mailto:peter_m_goldstein@yahoo.com]
> Sent: 27 July 2002 02:47
> To: 'James Developers List'
> Subject: [PATCH] Bug #6340
>
>
>
>
> All,
>
> Sorry.  Previous message did not have an appropriate subject line.
>
> --Peter
>
> -----Original Message-----
> From: Peter M. Goldstein [mailto:peter_m_goldstein@yahoo.com]
> Sent: Friday, July 26, 2002 6:45 PM
> To: 'James Developers List'
> Subject: FW: Question about SMTP AUTH and mozilla and apple mail
>
>
> Noel,
>
> There was already a thread on james-dev as a result of the bugzilla
> modification (see emails of 7/2/02), but point taken.  Attached is the
> diff.
>
> This patch is designed to resolve bug #6340 in the least intrusive way -
> by keeping the scope of the AUTH PLAIN specific argument parsing to
> within the doAuth method.
>
> --Peter
>
> -----Original Message-----
> From: Noel J. Bergman [mailto:noel@devtech.com]
> Sent: Friday, July 26, 2002 6:34 PM
> To: James Users List
> Subject: RE: Question about SMTP AUTH and mozilla and apple mail
>
> Excellent news!  :-)  Perhaps Peter can submit it a message to the JAMES
> developer mailing list according to
> http://jakarta.apache.org/site/bugs.html.  Then a few of us can look it
> over, vet it, and encourage the maintainers to commit it.
>
> [Yes, I know that the patch is in the bugs database, but the messsage
> gives
> us a place to hang the thread.]
>
> 	--- Noel
>
> -----Original Message-----
> From: David Rodal [mailto:iridiump@bellatlantic.net]
> Sent: Friday, July 26, 2002 21:16
> To: James Users List
> Subject: Re: Question about SMTP AUTH and mozilla and apple mail
>
>
> Yes Peter's fix works now for my OS X mail AND mozilla under OS X!!!!!
>
> Check out the Peter's attachment for bug 6340 and put it in and you will
> be very happy to!!!!
>
> I'm the happiest man alive right now! :-)
>
> David Rodal
>
> Thanks again everyone.
>
>
> On Friday, July 26, 2002, at 08:36 PM, eric aboudaram wrote:
>
> > i have the same problem and i didn't find a solution
> >
> > mozilla send login@domain
> > strange !!!!
> >
> > i create a user with logn@domain but whitout success
> > :'(
>
>
> --
> To unsubscribe, e-mail:
> <ma...@jakarta.apache.org>
> For additional commands, e-mail:
> <ma...@jakarta.apache.org>
>


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>