You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2018/06/12 16:08:06 UTC
Review Request 67547: Added check for API endpoints not supporting
streaming responses.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67547/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov and Jan Schlicht.
Bugs: MESOS-8985
https://issues.apache.org/jira/browse/MESOS-8985
Repository: mesos
Description
-------
A client can request any endpoint to stream its response using
the RecordIO format. However, we never checked whether the selected
endpoint actually supports streaming, leading to an agent crash
when it was used for endpoints that did not expect such a request.
Diffs
-----
src/slave/http.cpp ba43086f745b0171f699e9ccf90a505f2c5d0f8c
src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328
Diff: https://reviews.apache.org/r/67547/diff/1/
Testing
-------
`make check`
Thanks,
Benno Evers
Re: Review Request 67547: Added check for API endpoints not supporting
streaming responses.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67547/#review204674
-----------------------------------------------------------
src/tests/api_tests.cpp
Lines 7283 (patched)
<https://reviews.apache.org/r/67547/#comment287289>
Does it make sense to add this case to `AgentAPITest.HeaderValidation`?
src/tests/api_tests.cpp
Lines 7285-7287 (patched)
<https://reviews.apache.org/r/67547/#comment287287>
Fits in one line.
src/tests/api_tests.cpp
Lines 7292 (patched)
<https://reviews.apache.org/r/67547/#comment287288>
We don't have to start a master to test this response of the agent API.
- Jan Schlicht
On June 12, 2018, 6:08 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67547/
> -----------------------------------------------------------
>
> (Updated June 12, 2018, 6:08 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Jan Schlicht.
>
>
> Bugs: MESOS-8985
> https://issues.apache.org/jira/browse/MESOS-8985
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A client can request any endpoint to stream its response using
> the RecordIO format. However, we never checked whether the selected
> endpoint actually supports streaming, leading to an agent crash
> when it was used for endpoints that did not expect such a request.
>
>
> Diffs
> -----
>
> src/slave/http.cpp ba43086f745b0171f699e9ccf90a505f2c5d0f8c
> src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328
>
>
> Diff: https://reviews.apache.org/r/67547/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 67547: Added check for API endpoints not supporting
streaming responses.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67547/#review204676
-----------------------------------------------------------
PASS: Mesos patch 67547 was successfully built and tested.
Reviews applied: `['67546', '67547']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67547
- Mesos Reviewbot Windows
On June 12, 2018, 4:08 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67547/
> -----------------------------------------------------------
>
> (Updated June 12, 2018, 4:08 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Jan Schlicht.
>
>
> Bugs: MESOS-8985
> https://issues.apache.org/jira/browse/MESOS-8985
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A client can request any endpoint to stream its response using
> the RecordIO format. However, we never checked whether the selected
> endpoint actually supports streaming, leading to an agent crash
> when it was used for endpoints that did not expect such a request.
>
>
> Diffs
> -----
>
> src/slave/http.cpp ba43086f745b0171f699e9ccf90a505f2c5d0f8c
> src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328
>
>
> Diff: https://reviews.apache.org/r/67547/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 67547: Added check for API endpoints not supporting
streaming responses.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67547/#review204687
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['67546', '67547']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67547
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67547/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (104 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1032 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (32 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (37 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (70 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (755 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (778 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (733 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (757 ms total)
[----------] Global test environment tear-down
[==========] 988 tests from 97 test cases ran. (463113 ms total)
[ PASSED ] 987 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.SigkillExecutor/0, where GetParam() = "docker,mesos"
1 FAILED TEST
YOU HAVE 220 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67547/logs/mesos-tests-stderr.log):
```
I0613 13:49:25.561110 6468 master.cpp:10863] Updating the state of task cb673298-e8d5-453b-bcb9-435b10452873 of framework 55f6394e-b156-402c-b793-d3efd6ae6d72-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0613 13:49:25.561110 6660 slave.cpp:3939] Shutting down framework 55f6394e-b156-402c-b793-d3efd6ae6d72-0000
I061I0613 13:49:25.405112 6428 exec.cpp:162] Version: 1.7.0
I0613 13:49:25.430110 6668 exec.cpp:236] Executor registered on agent 55f6394e-b156-402c-b793-d3efd6ae6d72-S0
I0613 13:49:25.434110 5808 executor.cpp:178] Received SUBSCRIBED event
I0613 13:49:25.439121 5808 executor.cpp:182] Subscribed executor on windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0613 13:49:25.439121 5808 executor.cpp:178] Received LAUNCH event
I0613 13:49:25.444113 5808 executor.cpp:665] Starting task cb673298-e8d5-453b-bcb9-435b10452873
I0613 13:49:25.522122 5808 executor.cpp:485] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0613 13:49:25.534116 5808 executor.cpp:678] Forked command at 6252
I0613 13:49:25.563112 3720 exec.cpp:445] Executor asked to shutdown
I0613 13:49:25.565114 5808 executor.cpp:178] Received SHUTDOWN event
I0613 13:49:25.565114 5808 executor.cpp:781] Shutting down
I0613 13:49:25.565114 5808 executor.cpp:894] Sending SIGTERM to process tree at pid 6253 13:49:25.561110 6660 slave.cpp:6660] Shutting down executor 'cb673298-e8d5-453b-bcb9-435b10452873' of framework 55f6394e-b156-402c-b793-d3efd6ae6d72-0000 at executor(1)@192.10.1.6:52494
I0613 13:49:25.563112 6468 master.cpp:10962] Removing task cb673298-e8d5-453b-bcb9-435b10452873 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 55f6394e-b156-402c-b793-d3efd6ae6d72-0000 on agent 55f6394e-b156-402c-b793-d3efd6ae6d72-S0 at slave(449)@192.10.1.6:52473 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0613 13:49:25.564115 6660 slave.cpp:931] Agent terminating
W0613 13:49:25.564115 6660 slave.cpp:3935] Ignoring shutdown framework 55f6394e-b156-402c-b793-d3efd6ae6d72-0000 because it is terminating
I0613 13:49:25.567112 7092 master.cpp:1293] Agent 55f6394e-b156-402c-b793-d3efd6ae6d72-S0 at slave(449)@192.10.1.6:52473 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0613 13:49:25.567112 7092 master.cpp:3303] Disconnecting agent 55f6394e-b156-402c-b793-d3efd6ae6d72-S0 at slave(449)@192.10.1.6:52473 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0613 13:49:25.568107 5528 hierarchical.cpp:344] Removed framework 55f6394e-b156-402c-b793-d3efd6ae6d72-0000
I0613 13:49:25.568107 7092 master.cpp:3322] Deactivating agent 55f6394e-b156-402c-b793-d3efd6ae6d72-S0 at slave(449)@192.10.1.6:52473 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0613 13:49:25.568107 5528 hierarchical.cpp:766] Agent 55f6394e-b156-402c-b793-d3efd6ae6d72-S0 deactivated
I0613 13:49:25.569106 3344 containerizer.cpp:2405] Destroying container b81694c9-8baf-4b96-8f2b-85122f0dc29d in RUNNING state
I0613 13:49:25.569106 3344 containerizer.cpp:3019] Transitioning the state of container b81694c9-8baf-4b96-8f2b-85122f0dc29d from RUNNING to DESTROYING
I0613 13:49:25.570114 3344 launcher.cpp:155] Asked to destroy container b81694c9-8baf-4b96-8f2b-85122f0dc29d
I0613 13:49:25.641121 2040 containerizer.cpp:2858] Container b81694c9-8baf-4b96-8f2b-85122f0dc29d has exited
I0613 13:49:25.672112 7148 master.cpp:1135] Master terminating
I0613 13:49:25.674111 4756 hierarchical.cpp:609] Removed agent 55f6394e-b156-402c-b793-d3efd6ae6d72-S0
I0613 13:49:25.936107 5964 process.cpp:940] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On June 13, 2018, 4:02 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67547/
> -----------------------------------------------------------
>
> (Updated June 13, 2018, 4:02 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Jan Schlicht.
>
>
> Bugs: MESOS-8985
> https://issues.apache.org/jira/browse/MESOS-8985
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A client can request any endpoint to stream its response using
> the RecordIO format. However, we never checked whether the selected
> endpoint actually supports streaming, leading to an agent crash
> when it was used for endpoints that did not expect such a request.
>
>
> Diffs
> -----
>
> src/slave/http.cpp ba43086f745b0171f699e9ccf90a505f2c5d0f8c
> src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328
>
>
> Diff: https://reviews.apache.org/r/67547/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 67547: Added check for API endpoints not supporting
streaming responses.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67547/#review204733
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67546, 67547]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 13, 2018, 11:02 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67547/
> -----------------------------------------------------------
>
> (Updated June 13, 2018, 11:02 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Jan Schlicht.
>
>
> Bugs: MESOS-8985
> https://issues.apache.org/jira/browse/MESOS-8985
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A client can request any endpoint to stream its response using
> the RecordIO format. However, we never checked whether the selected
> endpoint actually supports streaming, leading to an agent crash
> when it was used for endpoints that did not expect such a request.
>
>
> Diffs
> -----
>
> src/slave/http.cpp ba43086f745b0171f699e9ccf90a505f2c5d0f8c
> src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328
>
>
> Diff: https://reviews.apache.org/r/67547/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 67547: Added check for API endpoints not supporting
streaming responses.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67547/#review204684
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On June 13, 2018, 1:02 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67547/
> -----------------------------------------------------------
>
> (Updated June 13, 2018, 1:02 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Jan Schlicht.
>
>
> Bugs: MESOS-8985
> https://issues.apache.org/jira/browse/MESOS-8985
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A client can request any endpoint to stream its response using
> the RecordIO format. However, we never checked whether the selected
> endpoint actually supports streaming, leading to an agent crash
> when it was used for endpoints that did not expect such a request.
>
>
> Diffs
> -----
>
> src/slave/http.cpp ba43086f745b0171f699e9ccf90a505f2c5d0f8c
> src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328
>
>
> Diff: https://reviews.apache.org/r/67547/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 67547: Added check for API endpoints not supporting
streaming responses.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67547/#review204775
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On June 13, 2018, 11:02 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67547/
> -----------------------------------------------------------
>
> (Updated June 13, 2018, 11:02 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Jan Schlicht.
>
>
> Bugs: MESOS-8985
> https://issues.apache.org/jira/browse/MESOS-8985
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A client can request any endpoint to stream its response using
> the RecordIO format. However, we never checked whether the selected
> endpoint actually supports streaming, leading to an agent crash
> when it was used for endpoints that did not expect such a request.
>
>
> Diffs
> -----
>
> src/slave/http.cpp ba43086f745b0171f699e9ccf90a505f2c5d0f8c
> src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328
>
>
> Diff: https://reviews.apache.org/r/67547/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 67547: Added check for API endpoints not supporting
streaming responses.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67547/
-----------------------------------------------------------
(Updated June 13, 2018, 11:02 a.m.)
Review request for mesos, Alexander Rukletsov and Jan Schlicht.
Bugs: MESOS-8985
https://issues.apache.org/jira/browse/MESOS-8985
Repository: mesos
Description
-------
A client can request any endpoint to stream its response using
the RecordIO format. However, we never checked whether the selected
endpoint actually supports streaming, leading to an agent crash
when it was used for endpoints that did not expect such a request.
Diffs (updated)
-----
src/slave/http.cpp ba43086f745b0171f699e9ccf90a505f2c5d0f8c
src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328
Diff: https://reviews.apache.org/r/67547/diff/3/
Changes: https://reviews.apache.org/r/67547/diff/2-3/
Testing
-------
`make check`
Thanks,
Benno Evers
Re: Review Request 67547: Added check for API endpoints that do not
support streaming responses.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67547/#review204616
-----------------------------------------------------------
PASS: Mesos patch 67547 was successfully built and tested.
Reviews applied: `['67546', '67547']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67547
- Mesos Reviewbot Windows
On June 12, 2018, 4:08 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67547/
> -----------------------------------------------------------
>
> (Updated June 12, 2018, 4:08 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Jan Schlicht.
>
>
> Bugs: MESOS-8985
> https://issues.apache.org/jira/browse/MESOS-8985
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A client can request any endpoint to stream its response using
> the RecordIO format. However, we never checked whether the selected
> endpoint actually supports streaming, leading to an agent crash
> when it was used for endpoints that did not expect such a request.
>
>
> Diffs
> -----
>
> src/slave/http.cpp ba43086f745b0171f699e9ccf90a505f2c5d0f8c
> src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328
>
>
> Diff: https://reviews.apache.org/r/67547/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 67547: Added check for API endpoints that do not
support streaming responses.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67547/#review204661
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67546, 67547]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 12, 2018, 4:08 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67547/
> -----------------------------------------------------------
>
> (Updated June 12, 2018, 4:08 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Jan Schlicht.
>
>
> Bugs: MESOS-8985
> https://issues.apache.org/jira/browse/MESOS-8985
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A client can request any endpoint to stream its response using
> the RecordIO format. However, we never checked whether the selected
> endpoint actually supports streaming, leading to an agent crash
> when it was used for endpoints that did not expect such a request.
>
>
> Diffs
> -----
>
> src/slave/http.cpp ba43086f745b0171f699e9ccf90a505f2c5d0f8c
> src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328
>
>
> Diff: https://reviews.apache.org/r/67547/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 67547: Added check for API endpoints that do not
support streaming responses.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67547/#review204612
-----------------------------------------------------------
src/slave/http.cpp
Lines 559 (patched)
<https://reviews.apache.org/r/67547/#comment287196>
remove one single quote
- Alexander Rukletsov
On June 12, 2018, 4:08 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67547/
> -----------------------------------------------------------
>
> (Updated June 12, 2018, 4:08 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Jan Schlicht.
>
>
> Bugs: MESOS-8985
> https://issues.apache.org/jira/browse/MESOS-8985
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A client can request any endpoint to stream its response using
> the RecordIO format. However, we never checked whether the selected
> endpoint actually supports streaming, leading to an agent crash
> when it was used for endpoints that did not expect such a request.
>
>
> Diffs
> -----
>
> src/slave/http.cpp ba43086f745b0171f699e9ccf90a505f2c5d0f8c
> src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328
>
>
> Diff: https://reviews.apache.org/r/67547/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benno Evers
>
>