[GitHub] [couchdb-helm] willholley commented on pull request #42: Cluster setup

[GitBox <gi...@apache.org>]

willholley commented on pull request #42:
URL: https://github.com/apache/couchdb-helm/pull/42#issuecomment-696147441


   > E2E tests do pass for me, once I apply this small patch. Should I add this to the PR?
   > 
   > ```diff
   > --- a/test/kind-config.yaml
   > +++ b/test/kind-config.yaml
   > @@ -1,5 +1,5 @@
   >  kind: Cluster
   > -apiVersion: kind.sigs.k8s.io/v1alpha3
   > +apiVersion: kind.x-k8s.io/v1alpha4
   >  nodes:
   >    - role: control-plane
   >  E2E tests do pass for me, once I apply this small patch. Should I add this to the PR?
   
   Yes please. Bear in mind the tests will use the default values, so won't execute with `clusterSetup: true` unless it's added as a scenario in https://github.com/apache/couchdb-helm/tree/master/couchdb/ci. Essentially, the E2E tests are executed using each file as the `values.yaml` input to Helm, so you can either add a new file to test a specific set of values or incorporate the new setting into an existing test.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org