You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/10/15 18:20:22 UTC

[GitHub] [incubator-kyuubi] bowenliang123 opened a new issue, #3635: [Improvement] delete files on exit in test suits with Utils.createTempDir

bowenliang123 opened a new issue, #3635:
URL: https://github.com/apache/incubator-kyuubi/issues/3635

   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I have searched in the [issues](https://github.com/apache/incubator-kyuubi/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### What would you like to be improved?
   
   Leaking temp undeleted directories causing disk usage for repeated tests or builds.
   About 8 places in test suites using `Files.createTempDirectory` to create temp directories without cleanup on exit.
   
   ### How should we improve?
   
   - use `Utils.createTempDir` of `kyuubi-common` module to create temp dir with delete on exit
   - change signature `Utils.createTempDir` by making `prefix` param from second place to the first, to make it friendly to use without repeating param name itself
   
   ### Are you willing to submit PR?
   
   - [X] Yes. I can submit a PR independently to improve.
   - [ ] Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
   - [ ] No. I cannot submit a PR at this time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] pan3793 closed issue #3635: [Improvement] delete files on exit in test suits with Utils.createTempDir

Posted by GitBox <gi...@apache.org>.
pan3793 closed issue #3635: [Improvement] delete files on exit in test suits with Utils.createTempDir
URL: https://github.com/apache/incubator-kyuubi/issues/3635


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org