[jira] [Commented] (BOOKKEEPER-577) BookieFailureTest uses sync/wait()/notify() incorrectly

["Flavio Junqueira (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649169#comment-13649169 ] 

Flavio Junqueira commented on BOOKKEEPER-577:
---------------------------------------------

I'm sorry for taking some time to respond, I missed that you have added a comment here. 

I'm not sure I get your point. This assertion:

{noformat}
assertTrue("Haven't received entries", sync.value);
{noformat}

will always hold after the while loop, otherwise it will keep looping. What's the point of having the assertion after the loop then? I'm thinking that we should perhaps just remove that assertion altogether instead of moving it.
                
> BookieFailureTest uses sync/wait()/notify() incorrectly
> -------------------------------------------------------
>
>                 Key: BOOKKEEPER-577
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-577
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.3.0
>
>         Attachments: 0001-BOOKKEEPER-577-BookieFailureTest-uses-sync-wait-noti.patch
>
>
> This makes it susceptible to spurious wakeup issues, which seem to hit very regularly on my laptop.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira