Re: [PR] Fix smoke tests due to change in behavior of restore VM [cloudstack]

["shwstppr (via GitHub)" <gi...@apache.org>]

shwstppr commented on code in PR #10583:
URL: https://github.com/apache/cloudstack/pull/10583#discussion_r2009429517


##########
test/integration/smoke/test_events_resource.py:
##########
@@ -161,21 +157,12 @@ def test_01_events_resource(self):
         virtual_machine.restore(self.apiclient)
         time.sleep(self.services["sleep"])
         virtual_machine.detach_volume(self.apiclient, volume)
-        volume.delete(self.apiclient)
-        self.cleanup.remove(volume)
         ts = str(time.time())
         virtual_machine.update(self.apiclient, displayname=ts)
-        virtual_machine.delete(self.apiclient)
-        self.cleanup.remove(virtual_machine)
         account_network.update(self.apiclient, name=account_network.name + ts)
-        account_network.delete(self.apiclient)
-        self.cleanup.remove(account_network)
+        virtual_machine.start(self.apiclient)

Review Comment:
   @Pearl1594 I'm not completely aware of the new behaviour but idea of the test was to do a bunch of operations related to VM, network, volume etc and then check if the events for them have resourceid an resourcetype associated for them. Can we update the test in a way that similar check can be done? With the current change it is checking only for VM action event.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org