You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@nemo.apache.org by GitBox <gi...@apache.org> on 2019/10/19 21:34:49 UTC

[GitHub] [incubator-nemo] seojangho opened a new pull request #244: [NEMO-422] Address code quality issues for ResourceSitePass, NetworkTraceAnalysis, PhysicalPlanGenerator, and bytetransfer

seojangho opened a new pull request #244: [NEMO-422] Address code quality issues for ResourceSitePass, NetworkTraceAnalysis, PhysicalPlanGenerator, and bytetransfer
URL: https://github.com/apache/incubator-nemo/pull/244
 
 
   JIRA: [NEMO-422: SonarCloud issues](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-422)
   
   **Major changes:**
   - None
   
   **Minor changes to note:**
   - ResourceSitePass: Fixed an operand in arithmetic expression to express its type explicitly.
   - example/NetworkTraceAnalysis: Replaced at-most-one-iteration loop with if-else.
   - PhysicalPlanGenerator: Use isPresent instead of orElseThrow for sanity checks.
   - bytetransfer: Removed 'volatile' for object types.
   
   **Tests for the changes:**
   - Existing tests should be sufficient.
   
   **Other comments:**
   - None

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services