You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/13 03:28:13 UTC
[GitHub] [shardingsphere] RaigorJiang opened a new issue, #22844: Add `IF NOT EXISTS` to all `CREATE` statements in DistSQL
RaigorJiang opened a new issue, #22844:
URL: https://github.com/apache/shardingsphere/issues/22844
Hi community,
Previously, we had added the `IF EXISTS` option to the `DROP` statement in DistSQL. (#15623)
Correspondingly, we need to add the `IF NOT EXISTS` option to the `CREATE` statement, just like `CREATE TABLE [IF NOT EXISTS] tbl_name`.
E.g
- `CREATE SHARDING TABLE RULE IF NOT EXISTS xxx`
- `CREATE ENCRYPT RULE IF NOT EXISTS xxx`
### Tasks
- [ ] REGISTER STORAGE UNIT
- [ ] CREATE SHARDING TABLE RULE
- [ ] CREATE SHARDING TABLE REFERENCE RULE
- [ ] CREATE BROADCAST TABLE RULE
- [ ] CREATE DEFAULT SHARDING [DATABASE | TABLE] STRATEGY
- [ ] CREATE ENCRYPT RULE
- [ ] CREATE DB_DISCOVERY RULE
- [ ] CREATE READWRITE_SPLITTING RULE
- [ ] CREATE SHADOW RULE
- [ ] CREATE DEFAULT SHADOW ALGORITHM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] yx9o commented on issue #22844: Add `IF NOT EXISTS` to all `CREATE` statements in DistSQL
Posted by GitBox <gi...@apache.org>.
yx9o commented on issue #22844:
URL: https://github.com/apache/shardingsphere/issues/22844#issuecomment-1367314852
@RaigorJiang ok i will follow up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Qianyi951015 commented on issue #22844: Add `IF NOT EXISTS` to all `CREATE` statements in DistSQL
Posted by GitBox <gi...@apache.org>.
Qianyi951015 commented on issue #22844:
URL: https://github.com/apache/shardingsphere/issues/22844#issuecomment-1362652780
> @Qianyi951015 Welcome, I think you can do it one by one :)
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #22844: Add `IF NOT EXISTS` to all `CREATE` statements in DistSQL
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #22844:
URL: https://github.com/apache/shardingsphere/issues/22844#issuecomment-1347705603
Hi @yx9o, Nice to see you here, I will assign this issue to you. 😀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #22844: Add `IF NOT EXISTS` to all `CREATE` statements in DistSQL
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on issue #22844:
URL: https://github.com/apache/shardingsphere/issues/22844#issuecomment-1407328100
Completed, thank you all @yx9o @Qianyi951015
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] yx9o commented on issue #22844: Add `IF NOT EXISTS` to all `CREATE` statements in DistSQL
Posted by GitBox <gi...@apache.org>.
yx9o commented on issue #22844:
URL: https://github.com/apache/shardingsphere/issues/22844#issuecomment-1347704053
@RaigorJiang Hi, I want to participate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang closed issue #22844: Add `IF NOT EXISTS` to all `CREATE` statements in DistSQL
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang closed issue #22844: Add `IF NOT EXISTS` to all `CREATE` statements in DistSQL
URL: https://github.com/apache/shardingsphere/issues/22844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #22844: Add `IF NOT EXISTS` to all `CREATE` statements in DistSQL
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #22844:
URL: https://github.com/apache/shardingsphere/issues/22844#issuecomment-1362651779
@Qianyi951015 Welcome, I think you can do it one by one :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #22844: Add `IF NOT EXISTS` to all `CREATE` statements in DistSQL
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #22844:
URL: https://github.com/apache/shardingsphere/issues/22844#issuecomment-1367042940
Hi @yx9o ,
I found that `RuleDefinitionUpdater` is declared as `SingletonSPI`, so please check for thread safety risks.
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Qianyi951015 commented on issue #22844: Add `IF NOT EXISTS` to all `CREATE` statements in DistSQL
Posted by GitBox <gi...@apache.org>.
Qianyi951015 commented on issue #22844:
URL: https://github.com/apache/shardingsphere/issues/22844#issuecomment-1362533685
Hi @RaigorJiang @yx9o can i pick these tasks?
- REGISTER STORAGE UNIT
- CREATE SHARDING TABLE RULE
- CREATE SHARDING TABLE REFERENCE RULE
- CREATE BROADCAST TABLE RULE
- CREATE DEFAULT SHARDING [DATABASE | TABLE] STRATEGY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org