You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Sam Hough (JIRA)" <ji...@apache.org> on 2007/10/05 12:37:52 UTC

[jira] Created: (WICKET-1044) Clarification of when children are added to Component tree for TabbedPanel

Clarification of when children are added to Component tree for TabbedPanel
--------------------------------------------------------------------------

                 Key: WICKET-1044
                 URL: https://issues.apache.org/jira/browse/WICKET-1044
             Project: Wicket
          Issue Type: Improvement
          Components: wicket
    Affects Versions: 1.3.0-beta3
            Reporter: Sam Hough


TabbedPanel only adds the components in a tab to the primary component tree in onBeforeRender. This caught me out so maybe a note in the javadoc would help other users?

I was expecting MarkupContainer.visitChildren to visit at least the active tab's components (not sure I had thought past that).

Does any other component hold a private tree of components rather than attached to the primary tree? Maybe using setVisible would be less surprising to developers or would that have nasty performance implications?

Thanks

Sam

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WICKET-1044) Clarification of when children are added to Component tree for TabbedPanel

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-1044.
-----------------------------------

       Resolution: Won't Fix
    Fix Version/s: 1.3.0-beta4
         Assignee: Igor Vaynberg

You cannot count on component hierarchies being fully initialized after the constructor. repeaters and tabbedpanel, and many others only fully initialize themselves in onbeforerender, so if you want to use a visitor you have to do it at that point also. make sure to call super.onbeforerender() first.

> Clarification of when children are added to Component tree for TabbedPanel
> --------------------------------------------------------------------------
>
>                 Key: WICKET-1044
>                 URL: https://issues.apache.org/jira/browse/WICKET-1044
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.0-beta3
>            Reporter: Sam Hough
>            Assignee: Igor Vaynberg
>             Fix For: 1.3.0-beta4
>
>
> TabbedPanel only adds the components in a tab to the primary component tree in onBeforeRender. This caught me out so maybe a note in the javadoc would help other users?
> I was expecting MarkupContainer.visitChildren to visit at least the active tab's components (not sure I had thought past that).
> Does any other component hold a private tree of components rather than attached to the primary tree? Maybe using setVisible would be less surprising to developers or would that have nasty performance implications?
> Thanks
> Sam

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.