You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/25 23:02:04 UTC
[jira] [Commented] (BEAM-1749) Upgrade pep8 to pycodestyle

    [ https://issues.apache.org/jira/browse/BEAM-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983787#comment-15983787 ] 

ASF GitHub Bot commented on BEAM-1749:
--------------------------------------

GitHub user sb2nov opened a pull request:

    https://github.com/apache/beam/pull/2686

    [BEAM-1749] Upgrade to pycodestyle from pep8

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    R: @aaltay PTAL

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sb2nov/beam BEAM-1749-pycodestyle

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2686.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2686
    
----
commit 1641287cfa80c386dd5fb449061293afedb3a264
Author: Sourabh Bajaj <so...@google.com>
Date:   2017-04-25T23:00:18Z

    [BEAM-1749] Upgrade to pycodestyle

----


> Upgrade pep8 to pycodestyle
> ---------------------------
>
>                 Key: BEAM-1749
>                 URL: https://issues.apache.org/jira/browse/BEAM-1749
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py
>            Reporter: Ahmet Altay
>              Labels: newbie, starter
>
> pep8 was deprecated and replaced with pycodestyle
> We should upgrade our linter to this module, and while doing that re-evaluate our linter strategy and see if we can enable more rules. This is important for keeping the code healthy as the community grows.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)