You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by mtaylor <gi...@git.apache.org> on 2017/03/10 17:36:42 UTC
[GitHub] activemq-artemis pull request #1087: ARTEMIS-1031 Fix prefix support
GitHub user mtaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1087
ARTEMIS-1031 Fix prefix support
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtaylor/activemq-artemis ARTEMIS-1031
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1087.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1087
----
commit dd067409e8f2d3c495e976212f41796bdae470cf
Author: Martyn Taylor <mt...@redhat.com>
Date: 2017-03-10T17:35:51Z
ARTEMIS-1031 Fix prefix support
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1087: ARTEMIS-1031 Fix prefix support
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1087
@mtaylor non intentional. it was probably some gitfu before as I was rebasing against my branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1087: ARTEMIS-1031 Fix prefix support
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1087
@clebertsuconic This removes a bunch of code you added to strip prefix from the address. Was there a reason to do this? We don't change the send address for prefixes. Client will receive "multicast://foo" for example. We add the proper address to the RoutingContext but leave the message as is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1087: ARTEMIS-1031 Fix prefix support
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1087
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---