You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "EpsilonPrime (via GitHub)" <gi...@apache.org> on 2023/03/22 05:31:50 UTC

[GitHub] [arrow] EpsilonPrime commented on a diff in pull request #34671: GH-15233: [C++] Correct thread contention in s3fs

EpsilonPrime commented on code in PR #34671:
URL: https://github.com/apache/arrow/pull/34671#discussion_r1144246166


##########
cpp/src/arrow/filesystem/s3fs.cc:
##########
@@ -1244,12 +1244,12 @@ class ObjectOutputStream final : public io::OutputStream {
 
     if (current_part_) {
       // Upload last part
-      RETURN_NOT_OK(CommitCurrentPart());
+      RETURN_NOT_OK(CommitCurrentPart(true));

Review Comment:
   Sure, I've gotten away from the practice of adding the extra comments as my IDE does this for me, but done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org