You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/29 08:32:44 UTC
[GitHub] [doris] liaoxin01 opened a new pull request, #15481: [fix](index) fix that the last element of each batch will be read repeatedly for binary prefix page
liaoxin01 opened a new pull request, #15481:
URL: https://github.com/apache/doris/pull/15481
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #15481: [fix](index) fix that the last element of each batch will be read repeatedly for binary prefix page
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #15481:
URL: https://github.com/apache/doris/pull/15481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15481: [fix](index) fix that the last element of each batch will be read repeatedly for binary prefix page
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15481:
URL: https://github.com/apache/doris/pull/15481#issuecomment-1367259490
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15481: [fix](index) fix that the last element of each batch will be read repeatedly for binary prefix page
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15481:
URL: https://github.com/apache/doris/pull/15481#issuecomment-1367683850
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zhannngchen commented on a diff in pull request #15481: [fix](index) fix that the last element of each batch will be read repeatedly for binary prefix page
Posted by GitBox <gi...@apache.org>.
zhannngchen commented on code in PR #15481:
URL: https://github.com/apache/doris/pull/15481#discussion_r1059245234
##########
be/src/olap/rowset/segment_v2/binary_prefix_page.cpp:
##########
@@ -257,21 +257,23 @@ Status BinaryPrefixPageDecoder::next_batch(size_t* n, ColumnBlockView* dst) {
RETURN_IF_ERROR(_copy_current_to_output(dst->pool(), out));
i++;
out++;
+ _cur_pos++;
// read and copy remaining values
for (; i < max_fetch; ++i) {
- _cur_pos++;
RETURN_IF_ERROR(_read_next_value_to_output(prev[i - 1], dst->pool(), out));
out++;
+ _cur_pos++;
}
//must update _current_value
_current_value.clear();
_current_value.assign_copy((uint8_t*)prev[i - 1].data, prev[i - 1].size);
Review Comment:
this `assign_copy` is not needed now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15481: [fix](index) fix that the last element of each batch will be read repeatedly for binary prefix page
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15481:
URL: https://github.com/apache/doris/pull/15481#issuecomment-1367683839
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] liaoxin01 commented on a diff in pull request #15481: [fix](index) fix that the last element of each batch will be read repeatedly for binary prefix page
Posted by GitBox <gi...@apache.org>.
liaoxin01 commented on code in PR #15481:
URL: https://github.com/apache/doris/pull/15481#discussion_r1059255115
##########
be/src/olap/rowset/segment_v2/binary_prefix_page.cpp:
##########
@@ -257,21 +257,23 @@ Status BinaryPrefixPageDecoder::next_batch(size_t* n, ColumnBlockView* dst) {
RETURN_IF_ERROR(_copy_current_to_output(dst->pool(), out));
i++;
out++;
+ _cur_pos++;
// read and copy remaining values
for (; i < max_fetch; ++i) {
- _cur_pos++;
RETURN_IF_ERROR(_read_next_value_to_output(prev[i - 1], dst->pool(), out));
out++;
+ _cur_pos++;
}
//must update _current_value
_current_value.clear();
_current_value.assign_copy((uint8_t*)prev[i - 1].data, prev[i - 1].size);
Review Comment:
It is needed. _read_next_value needs to know the previous value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15481: [fix](index) fix that the last element of each batch will be read repeatedly for binary prefix page
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15481:
URL: https://github.com/apache/doris/pull/15481#issuecomment-1367267660
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.95 seconds
load time: 659 seconds
storage size: 17122365479 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221229115502_clickbench_pr_70944.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15481: [fix](index) fix that the last element of each batch will be read repeatedly for binary prefix page
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15481:
URL: https://github.com/apache/doris/pull/15481#issuecomment-1367156124
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org