You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Dirk Moebius (JIRA)" <de...@myfaces.apache.org> on 2007/10/15 14:19:50 UTC

[jira] Created: (TOMAHAWK-1129) ReducedHTMLParser: wrong line numbers

ReducedHTMLParser: wrong line numbers
-------------------------------------

                 Key: TOMAHAWK-1129
                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1129
             Project: MyFaces Tomahawk
          Issue Type: Bug
    Affects Versions: 1.1.6
         Environment: MyFaces 1.1.5
            Reporter: Dirk Moebius
         Attachments: ReducedHTMLParser.java.patch

ReducedHTMLParser reports wrong line numbers in exceptions. The reason is because in consumeExcept(String) the member variable _lineNumber is increased twice because of code duplication.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TOMAHAWK-1129) ReducedHTMLParser: wrong line numbers

Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TOMAHAWK-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604994#action_12604994 ] 

Leonardo Uribe commented on TOMAHAWK-1129:
------------------------------------------

I'm using tomahawk 1.1.7-SNAPSHOT and myfaces 1.1.6, I just make an error on a jsp page and the line number are returned correctly. Maybe the editor that you are using for jsp pages cause the problem.

Could you post the file and the error situation, so the algorithm can be analized in deep and solved

> ReducedHTMLParser: wrong line numbers
> -------------------------------------
>
>                 Key: TOMAHAWK-1129
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1129
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>    Affects Versions: 1.1.6
>         Environment: MyFaces 1.1.5
>            Reporter: Dirk Moebius
>         Attachments: ReducedHTMLParser.java.patch
>
>
> ReducedHTMLParser reports wrong line numbers in exceptions. The reason is because in consumeExcept(String) the member variable _lineNumber is increased twice because of code duplication.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TOMAHAWK-1129) ReducedHTMLParser: wrong line numbers

Posted by "Dirk Moebius (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TOMAHAWK-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dirk Moebius updated TOMAHAWK-1129:
-----------------------------------

    Status: Patch Available  (was: Open)

> ReducedHTMLParser: wrong line numbers
> -------------------------------------
>
>                 Key: TOMAHAWK-1129
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1129
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>    Affects Versions: 1.1.6
>         Environment: MyFaces 1.1.5
>            Reporter: Dirk Moebius
>         Attachments: ReducedHTMLParser.java.patch
>
>
> ReducedHTMLParser reports wrong line numbers in exceptions. The reason is because in consumeExcept(String) the member variable _lineNumber is increased twice because of code duplication.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TOMAHAWK-1129) ReducedHTMLParser: wrong line numbers

Posted by "Dirk Moebius (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TOMAHAWK-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605220#action_12605220 ] 

Dirk Moebius commented on TOMAHAWK-1129:
----------------------------------------

Hmm... I reported this issue is so long ago; I can't remember how to reproduce it. Sorry, I should have given a more detailled description of the problem.

The error does not occur if there's a parsing error on the jsp page -- those errors will be detected by the jasper compiler. ReducedHTMLParser is used by the ExtensionsFilter only, so it has to be an error regarding javascript or multipart requests. But I can't remember. :-(

Please leave this error open for two weeks so that I can investigate and give further details.


> ReducedHTMLParser: wrong line numbers
> -------------------------------------
>
>                 Key: TOMAHAWK-1129
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1129
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>    Affects Versions: 1.1.6
>         Environment: MyFaces 1.1.5
>            Reporter: Dirk Moebius
>         Attachments: ReducedHTMLParser.java.patch
>
>
> ReducedHTMLParser reports wrong line numbers in exceptions. The reason is because in consumeExcept(String) the member variable _lineNumber is increased twice because of code duplication.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.