[GitHub] [netbeans] neilcsmith-net commented on pull request #2524: Increase the major version for php.editor

[GitBox <gi...@apache.org>]

neilcsmith-net commented on pull request #2524:
URL: https://github.com/apache/netbeans/pull/2524#issuecomment-723060489


   > Well, not happy about this one, but it's not all about happiness after all.
   
   @lkishalmi yes, that was my concern about having sigtests PR land too late during the release phase. I think we need to think post-release how to do this, and also why certain issues were not picked up earlier (tests?). I don't have much comment on this in particular, but do think @JaroslavTulach comments on #2504 need resolving for release.  That was in my mind from comments on previous releases, but bit surprised how many concerns in this one.
   
   > Then you can remove the fixed Implementation-Version and it will be autogenerated to today's date, unless I am mistaken.
   
   This should be generated from git hash rather than date now, and is why the source releases have that gitinfo file.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists