You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by dguy <gi...@git.apache.org> on 2016/07/04 16:58:00 UTC

[GitHub] kafka pull request #1584: MINOR: fix generics in KStream.groupBy(...)

GitHub user dguy opened a pull request:

    https://github.com/apache/kafka/pull/1584

    MINOR: fix generics in KStream.groupBy(...)

    The `KStream.groupBy(..)` calls don't change the value, only the key, so they don't need the type param `V1` as the new stream will always be of type `KStream<K1, V>`.
    The `Serde` in the overloaded `groupBy` should have a type param of  `V` to match the returned `KStream`
     

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dguy/kafka kstream-generics

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1584.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1584
    
----
commit 7db01e26d47f7f5b59e54552bf6a388c61e1af04
Author: Damian Guy <da...@gmail.com>
Date:   2016-07-04T14:33:50Z

    fix generics in KStream.groupBy()

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #1584: MINOR: fix generics in KStream.groupBy(...)

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/1584


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---