You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "xumanbu (via GitHub)" <gi...@apache.org> on 2023/03/03 03:31:24 UTC
[GitHub] [incubator-uniffle] xumanbu opened a new pull request, #677: [fix][#675] check disk enough avoid No Enough exception in checkStorageReadAndWrite
xumanbu opened a new pull request, #677:
URL: https://github.com/apache/incubator-uniffle/pull/677
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
No.
### Why are the changes needed?
Fix: #675
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
No need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #677: [#675] fix: filter no space exception in checkStorageReadAndWrite
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on code in PR #677:
URL: https://github.com/apache/incubator-uniffle/pull/677#discussion_r1124143726
##########
server/src/main/java/org/apache/uniffle/server/LocalStorageChecker.java:
##########
@@ -200,6 +202,9 @@ boolean checkStorageReadAndWrite() {
}
} catch (Exception e) {
LOG.error("Storage read and write error. Storage dir: {}", storageDir, e);
+ if(e.getMessage()!= null && DEVICE_NO_SPACE_ERROR_MESSAGE.equals(e.getMessage())){
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #677: [#675] fix: filter no space exception in checkStorageReadAndWrite
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #677:
URL: https://github.com/apache/incubator-uniffle/pull/677#issuecomment-1523007299
Nice catch. I found the same problems. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #677: [#675] fix: check disk enough avoid No Enough exception in checkStorageReadAndWrite
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #677:
URL: https://github.com/apache/incubator-uniffle/pull/677#discussion_r1124133176
##########
server/src/main/java/org/apache/uniffle/server/LocalStorageChecker.java:
##########
@@ -200,6 +202,9 @@ boolean checkStorageReadAndWrite() {
}
} catch (Exception e) {
LOG.error("Storage read and write error. Storage dir: {}", storageDir, e);
+ if(e.getMessage()!= null && DEVICE_NO_SPACE_ERROR_MESSAGE.equals(e.getMessage())){
Review Comment:
Could you add some comments to explain why we do so?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #677: [#675] fix: check disk enough avoid No Enough exception in checkStorageReadAndWrite
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #677:
URL: https://github.com/apache/incubator-uniffle/pull/677#issuecomment-1452926711
Could you test this patch by hand? Could you modify the description of `What changes were proposed in this pull request?`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi merged pull request #677: [#675] fix: filter no space exception in checkStorageReadAndWrite
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi merged PR #677:
URL: https://github.com/apache/incubator-uniffle/pull/677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #677: [fix][#675] check disk enough avoid No Enough exception in checkStorageReadAndWrite
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #677:
URL: https://github.com/apache/incubator-uniffle/pull/677#discussion_r1124001922
##########
server/src/main/java/org/apache/uniffle/server/LocalStorageChecker.java:
##########
@@ -73,7 +73,8 @@ public boolean checkIsHealthy() {
int corruptedDirs = 0;
for (StorageInfo storageInfo : storageInfos) {
- if (!storageInfo.checkStorageReadAndWrite()) {
+ if (storageInfo.checkIsSpaceEnough()
Review Comment:
`checkIsSpaceEnough` can't guaratee that the disk is full. It only means that the disk capacity is very high.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org