You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/01/10 23:39:29 UTC
[GitHub] [orc] dongjoon-hyun opened a new pull request #620: ORC-648: Add GitHub Action for Java8/11 test coverage
dongjoon-hyun opened a new pull request #620:
URL: https://github.com/apache/orc/pull/620
### What changes were proposed in this pull request?
This PR aims to add `GitHub Action` for explicit Java 8/11 test coverage. Since this is an independent CI setup, this will not interfere with the existing CIs.
### Why are the changes needed?
Apache ORC is currently using
- Travis CI for testing various `clang` versions on Trusty and Mac with JDK7.
- Appveyor CI for testing Visual Studio on Windows OS.
### How was this patch tested?
Check the Github Action result on this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] pgaref commented on pull request #620: ORC-648: Add GitHub Action for Java8/11 test coverage
Posted by GitBox <gi...@apache.org>.
pgaref commented on pull request #620:
URL: https://github.com/apache/orc/pull/620#issuecomment-757686275
Late +1 on this. Thanks @dongjoon-hyun !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #620: ORC-648: Add GitHub Action for Java8/11 test coverage
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #620:
URL: https://github.com/apache/orc/pull/620#issuecomment-757575253
Could you review this please, @pgaref ? This will help the next Apache ORC 1.5.x release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #620: ORC-648: Add GitHub Action for Java8/11 test coverage
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #620:
URL: https://github.com/apache/orc/pull/620#issuecomment-757686519
Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #620: ORC-648: Add GitHub Action for Java8/11 test coverage
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #620:
URL: https://github.com/apache/orc/pull/620
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] pgaref commented on pull request #620: ORC-648: Add GitHub Action for Java8/11 test coverage
Posted by GitBox <gi...@apache.org>.
pgaref commented on pull request #620:
URL: https://github.com/apache/orc/pull/620#issuecomment-758080202
Thanks again @dongjoon-hyun !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #620: ORC-648: Add GitHub Action for Java8/11 test coverage
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #620:
URL: https://github.com/apache/orc/pull/620#issuecomment-757612981
Since this is irrelevant to orc code itself, I'll merge this~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #620: ORC-648: Add GitHub Action for Java8/11 test coverage
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #620:
URL: https://github.com/apache/orc/pull/620#issuecomment-758070618
Thanks, @pgaref . According to your advice, I backported it too.
- https://github.com/apache/orc/commit/f7618213b121596dda6c74d30622089c65a11dc3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] pgaref commented on pull request #620: ORC-648: Add GitHub Action for Java8/11 test coverage
Posted by GitBox <gi...@apache.org>.
pgaref commented on pull request #620:
URL: https://github.com/apache/orc/pull/620#issuecomment-757687587
PS: At some point we should also add the style check on this branch as well since @williamhyun 's work is already ported
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org