You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/03/26 10:54:33 UTC
[GitHub] [camel-k] mmajerni opened a new pull request #2176: test: Add tests for kamel describe
mmajerni opened a new pull request #2176:
URL: https://github.com/apache/camel-k/pull/2176
<!-- Description -->
PR for: https://issues.redhat.com/browse/FUSEQE-12069
Merge after https://github.com/apache/camel-k/pull/2126 (Because of GetOutputString())
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] vsokolov00 commented on pull request #2176: test: Add tests for kamel describe
Posted by GitBox <gi...@apache.org>.
vsokolov00 commented on pull request #2176:
URL: https://github.com/apache/camel-k/pull/2176#issuecomment-865120493
merge after #2422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] vsokolov00 commented on a change in pull request #2176: test: Add tests for kamel describe
Posted by GitBox <gi...@apache.org>.
vsokolov00 commented on a change in pull request #2176:
URL: https://github.com/apache/camel-k/pull/2176#discussion_r658555675
##########
File path: e2e/common/cli/kamel_describe_test.go
##########
@@ -0,0 +1,64 @@
+// +build integration
+
+// To enable compilation of this file in Goland, go to "Settings -> Go -> Vendoring & Build Tags -> Custom Tags" and add "integration"
+
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package common
+
+import (
+ "testing"
+
+ . "github.com/onsi/gomega"
+ . "github.com/apache/camel-k/e2e/support"
+ "github.com/apache/camel-k/pkg/util/defaults"
+ v1 "k8s.io/api/core/v1"
+)
+
+func TestKamelCliDescribe(t *testing.T) {
+ WithNewTestNamespace(t, func(ns string) {
+ Expect(Kamel("install", "-n", ns).Execute()).To(Succeed())
+ Expect(Kamel("run", "-n", ns, "files/yaml.yaml").Execute()).To(Succeed())
+ Eventually(IntegrationPodPhase(ns, "yaml"), TestTimeoutLong).Should(Equal(v1.PodRunning))
+
+ t.Run("Test kamel describe integration", func(t *testing.T) {
+ integration := GetOutputString(Kamel("describe","integration", "yaml", "-n", ns))
+ Expect(integration).To(ContainSubstring("Name: yaml"))
+ Expect(integration).To(ContainSubstring("Phase: Running"))
+ Expect(integration).To(ContainSubstring("Dependencies:"))
+ Expect(integration).To(ContainSubstring("Conditions:"))
+ })
+
+ t.Run("Test kamel describe integration kit", func(t *testing.T) {
+ kitName := Integration(ns, "yaml")().Status.Kit
Review comment:
As far as I know this way of getting the kit name is deprecated, so I'd recommend to use this one:
kitName := Integration(ns, "yaml")().Status.IntegrationKit.Name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] oscerd closed pull request #2176: test: Add tests for kamel describe
Posted by GitBox <gi...@apache.org>.
oscerd closed pull request #2176:
URL: https://github.com/apache/camel-k/pull/2176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] vsokolov00 edited a comment on pull request #2176: test: Add tests for kamel describe
Posted by GitBox <gi...@apache.org>.
vsokolov00 edited a comment on pull request #2176:
URL: https://github.com/apache/camel-k/pull/2176#issuecomment-950688654
@oscerd Could you please close it? These changes were delivered in #2680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] vsokolov00 commented on pull request #2176: test: Add tests for kamel describe
Posted by GitBox <gi...@apache.org>.
vsokolov00 commented on pull request #2176:
URL: https://github.com/apache/camel-k/pull/2176#issuecomment-865120493
merge after #2422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] mmajerni commented on pull request #2176: test: Add tests for kamel describe
Posted by GitBox <gi...@apache.org>.
mmajerni commented on pull request #2176:
URL: https://github.com/apache/camel-k/pull/2176#issuecomment-866903139
@astefanutti done, rebased ^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #2176: test: Add tests for kamel describe
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #2176:
URL: https://github.com/apache/camel-k/pull/2176#issuecomment-865699222
#2422 has been merged, could you rebase that one? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] vsokolov00 commented on pull request #2176: test: Add tests for kamel describe
Posted by GitBox <gi...@apache.org>.
vsokolov00 commented on pull request #2176:
URL: https://github.com/apache/camel-k/pull/2176#issuecomment-950688654
@oscerd Could you please close it? These changes were delivered in 2680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] vsokolov00 commented on pull request #2176: test: Add tests for kamel describe
Posted by GitBox <gi...@apache.org>.
vsokolov00 commented on pull request #2176:
URL: https://github.com/apache/camel-k/pull/2176#issuecomment-927706769
Since !2495 was closed the redirection of `kamel describe` command output works now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org