You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geronimo.apache.org by "Ivan (Issue Comment Edited) (JIRA)" <ji...@apache.org> on 2012/03/27 15:54:26 UTC

[jira] [Issue Comment Edited] (GERONIMO-6305) Start bundles in EBA according to bundle dependencies

    [ https://issues.apache.org/jira/browse/GERONIMO-6305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239454#comment-13239454 ] 

Ivan edited comment on GERONIMO-6305 at 3/27/12 1:54 PM:
---------------------------------------------------------

My two cents for the patch :
1. Think we should not replace the Set with the List type for the applicationBundles, if we would like to keep the order, think the LinkedHashSet should be enough.
2. This may be the first time to see the using of loop tag in the codes :-) Think it is not must, maybe we could change the code structure to avoid that.
3. Would like to suggest to use the existing SortUtils in the kernel package, it should be OK for this scenario, while I am not insisting on that. 
                
      was (Author: xuhaihong):
    My two cents for the patch :
1. Think we should not replace the Set with the List type for the applicationBundles, if we would like to keep the order, think the LinkedHashSet should be enough.
2. This may be the first time for me to use loop tag in the codes :-) Think it is not must, maybe we could change the code structure to avoid that.
3. Would like to suggest to use the existing SortUtils in the kernel package, it should be OK for this scenario, while I am not insisting on that. 
                  
> Start bundles in EBA according to bundle dependencies
> -----------------------------------------------------
>
>                 Key: GERONIMO-6305
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-6305
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: osgi-bundles
>            Reporter: Yi Xiao
>            Assignee: Yi Xiao
>         Attachments: startBundlesInOrder_6305.patch
>
>
> As the bundles have the dependency, so need to provide the correct order when they start up.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira